Add two special cases url recentlyused:/files and recentlyused:/folders
AcceptedPublic

Authored by meven on Thu, Sep 5, 3:51 PM.

Details

Reviewers
ivan
ngraham
Group Reviewers
Frameworks
Summary

Depends on D23736

Diff Detail

Repository
R320 KIO Extras
Branch
arcpatch-D23742
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16459
Build 16477: arc lint + arc unit
meven created this revision.Thu, Sep 5, 3:51 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptThu, Sep 5, 3:51 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Thu, Sep 5, 3:51 PM
ngraham accepted this revision.Thu, Sep 5, 3:59 PM

After applying the full patchset, this works great. It's exactly what I was hoping for! 👏

This revision is now accepted and ready to land.Thu, Sep 5, 3:59 PM
meven updated this revision to Diff 65467.Thu, Sep 5, 5:58 PM

Rephrase 'Recent Folders' to 'Recent Locations'

ivan accepted this revision.Thu, Sep 5, 6:46 PM
meven updated this revision to Diff 65470.Thu, Sep 5, 6:52 PM

Add some const

meven updated this revision to Diff 65473.Thu, Sep 5, 7:02 PM

Replace /folders by /locations, add some documentation

meven updated this revision to Diff 65484.Thu, Sep 5, 8:36 PM

grammar

meven updated this revision to Diff 65492.Fri, Sep 6, 3:25 AM

Use Terms::Type::directories()

meven updated this revision to Diff 65597.Sat, Sep 7, 8:25 PM

Use new folder-open-recent for /locations

ngraham accepted this revision.Sat, Sep 7, 8:38 PM
ivan accepted this revision.Sat, Sep 7, 9:51 PM
meven added inline comments.Tue, Sep 10, 7:28 PM
recentlyused/recentlyused.cpp
98

Should we allow the filtering through type with /files path ?
I am thinking I should change that.

ngraham added inline comments.Tue, Sep 10, 7:33 PM
recentlyused/recentlyused.cpp
98

Sure, sounds like a neat bonus feature.

meven updated this revision to Diff 65959.Fri, Sep 13, 9:16 AM

Allow users to use ?type filter with /files path

meven marked 2 inline comments as done.Fri, Sep 13, 9:17 AM

I will land this soonish if no one has any objections.

Please do! It's already accepted. :)