Ok!

In D23534#524562, @davidre wrote:

I talked with Kai and we need the connection in line 341 for not plasma implementations of notifications. So best to restore it and also update the condition there.

• Revert connect and change if condition inside it

In D23534#523840, @davidre wrote:

In D23534#523826, @aprcela wrote:

In D23534#523735, @davidre wrote:

Curious that it seems to work without it. @broulik is setting the URL enough for clicking it to open the image? Is this handled by KNotification then? Also will this only work in Plasma or would the connect still be needed for when not under Plasma?

I tested only on plasma. If Spectacle is launched this way: `spectacle -b' , than it saves the image to the default location and shows the notification. The thumbnail in the notification appears after a very short time tho (less than half a sec) .

It's about opening the picture by clicking on the notification.

In D23534#523735, @davidre wrote:

Curious that it seems to work without it. @broulik is setting the URL enough for clicking it to open the image? Is this handled by KNotification then? Also will this only work in Plasma or would the connect still be needed for when not under Plasma?

In D23548#521659, @broulik wrote:

setPixmap does exactly the same thing, from Qt's source code:

void QClipboard::setPixmap(const QPixmap &pixmap, Mode mode)
{
    QMimeData *data = new QMimeData;
    data->setImageData(pixmap);
    setMimeData(data, mode);
}

and you lost the x-kde-force-image-copy hint, so I don't think this patch is neccessary.

What you can try is just not converting toImage() first because it seems Qt can do that internally/implicitly.

From qmimedata.cpp

// images and pixmaps are interchangeable
if ((type == QVariant::Pixmap && data.type() == QVariant::Image)
    || (type == QVariant::Image && data.type() == QVariant::Pixmap))
    return data;

Revert back to QMimeData. Removed toImage() sine QT converts internally

Apparently, this is slower than setImage() because:

Remove include of QMimeData

In D23534#521136, @davidre wrote:

BUG: 389694

I don't know if this fixes the bug completely. If you read the comments there are multiple ways described to cause spectacle to stay open.
Maybe rather CCBUG?

• Remove redundant check and redundant connect

Looks good, nothing to change. :)

Move connect outside of the else

In D23522#521008, @davidre wrote:

Looking at this the connect should be outside the if instead of just adding it outside the if.
When I added this in c6ad1d6ae9291685b2767ab70bdeaaadb7783658 there was no if. I think that's because of the cherry-pick in 7f30ee858368695a10ebbe628aabf0ef688f60cf?

Removed the unnecessary variables.
Tested & working.

• Remove unnecessary variables

• proper rebase. hopefully

Done , tested & working :)

• Reduce code duplication

• Reduce code duplication

• Fix git branch mashup

And still including more than it should..
Can someone help me out with this one?

Hm, looks like I borked my branches..
Now it shows the diff from the last two patches :/

• Use OR instead of AND

• Check if the file is valid

In D23210#516935, @davidre wrote:

Will look at the code later but with that I meant using the same code structure for copying to the clipboard in a follow up patch. Emitting a signal in export manager and connecting to that in the window. Just to make the control flow consistent.

Did some changes. Please check now.
Also: see the hint for doCopyToClipboard:

• Renameing and reordering

In D23210#516685, @davidre wrote:

Great! Now we also have to set the windowTitle and modification status like in KSMainWindow::imageSaved. Maybe instead of the showFeedback method we could do a imageCopiedAndSaved method inside KSMainWindow and connect that to the signal of the ExportManager. Like the imageSaved.
I think that would be cleaner. Do you agree? And after that one of us could do the same for just copying so that everything is consistent.

In D23210#516653, @davidre wrote:

Or we create an ExportManager::doSaveAndCopy method which emits a new signal which then we connect to a new KSMainWindow::showSavedAndCopiedFeedback.

• Add new AutoSave related methods.

Update it to not use enum. Don't worry, it wasn't useless. I learned more :)

• Rewrite to not use enum

In D23210#516294, @ngraham wrote:

Works great.

However, now that I see the three radio buttons, I realize that it might be nice to be able to auto-save as well as copy to clipboard, which seems to be what https://bugs.kde.org/show_bug.cgi?id=390415 is asking for. I wouldn't use it, but I guess the reporter would.

So instead of three radio buttons ("do nothing", "copy to clipboard", "auto save"), maybe we could actually simplify the UI to two checkboxes ("copy to clipboard", "auto save"), with both being unchecked implying "do nothing".

Thoughts?

In D23210#516135, @ngraham wrote:

Needs a rebase

• Resolved merge conflicts

• Merge with D23162 and update config layouts
• Rebase with D23162 and modify to use enum

In D23162#515941, @ngraham wrote:

Looks like you have some non-UNIX line endings that our commit hookscript complains about when I try to land the patch:

remote: Audit failure - Commit 10a29ef1849c50547c13adc2416a02dfb82b4378 - End of Line Style (non-Unix): src/Gui/SettingsDialog/SaveOptionsPage.cpp
remote: Push declined - commits failed audit

Can you fix it?

• Fix end of line

In D23162#515934, @davidre wrote:

To push to KDE repositories you need to have a developer account. If you don't have one I can commit for you.

In D23162#515925, @davidre wrote:

Sorry for being annoying but I had a last look :)

Do you have commit access?

• Setting variable renamed, remove commented code

I hope that's it :)

• Setting variable renamed

All done. I hope the names a re better now. Any recommendation for kde-dev best-practices?

• Rename variables, methods and enum. Remove unnecessary logic

In D23162#515855, @davidre wrote:

Last nitpicks:

• Since with your other patch this setting will control what happens after a Screenshot is taken and does not control what to copy to the clipboard, could you rename some variables accordingly?

Done. Tested & it's working.

• Move showInlineMessage() and MessageDuration to public

• Remove unnecessary check

Changed to enum and reverted the connect in L348 of SpectacleCore.cpp so spectacle -b -c works again.

• Use enum for copyToClipboard
• Revert connect to fix

Just gonna leave this here, so I don't forget about it :D

Got me into thinking:
The user sets a Shortcut and connects it to a Task.
What if, this would require quite a lot to do, we make an Task creator panel. Where a User can create his own Task and give it a name. Then, in the Schortcut settings, the user chooses which Task gets called for a specific Shortcut.
Creating a Task could include all of Spectacles functionality: After screenshot has been taken, save/edit/clipboard/... it, upload it, close Spectacle, etc.
Whereas the User sets the desired actions for a task with Checkboxes and Radiobuttons, and can have multiple tasks.
Similar to Message Filters in Thunderbird. I hope i described it well enough.

In T11418#195858, @davidre wrote:

We could already do that. But for me these are two different use cases. For my screenshots taken using shortcuts I want a good default. If I open Spectacle and use specific settings it is usually because I want them only for the screenshot I am wanting to take right now. That's also why they are instant apply - they are used to configure the screenshot right now. If I exclude the mouse pointer and window decorations for one Screenshot I wouldn't want to set them back to their old value to get the old behavior for shortcuts back.

In D23162#514946, @davidre wrote:

In general I'm fine with the approach taken here if we would just add this one setting. However we want to add at least one more button to this group. I think using an enum here and having only a single config entry would be better. Compare the printkeyactionrunning group.

Yes! Sounds way better!
Which settings should DBus mode read?

I can add a DBus-mode Settings panel in the config menu of Spectacle.
Give me a bit until I find all the possibles DBus Settings.

I hope i did the merge with D23162 correctly. This is what it would look like:

• Merge with D23162 and update config layouts

• Reorder buttons

In D23162#514296, @davidre wrote:

Good idea.
With D23210 in mind however I would probably do

After taking  screenshot:  o Do Nothing
                            o Copy to clipboard
                            o Save Image

And have the other checkbox in the Save category as you said.

In D23162#514292, @davidre wrote:

I don't think Copy file location to clipboard after saving belongs into the "After taking screenshot:" button group. It's confusing that it specifies two different points in time.

Since I was a long time user of ShareX (until I abandoned Windows), there's a lot I'm planning to add to spectacle :)
This will be on my list of next things to do.
Maybe discuss this further on bugs.kde.org ?

In D23212#513604, @ngraham wrote:

result: Git Stashes is visually grouped with Branches... and is not clickable

What you're objecting do is actually just the way menu section headers look in the Breeze widget style. I agree that it causes confusion and visual problems, but it should be fixed there, not here in KDevelop.

Here's the applicable Breeze code that draws these headers https://cgit.kde.org/breeze.git/tree/kstyle/breezestyle.cpp#n4741

Would you like to have a go at improving it there?

• Indicate that it quits only after user's copy/save interaction

Has merge conflicts if D23162 gets approved.