[kdevelop] Remove 'Git Stashes' text above separator
AbandonedPublic

Authored by aprcela on Aug 17 2019, 10:28 AM.

Details

Reviewers
None
Group Reviewers
VDG
KDevelop
Summary

Remove Git Stashes above the separator. Since it is visually grouped with Branches... but does not belong in the same group. Also, it's not clickable.
Rename Stash Manager to Git Stash Manager

Test Plan
  1. Right click in a project.
  2. Choose Git

expected: functionality for stashes should be in the same group, everything should be clickable
result: Git Stashes is visually grouped with Branches... and is not clickable

Old:

New:

Diff Detail

Repository
R32 KDevelop
Branch
git_context_menu_stashes (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15210
Build 15228: arc lint + arc unit
aprcela created this revision.Aug 17 2019, 10:28 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 17 2019, 10:28 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
aprcela requested review of this revision.Aug 17 2019, 10:28 AM
aprcela edited the test plan for this revision. (Show Details)Aug 17 2019, 10:29 AM
aprcela retitled this revision from Remove 'Git Stashes' text above separator to [kdevelop] Remove 'Git Stashes' text above separator.Aug 17 2019, 10:32 AM

result: Git Stashes is visually grouped with Branches... and is not clickable

What you're objecting do is actually just the way menu section headers look in the Breeze widget style. I agree that it causes confusion and visual problems, but it should be fixed there, not here in KDevelop.

Here's the applicable Breeze code that draws these headers https://cgit.kde.org/breeze.git/tree/kstyle/breezestyle.cpp#n4741

Would you like to have a go at improving it there?

result: Git Stashes is visually grouped with Branches... and is not clickable

What you're objecting do is actually just the way menu section headers look in the Breeze widget style. I agree that it causes confusion and visual problems, but it should be fixed there, not here in KDevelop.

Here's the applicable Breeze code that draws these headers https://cgit.kde.org/breeze.git/tree/kstyle/breezestyle.cpp#n4741

Would you like to have a go at improving it there?

oh, didn't knew about that. Will take a look over there at breeze :)

Great! You can Abandon this revision from the Add Action... menu above the comment field if you'd like (you can always re-open it later if need be).

aprcela abandoned this revision.Sun, Aug 18, 10:08 AM