| mart | |
| ngraham |
This creates a new component that uses the widgets/toparea svg. First time I try to add something to PlasmaComponents, so I probably got stuff wrong and I probably have to still do thing like adding documentation. I'm creating the diff to get feedback on how to move forward with this.
Depends on D27444
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/declarativeimports/plasmacomponents3/TopArea.qml | ||
|---|---|---|
| 40 ↗ | (On Diff #76531) | This conditional is wrong. The syntax is condition ? true_case : false_case so you want to write flipped ? -topAreaSvg.margins.top : -topAreaSvg.margins.bottom or something similar. |
| src/declarativeimports/plasmacomponents3/TopArea.qml | ||
|---|---|---|
| 40 ↗ | (On Diff #76531) | Dumb me. I'm used to python. |
PC3 is designed to be only a theme for QQC2
For new API this is the wrong place.
| src/declarativeimports/plasmaextracomponents/qml/TopArea.qml | ||
|---|---|---|
| 44 ↗ | (On Diff #76860) | test? |
I would call the component PlasmoidHeading, to make clear it's only for use in plasmoids
| src/declarativeimports/plasmaextracomponents/qml/TopArea.qml | ||
|---|---|---|
| 28 ↗ | (On Diff #76860) | enum Location { Header, Footer (maybe a middle as well?) } property Location location |
| 30 ↗ | (On Diff #76860) | shouldn't assume it's in a layout.. |
| 37 ↗ | (On Diff #76860) | topAreaSvg.fixedMargins so works also when you disable them |
| 43 ↗ | (On Diff #76860) | you can check for headers: same thing for footers, disabling bottom edge when |
| 44 ↗ | (On Diff #76860) | "plasmoidheading" svg name |
| 45 ↗ | (On Diff #76860) | prefixes as "header" and "footer" |
Two questions:
| src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml | ||
|---|---|---|
| 53 | this can be an int | |
Watch your whitespace. This new file is full of cases where there are spaces on on blank lines or trailing spaces. git show HEAD will show you for the latest commit:
Also it's a good habit to run git diff one last time before committing or submitting the patch to make sure little things like these are resolved early.
Also the patch title is now inaccurate. :)
You need to add it to the file src/declarativeimports/plasmaextracomponents/qml/qmldir or else it doesn't get installed in a way that anything can see it.