Dialog: disconnect from QWindow signals in destructor

Authored by dvratil on Feb 26 2020, 9:00 AM.

Description

Dialog: disconnect from QWindow signals in destructor

Summary:
When Dialog is being destroyed, its QWindow super-class may still emit
some signals from its destructor. Dialog is connected so some of them,
so this leads to Qt invoking slots on Dialog, whose destructor has
already been called, leading to crashes.

This patch disconnects all internal connections in Dialog's destructor.

See https://phabricator.kde.org/D23339 for details.

Test Plan: Plasma no longer crashes when a notification appears

Reviewers: Plasma, nicolasfella, davidedmundson

Reviewed By: Plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D27671

Details

Committed
dvratilFeb 26 2020, 9:00 AM
Reviewer
Plasma
Differential Revision
D27671: Dialog: disconnect from QWindow signals in destructor
Parents
R242:10c112fccda8: [PlasmaComponents]Clean up ListItem code
Branches
Unknown
Tags
Unknown