[dolphin] Improve parsing of Baloo query searchString
Needs ReviewPublic

Authored by iasensio on Sat, Oct 5, 1:21 PM.

Details

Reviewers
elvisangelaccio
meven
bruns
Group Reviewers
Dolphin
Summary

The searchbox panel updates its state on URL changes by parsing a search URL.
For baloo queries (baloosearch:/) current parsing produces some quirks, such as showing the baloo terms on the user searchbar:

This patch improves the parsing of Baloo query searchString to represent its parameters properly in the search box.

Other related issues has been splitted to the following revisions:

  • Add missing parsing of type 'Folder' D24448
  • Do not toggle 'From Here'/'All Files' on reloads D24449
  • Reset search options to default when needed D24450
  • File type is not updated for places' default search URLs (e.g. baloosearch://videos) D24433
  • When selecting 'All Files' we lose track of which folder the user was previously on. D24577
Test Plan
  • Use and stress the search options in dolphin
  • Save some search queries to places panel
  • Commute between saved queries and usual folders (indexed and not indexed) and perform further searches on them

Diff Detail

Repository
R318 Dolphin
Branch
search_parse_frombaloo
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17370
Build 17388: arc lint + arc unit
iasensio created this revision.Sat, Oct 5, 1:21 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSat, Oct 5, 1:21 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Sat, Oct 5, 1:21 PM
iasensio edited the summary of this revision. (Show Details)Sat, Oct 5, 11:28 PM
iasensio updated this revision to Diff 67390.Sun, Oct 6, 5:20 PM
  • Add parsing for filename/content
bruns requested changes to this revision.Sun, Oct 6, 6:48 PM
bruns added a subscriber: bruns.

Please do one change at a time.

This revision now requires changes to proceed.Sun, Oct 6, 6:48 PM

Please do one change at a time.

Sure thing, it was meant as a whole "polish" of the search URL update, but it ended up with a lot of minor details.
As they are kind of related, if you don't mind I will keep this revision as the main one with only the biggest change and link from here to the minor splitted ones.

iasensio updated this revision to Diff 67395.Sun, Oct 6, 10:24 PM
  • Clean patch into several revisions
iasensio edited the summary of this revision. (Show Details)Sun, Oct 6, 10:52 PM
iasensio edited the test plan for this revision. (Show Details)
iasensio edited the summary of this revision. (Show Details)Sat, Oct 12, 12:38 AM