Differential D24449

[dolphin/search] Avoid unnecesary reloads on setSearchPath
ClosedPublic
Actions

Authored by iasensio on Oct 6 2019, 10:06 PM.

Details

Reviewers
elvisangelaccio
meven
ngraham
Group Reviewers
Dolphin
Commits
R318:e30357343bda: [dolphin/search] Avoid unnecesary reloads on setSearchPath
Summary

Check in setSearchPath() if the url passed is already the searchPath
This was causing an effect where reloading the same search URL results on buttons From Here/Everywhere toggling.
See D24422

Test Plan

On your home folder press Ctrl-F several times
Buttons From Here/Everywhere should now not toggle each time

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.Oct 6 2019, 10:06 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 6 2019, 10:06 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Oct 6 2019, 10:06 PM
ngraham accepted this revision.Oct 6 2019, 11:55 PM
This revision is now accepted and ready to land.Oct 6 2019, 11:55 PM
elvisangelaccio accepted this revision.Oct 7 2019, 7:51 PM
Closed by commit R318:e30357343bda: [dolphin/search] Avoid unnecesary reloads on setSearchPath (authored by iasensio, committed by elvisangelaccio). · Explain WhyOct 7 2019, 7:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/search/dolphinsearchbox.cpp (4 lines)

Diff 67455

View Options

src/search/dolphinsearchbox.cpp

Loading...