fix(search): Allow to set empty type
ClosedPublic

Authored by iasensio on Mon, Nov 11, 12:36 PM.

Details

Summary

This small patch allows to set and empty type to the extended options, which will set the Any Type option (index 0).
It doesn't make any change in current code, since this case is not called, but it helps simplifying follow-up patches.

Test Plan

No behavior changes with current code.
Calling setFacetsType(QString()) actually sets the first option (Any Type)

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.Mon, Nov 11, 12:36 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMon, Nov 11, 12:36 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Mon, Nov 11, 12:36 PM
elvisangelaccio accepted this revision.Wed, Nov 13, 8:48 PM
This revision is now accepted and ready to land.Wed, Nov 13, 8:48 PM

Should I push this also to release/19.12?

Sure ;)

To elaborate, in general we can push to the stable branch (release/19.12 currently) as long as we don't introduce new strings or new features and until the branch gets "frozen" for the final release tagging (5th december this time: https://community.kde.org/Schedules/Applications/19.12_Release_Schedule).

Big refactoring commits should still go to master though.

This revision was automatically updated to reflect the committed changes.