Searchbar options (text and options) were only updated when toggling the search on, $
Main use case is when changing between stored search urls in Places panel.
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:43ea7052e15b: Merge branch 'Applications/19.08'
R318:b3120cb90e3d: Update searchbar parameters on URL change
- Store two search urls in Places panel
- Navigate between them
- The searchbar text and parameters change accordingly
BEFORE:
AFTER:
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
LGTM
src/dolphinviewcontainer.cpp | ||
---|---|---|
674–678 | Coding style: we never use _ as prefix for variable names. I'd call this variable just searchUrl. |
src/dolphinviewcontainer.cpp | ||
---|---|---|
674–678 | Sure thing, thanks! I couldn't come with a proper name. |
Comment Actions
I've found a bug I introduced within this patch. The fix is in D24376.
I'm really sorry for not having tested it more thoroughly.