[dolphin] Update searchbar parameters on URL change
ClosedPublic

Authored by iasensio on Oct 2 2019, 7:44 PM.

Details

Summary

Searchbar options (text and options) were only updated when toggling the search on, $
Main use case is when changing between stored search urls in Places panel.

Test Plan
  • Store two search urls in Places panel
  • Navigate between them
  • The searchbar text and parameters change accordingly

BEFORE:


AFTER:

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.Oct 2 2019, 7:44 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 2 2019, 7:44 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Oct 2 2019, 7:44 PM
iasensio edited the test plan for this revision. (Show Details)Oct 2 2019, 7:46 PM

LGTM

src/dolphinviewcontainer.cpp
674–678

Coding style: we never use _ as prefix for variable names. I'd call this variable just searchUrl.

iasensio updated this revision to Diff 67224.Oct 2 2019, 8:51 PM
iasensio marked an inline comment as done.
  • Improve coding style
iasensio added inline comments.Oct 2 2019, 8:51 PM
src/dolphinviewcontainer.cpp
674–678

Sure thing, thanks! I couldn't come with a proper name.

elvisangelaccio accepted this revision.Oct 2 2019, 9:02 PM

I'll push to 19.08, thanks for the patch!

This revision is now accepted and ready to land.Oct 2 2019, 9:02 PM
This revision was automatically updated to reflect the committed changes.
iasensio marked an inline comment as done.Oct 2 2019, 11:39 PM

I've found a bug I introduced within this patch. The fix is in D24376.
I'm really sorry for not having tested it more thoroughly.