Differential D26944

Added smallSpacing to leftMargin
AbandonedPublic
Actions

Authored by niccolove on Jan 27 2020, 3:20 PM.

Details

Reviewers
kdeconnect
Group Reviewers
VDG
Summary

With other the two patches, this aims to make leftMargin consistent on plasmoids.
See: https://phabricator.kde.org/D26945 and https://phabricator.kde.org/D26946

Test Plan

Before:


After:

Diff Detail

Repository
R224 KDE Connect
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 21705
Build 21723: arc lint + arc unit
niccolove created this revision.Jan 27 2020, 3:20 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJan 27 2020, 3:20 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
niccolove requested review of this revision.Jan 27 2020, 3:20 PM
apol added a subscriber: apol.Jan 27 2020, 3:29 PM

Maybe you can provide before/after screenshots to understand what you're fixing?

niccolove added a comment.Jan 27 2020, 3:32 PM

Yes, I'm just finishing submitting the last patch and then I'll add screenshots for all of them :-)

niccolove edited the summary of this revision. (Show Details)Jan 27 2020, 3:36 PM
niccolove edited the test plan for this revision. (Show Details)Jan 27 2020, 3:38 PM
ngraham mentioned this in D21813: RFC: Consider adding more padding to the desktop theme.Jan 27 2020, 5:28 PM
ngraham added a subscriber: ngraham.

Hmm, it almost seems like the header in the popup is over too far to the right, and we should fix that (and maybe increase the default margins in the theme: D21813) rather than adding extra margins in every plasmoid.

niccolove abandoned this revision.Feb 3 2020, 9:21 AM
niccolove added a comment.Feb 19 2020, 8:16 PM

Did this message get centered on another patch, or is it still on the left?

gvgeo added a subscriber: gvgeo.Feb 19 2020, 8:54 PM
In D26944#614407, @niccolove wrote:

Did this message get centered on another patch, or is it still on the left?

I don't believe so.
https://phabricator.kde.org/source/kdeconnect-kde/history/master/plasmoid/package/contents/ui/

Can you make this like D27219?

Revision Contents
Changeset List

Diff 74437

View Options

plasmoid/package/contents/ui/FullRepresentation.qml

Loading...