BUG: 189482
FIXED-IN: 5.67
Depends on D17595
meven |
Frameworks | |
Dolphin |
BUG: 189482
FIXED-IN: 5.67
Depends on D17595
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Not sure about binary compatibility, since this is an exported class / public API.
src/filewidgets/kdiroperator.h | ||
---|---|---|
802 | Adding a virtual function changes the vtable, so this is BIC (binary incompatible). Does the function need to be virtual? |
Before the feature was removed, the window had all file operations, incl. move to trash and IIRC even the ability to cut/copy/paste and move (via D'n'D) files.
src/filewidgets/kdiroperator.cpp | ||
---|---|---|
884–886 | I think we should just use dialog->open() here. I see you've copied these 3 lines from Dolphin, but we should also fix it there (the rename dialog should really be modal). |
Move to Trash is already there. Cut/Copy/Paste shouldn't be too hard to add--in another patch of course. :)
src/filewidgets/kdiroperator.cpp | ||
---|---|---|
884–886 | Does dialog->open() block? If so, do we have to new the dialog at all? (Only reason I can think of is some DBus crash, see https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0 but that would require a better fix). |
src/filewidgets/kdiroperator.cpp | ||
---|---|---|
884–886 | Nope, dialog->open() does not block. |
That's currently an option in Dolphin. Maybe we should just read that setting to see if we should do it here too?
Either way I'd prefer to do that in a separate patch.
What is the status of this patch? It missed the 5.54 deadline, so the version would need to be adjusted.
Sorry, I lost track of this after large changes were requested for the dependent patch D17595. I'll try to get this in for 5.55.
src/filewidgets/kdiroperator.h | ||
---|---|---|
800 | Update to @since 5.67 |