Diffusion KIO 3f5341d3d7e2

Upstream Dolphin's file rename dialog

Authored by meven on Jan 6 2020, 1:01 PM.

Description

Upstream Dolphin's file rename dialog

Summary:
KIO didn't actually have its own rename dialog, which is necessary to implement the requested rename-from-the-file-dialog feature (189482). This patch upstreams Dolphin's dialog so all KIO::FileWidgets users can use it.

The file's contents are copied from Dolphin and updated, but the name is changed from RenameDialog to RenameFileDialog because RenameDialog already exists in KIO (and is actually an overwrite dialog, but we can't rename it until KF6).

CCBUG: 189482

Test Plan:
Apply D17596 or D17597 and initiate a rename operation for one or more files. See that it works as expected.

Tests still pass.

Reviewers: Frameworks, Dolphin, broulik, ngraham, dfaure, elvisangelaccio

Reviewed By: Dolphin, ngraham, dfaure, elvisangelaccio

Subscribers: elvisangelaccio, lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D17595

Details

Committed
mevenJan 6 2020, 7:40 PM
Reviewer
Dolphin
Differential Revision
D17595: Upstream Dolphin's file rename dialog
Parents
R241:bdc2df9c1735: KFilePlaceEditDialog: move logic into isIconEditable()
Branches
Unknown
Tags
Unknown