Use newly-upstreamed rename dialog from KIO
Needs ReviewPublic

Authored by ngraham on Dec 15 2018, 5:05 AM.

Details

Reviewers
None
Group Reviewers
Dolphin
Summary

With the rename dialog upstreamed in D17595, we can use it from there.

This will require the KF5 dep to be bumped to 5.54, which should be feasible given that we're at the very beginning of a new Applications cycle.

Depends on D17595

Test Plan
  1. Dolphin Settings > uncheck "rename inline"
  2. Rename one or more files. Observe that it still works

Tests still pass.

Diff Detail

Repository
R318 Dolphin
Branch
use-upstream-rename-dialog-from-kio (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6044
Build 6062: arc lint + arc unit
ngraham created this revision.Dec 15 2018, 5:05 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 15 2018, 5:05 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 15 2018, 5:05 AM

looks good

src/panels/folders/folderspanel.cpp
107

Could also do KFileItemList{item}

src/views/dolphinview.cpp
639

Why not keep the new connect syntax?