ElisaProject
ActivePublic

Recent Activity

Sun, Aug 18

ngraham accepted D23240: Resolve symlink for file listener.

Oh so nice. Confirmed fixed!

Sun, Aug 18, 9:42 PM · Elisa
ngraham accepted D23239: Cleanup main content view.
Sun, Aug 18, 9:40 PM · Elisa
mgallien added a comment to D22770: Rework shuffle handling.

I am unable to get arc to properly download this review patch. I will be waiting for D22769 to land and a rebase. Sorry

Sun, Aug 18, 8:20 PM · Elisa
mgallien accepted D22769: Make MediaPlayList responsible for remaining tracks.

OK, thanks

Sun, Aug 18, 7:46 PM · Elisa
astippich updated the summary of D23240: Resolve symlink for file listener.
Sun, Aug 18, 6:54 PM · Elisa
astippich requested review of D23240: Resolve symlink for file listener.
Sun, Aug 18, 10:21 AM · Elisa
astippich requested review of D23239: Cleanup main content view.
Sun, Aug 18, 9:42 AM · Elisa
astippich closed D23223: Remove all remnants of outdated notification system.
Sun, Aug 18, 9:20 AM · Elisa
astippich updated the summary of D23223: Remove all remnants of outdated notification system.
Sun, Aug 18, 9:19 AM · Elisa
ngraham accepted D23223: Remove all remnants of outdated notification system.
Sun, Aug 18, 1:14 AM · Elisa

Sat, Aug 17

mgallien accepted D23223: Remove all remnants of outdated notification system.

Let's go. I have not enough time for a proper review but a big +1

Sat, Aug 17, 4:40 PM · Elisa
astippich requested review of D23223: Remove all remnants of outdated notification system.
Sat, Aug 17, 3:57 PM · Elisa
astippich closed D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.
Sat, Aug 17, 1:42 PM · Elisa
astippich accepted D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.

Great, thanks again

Sat, Aug 17, 1:41 PM · Elisa
mykolak added a comment to D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.

Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?

Sat, Aug 17, 12:45 PM · Elisa
astippich updated the diff for D22772: Rework the mediaplayercontrol.
  • rebase
Sat, Aug 17, 9:51 AM · Elisa
astippich updated the diff for D22771: Add previous and next tracks to mediaplaylist.
  • rebase
Sat, Aug 17, 9:50 AM · Elisa
astippich added a comment to D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.

Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?

Sat, Aug 17, 9:33 AM · Elisa
astippich closed T7570: Investigate bugs where busy indicator spins forever as Resolved.

If you would like to start contributing, you may have a look at the Junior Jobs column of the tasks or try to fix some bugs at https://bugs.kde.org/buglist.cgi?component=general&list_id=1655384&product=elisa&resolution=---

Sat, Aug 17, 9:20 AM · Elisa
sayakbiswas added a comment to T7570: Investigate bugs where busy indicator spins forever.

Okay thanks. No, I haven't faced these issues.

Sat, Aug 17, 4:24 AM · Elisa

Fri, Aug 16

mykolak updated the summary of D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.
Fri, Aug 16, 4:46 PM · Elisa
mykolak requested review of D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.
Fri, Aug 16, 4:43 PM · Elisa

Thu, Aug 15

mgallien added a comment to T7570: Investigate bugs where busy indicator spins forever.

Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?

Thu, Aug 15, 7:24 PM · Elisa
astippich added a comment to T7570: Investigate bugs where busy indicator spins forever.

Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?

Thu, Aug 15, 6:46 PM · Elisa
astippich updated the diff for D22770: Rework shuffle handling.
  • rebase
Thu, Aug 15, 6:44 PM · Elisa
astippich updated the diff for D22769: Make MediaPlayList responsible for remaining tracks.
  • rebase on master
Thu, Aug 15, 6:43 PM · Elisa
mykolak added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Is that a regression? Since I cannot test this, are you able to provide a fix? The issue may be located at
https://phabricator.kde.org/source/elisa/browse/master/src/qml/GridBrowserView.qml$127

Thu, Aug 15, 11:32 AM · Elisa
sayakbiswas added a comment to T7570: Investigate bugs where busy indicator spins forever.

Is anyone working on this? If not I'd like to help out with this.

Thu, Aug 15, 6:13 AM · Elisa

Wed, Aug 14

mykolak added a comment to D23132: Use Qt's highDPI scaling.

If you're adjusting the DPI using the Force Fonts DPI spinbox, you're doing something unsupported. This patch is for people who are (correctly) using the scaling slider on the KScreen KCM (i.e. the displays page in System Settings).

Wed, Aug 14, 8:01 PM · Elisa
astippich closed T7530: High DPI support as Resolved by committing R255:3710916442cb: Use Qt's highDPI scaling.
Wed, Aug 14, 6:28 PM · Elisa
astippich closed D23132: Use Qt's highDPI scaling.
Wed, Aug 14, 6:28 PM · Elisa
ngraham added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Wed, Aug 14, 4:17 PM · Elisa
astippich added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Wed, Aug 14, 4:04 PM · Elisa
mykolak added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Wed, Aug 14, 2:22 PM · Elisa
mgallien accepted D23132: Use Qt's highDPI scaling.

Really nice. Thank you

Wed, Aug 14, 7:12 AM · Elisa

Tue, Aug 13

ngraham accepted D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 8:49 PM · Elisa
ngraham updated the summary of D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 8:49 PM · Elisa
astippich updated the diff for D22769: Make MediaPlayList responsible for remaining tracks.
  • fix code style again
Tue, Aug 13, 6:59 PM · Elisa
astippich moved T7530: High DPI support from Backlog to In Progress on the Elisa board.
Tue, Aug 13, 6:57 PM · Elisa
astippich closed D21943: Port the application menu to qqc2.
Tue, Aug 13, 6:55 PM · Elisa
astippich updated the diff for D22769: Make MediaPlayList responsible for remaining tracks.
  • fix code style and unrelated changes
  • fix remaining tracks label
Tue, Aug 13, 6:47 PM · Elisa
astippich added a comment to D22769: Make MediaPlayList responsible for remaining tracks.

I don't want to remove ManageHeaderBar, on the contrary. This is a simplification and cleanup in order to easily extend it in the future after D22771, which is the goal of this whole series.
While working on it, I found that the ManageHeaderBar is needlessly entangled to the MediaPlayList by connecting to all of those signals, but which are mostly ignored. This is just because of the remaining tracks, for which the MediaPlayList is the correct place to retrieve the information.
By only connecting to the currentTrackChanged signal, the rest can be implemented much more easily. D22771 is working towards T7674

Tue, Aug 13, 6:41 PM · Elisa
astippich added a task to D23132: Use Qt's highDPI scaling: T7530: High DPI support.
Tue, Aug 13, 6:41 PM · Elisa
astippich added a revision to T7530: High DPI support: D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 6:41 PM · Elisa
astippich closed T7576: port to controls2 as Resolved.
Tue, Aug 13, 6:38 PM · Elisa
astippich added a comment to D23132: Use Qt's highDPI scaling.

Please note that I cannot test this myself due to lack of a high DPI monitor

Tue, Aug 13, 6:37 PM · Elisa
astippich requested review of D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 6:37 PM · Elisa
mgallien added a comment to D22769: Make MediaPlayList responsible for remaining tracks.

I forgot to say that the very big reduction in line count is really good. Thanks for that

Tue, Aug 13, 5:45 AM · Elisa
mgallien added a comment to D22769: Make MediaPlayList responsible for remaining tracks.

Could you please add a general overview of what is the goal of this change ?

Tue, Aug 13, 5:24 AM · Elisa

Thu, Aug 8

astippich added a comment to D22772: Rework the mediaplayercontrol.

Thanks. Just wanted to make sure that it does not fall through

Thu, Aug 8, 10:14 AM · Elisa