ElisaProject
ActivePublic

Recent Activity

Yesterday

mgallien accepted D21806: Use existing settings storage for shuffle and repeat.

Thanks

Sat, Jun 15, 9:57 PM · Elisa
fbampaloukas added a watcher for Elisa: fbampaloukas.
Sat, Jun 15, 9:00 PM

Fri, Jun 14

mgallien added a comment to D21806: Use existing settings storage for shuffle and repeat.

I am looking at it.

Fri, Jun 14, 9:09 PM · Elisa
mgallien added a project to D21806: Use existing settings storage for shuffle and repeat: Elisa.
Fri, Jun 14, 9:09 PM · Elisa

Tue, Jun 11

mnesbitt added a watcher for Elisa: mnesbitt.
Tue, Jun 11, 6:09 PM

Mon, Jun 10

mgallien moved T11063: Factor List Views from Backlog to In Progress on the Elisa board.
Mon, Jun 10, 9:31 PM · Elisa
mgallien created T11063: Factor List Views.
Mon, Jun 10, 9:31 PM · Elisa

Wed, Jun 5

mgallien moved T7567: Add support for radio streams from Backlog to In Progress on the Elisa board.
Wed, Jun 5, 3:51 PM · Elisa
mgallien closed T10847: Fix genre, composer and lyricist database insertion as Resolved.
Wed, Jun 5, 3:51 PM · Elisa
mgallien closed T10848: Fix layouts in RTL mode (Right to left) as Resolved.
Wed, Jun 5, 3:50 PM · Elisa

Tue, Jun 4

mgallien closed D21081: fix focus rectangle not visible in single album view mode.
Tue, Jun 4, 5:11 AM · Elisa
ngraham accepted D21081: fix focus rectangle not visible in single album view mode.

Perfect!!!! The code looks good and the behavior is now excellent. I can clearly see what has focus and navigating the whole app with the keyboard is a breeze. It looks great too. I'm not totally sold on having all the backgrounds animate their opacity and color (we just got rid of that in QML comboboxes in fact), and it feels like something that should be in the style rather than hardcoded in the app. However that's a really minor aesthetic jusgment call and we can think about it later (or not). Huge +1 for landing this. Great work!

Tue, Jun 4, 1:39 AM · Elisa

Mon, Jun 3

mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.
  • emulate focus beahvior of list view as shown in feedback
  • fix views displaying tracks to have the same focus logic than playlist
  • fix keyboard focus issues whith NavigationActionBar and tab navigation
  • fix focus issues in ListView of single tracks
  • fix qml warning in FrequentlyPlayedTracks and RecentlyPlayedTracks views
  • fix small differences between list based views
  • Elisa sidebar with colored backgrounds
  • improve focus handling of view selector list
  • solve some keyboard focus issues
  • fix tab focus handling in some list views (playlist and album view)
  • for consistency, put the same behavior for generic grid views
  • add mostly the same focus behavior to file browser
Mon, Jun 3, 9:30 PM · Elisa

Sat, Jun 1

jguidon added a revision to T7567: Add support for radio streams: D21525: Add support for radio streams.
Sat, Jun 1, 5:51 PM · Elisa

Fri, May 31

mgallien added a comment to D21081: fix focus rectangle not visible in single album view mode.

I think the leftmost sidebar list items with text and icons are just fine; no need for a fundamental change there. :) All I think needs to happen is that the selected list item should be indicated by giving it a blue or gray background like all other list items have, rather than changing its text color or drawing a frame around it.

Here's a patch for this patch that more or less does what I have in mind:

1diff --git a/src/qml/ViewSelector.qml b/src/qml/ViewSelector.qml
2diff --git a/src/qml/ViewSelector.qml b/src/qml/ViewSelector.qml
3index c391a34..a8f9a8c 100644
4--- a/src/qml/ViewSelector.qml
5+++ b/src/qml/ViewSelector.qml
6@@ -91,19 +91,18 @@ FocusScope {
7
8 Rectangle {
9
10- border {
11- color: ((viewModeView.currentIndex === index && rootFocusScope.activeFocus) ? myPalette.highlight : "transparent")
12- width: 1
13- }
14-
15- Behavior on border.color {
16- ColorAnimation {
17- duration: 300
18+ color: if (viewModeView.currentIndex === index) {
19+ if (rootFocusScope.activeFocus) {
20+ return myPalette.highlight
21+ } else {
22+ return myPalette.mid
23 }
24+ } else if (itemMouseArea.containsMouse) {
25+ return Qt.rgba(myPalette.highlight.r, myPalette.highlight.g, myPalette.highlight.b, 0.2)
26+ } else {
27+ return "transparent"
28 }
29
30- radius: 3
31-
32 anchors.fill: parent
33
34 Loader {
35@@ -197,14 +196,6 @@ FocusScope {
36 duration: 150
37 }
38 }
39-
40- color: (viewModeView.currentIndex === index || itemMouseArea.containsMouse ? myPalette.highlight : myPalette.text)
41-
42- Behavior on color {
43- ColorAnimation {
44- duration: 300
45- }
46- }
47 }
48 }

Fri, May 31, 12:31 PM · Elisa

Thu, May 30

ngraham added a comment to D21081: fix focus rectangle not visible in single album view mode.

I think the leftmost sidebar list items with text and icons are just fine; no need for a fundamental change there. :) All I think needs to happen is that the selected list item should be indicated by giving it a blue or gray background like all other list items have, rather than changing its text color or drawing a frame around it.

Thu, May 30, 8:36 PM · Elisa

Wed, May 29

ngraham added a comment to D21081: fix focus rectangle not visible in single album view mode.

Humongous improvement so far! One thing that sticks out is that the left-most sidebar list still needs the new style for selected categories so that it matches other list-style items:

Thanks for your review.
When I saw it, I was already working on the left most sidebar. I am hesitant to keep the current design with only the text and icon used to indicate state of an entry. I find it simpler but still easy to use. At the same time, it could break consistency (even though it is not music content but application UI state).

Wed, May 29, 9:57 PM · Elisa
mgallien added a comment to D21081: fix focus rectangle not visible in single album view mode.

Humongous improvement so far! One thing that sticks out is that the left-most sidebar list still needs the new style for selected categories so that it matches other list-style items:

Wed, May 29, 8:10 PM · Elisa
ngraham added a comment to D21081: fix focus rectangle not visible in single album view mode.

Humongous improvement so far! One thing that sticks out is that the left-most sidebar list still needs the new style for selected categories so that it matches other list-style items:

Wed, May 29, 4:47 PM · Elisa
asn added a comment to T7567: Add support for radio streams.

@jguidon any news on this?

Wed, May 29, 5:47 AM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.
  • emulate focus beahvior of list view as shown in feedback
  • fix views displaying tracks to have the same focus logic than playlist
  • fix keyboard focus issues whith NavigationActionBar and tab navigation
  • fix focus issues in ListView of single tracks
  • fix qml warning in FrequentlyPlayedTracks and RecentlyPlayedTracks views
  • fix small differences between list based views
Wed, May 29, 5:33 AM · Elisa

Fri, May 17

ngraham added a comment to D21081: fix focus rectangle not visible in single album view mode.

This is functionally much better! Now I can tell where the keyboard focus is. Visually I think it's a small improvement but we can do even better for the list and grid items and also be more consistent with how other apps generally handle this.

Fri, May 17, 10:00 PM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.
  • use a rectangle around the current item with focus in view selector
  • use rectangle borders to show the active focus in most elements
Fri, May 17, 6:42 PM · Elisa

May 13 2019

ngraham added a member for Elisa: ngraham.
May 13 2019, 9:33 PM
ngraham removed a watcher for Elisa: ngraham.
May 13 2019, 9:33 PM
mgallien closed D21039: avoid sending wrong or empty metadata to mpris2 interface.
May 13 2019, 8:11 PM · Elisa
ngraham accepted D21039: avoid sending wrong or empty metadata to mpris2 interface.

Works for me, thanks.

May 13 2019, 6:01 PM · Elisa

May 12 2019

mgallien added a comment to D21039: avoid sending wrong or empty metadata to mpris2 interface.

Ping.
I would like if possible to get this in before end of next week to have in the 0.4.0 release.

May 12 2019, 8:07 PM · Elisa

May 8 2019

ngraham added a comment to D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Looks good now! BTW it's unrelated to this patch, but I notice that song length display in the playlist has regressed in the last day or two:

May 8 2019, 3:36 PM · Elisa
mgallien added a comment to D21081: fix focus rectangle not visible in single album view mode.

This works, but to be honest I really dislike this focus rectangle in every view where it appears in Elisa. I don't think it matches Elisa's visual style at all. See how the blue rectangle touches the vertical line on the left, but it's a few pixels away from the line on the right? And it also isn't actually framing anything since Elisa's views don't use gray frames. So it appears "out of the blue", so to speak.

I feel like a cleaner focus indication style for a modern app like Elisa is to highlight the particular control or list itemthat currently has focus, rather than drawing a colored frame around an entire view. For example in your screenshots, instead of drawing a blue frame to indicate that the view has focus, I would make the song highlight blue rather than gray. This actually communicates more information: not only does it tell you that the view has focus, but you also clearly see which exact element within the view has focus.

May 8 2019, 2:41 PM · Elisa
mgallien closed D21080: fix some layouts to look correct when reversed (typical for RTL locale).
May 8 2019, 2:33 PM · Elisa
ngraham accepted D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Looks good now! BTW it's unrelated to this patch, but I notice that song length display in the playlist has regressed in the last day or two:

May 8 2019, 2:17 PM · Elisa
safaalfulaij accepted D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Can't test, but seems fine.
Thanks for informing! :)

May 8 2019, 2:12 PM · Elisa
mgallien closed D21043: do not extend mouse areas in header bar longer than the text.
May 8 2019, 2:12 PM · Elisa
ngraham added a comment to D21081: fix focus rectangle not visible in single album view mode.

This works, but to be honest I really dislike this focus rectangle in every view where it appears in Elisa. I don't think it matches Elisa's visual style at all. See how the blue rectangle touches the vertical line on the left, but it's a few pixels away from the line on the right? And it also isn't actually framing anything since Elisa's views don't use gray frames. So it appears "out of the blue", so to speak.

May 8 2019, 2:11 PM · Elisa
ngraham accepted D21043: do not extend mouse areas in header bar longer than the text.

This looks much better, thanks. It makes sense that font.pointSize should be rounded to an integer value.

May 8 2019, 1:58 PM · Elisa
mgallien retitled D21081: fix focus rectangle not visible in single album view mode from GIT_SILENT made messages (after extraction) to fix focus rectangle not visible in single album view mode.
May 8 2019, 1:29 PM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.

try to include only the correct commit

May 8 2019, 1:28 PM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.

an extra commit from 0.4 is included

May 8 2019, 1:27 PM · Elisa
mgallien added a project to D21081: fix focus rectangle not visible in single album view mode: Elisa.
May 8 2019, 1:26 PM · Elisa
mgallien added a comment to D21043: do not extend mouse areas in header bar longer than the text.

This now works!

However I'm left to wonder why all this rigamarole with TextMetrics is even necessary at all. I notice that if I remove all the TextMetrics components, and let the labels auto-size themselves by removing Layout.fillWidth and Layout.maximumWidth, everything works fine except for the artist label, which gets elided. But I notice that it only gets elided when the point size is set to elisaTheme.defaultFontPointSize * 1.5. If I change the multiplier to 1, 1.4 or 2, it works. However a multiplier of 1.5, 1.75, or any other odd value triggers the bug. This is reproducible for all fonts and sizes that I tried.

I don't understand this bug, but a less invasive workaround might be simply to change the multiplier a bit rather than do all this stuff with TextMetrics.

May 8 2019, 12:47 PM · Elisa
mgallien added a project to D21080: fix some layouts to look correct when reversed (typical for RTL locale): Elisa.
May 8 2019, 12:46 PM · Elisa
mgallien added reviewers for D21039: avoid sending wrong or empty metadata to mpris2 interface: astippich, ngraham.
May 8 2019, 9:08 AM · Elisa
mgallien updated the diff for D21043: do not extend mouse areas in header bar longer than the text.
  • use Math.round to avoid having a font.pointSize being decimal
May 8 2019, 9:07 AM · Elisa

May 7 2019

ngraham accepted D21043: do not extend mouse areas in header bar longer than the text.

This now works!

May 7 2019, 6:43 PM · Elisa
mgallien updated the diff for D21043: do not extend mouse areas in header bar longer than the text.
  • fix corner cases by adding an extra length
May 7 2019, 5:58 PM · Elisa

May 6 2019

ngraham added a comment to D21043: do not extend mouse areas in header bar longer than the text.

I'm afraid even with this latest update to the patch, I still see elided text. :(

May 6 2019, 8:55 PM · Elisa
mgallien added a comment to D21043: do not extend mouse areas in header bar longer than the text.

11 pt Ubuntu font. I see the same thing with default 10 pt Noto Sans though:

As you can see, it's even worse with default settings since the four-letter album name gets elided too.

May 6 2019, 8:50 PM · Elisa
mgallien updated the diff for D21043: do not extend mouse areas in header bar longer than the text.
  • use the correct way to get the width of the text
May 6 2019, 8:49 PM · Elisa
ngraham added a comment to D21043: do not extend mouse areas in header bar longer than the text.

11 pt Ubuntu font. I see the same thing with default 10 pt Noto Sans though:

May 6 2019, 8:41 PM · Elisa