Sat, Jul 14
Jul 19 2017
Jul 18 2017
Please push it to gsoc2017 branch.
Jul 10 2017
All points are covered:
- representation for the nut, on the left
- representation for the circle markers 3, 5, 7...
- the patch is now applied directly on top of the "gsoc2017" branch
Jul 6 2017
Also, I'd expect this patch to be applicable into the gsoc2017 branch, containing only the new things you have made. It doesn't apply in such a branch.
Some suggestions before diving into code:
Jul 4 2017
Jun 30 2017
Jun 29 2017
Jun 27 2017
May 31 2017
Feb 17 2017
Feb 13 2017
solved previous bugs:
+ Please rename to currentExercise
+ Shouldn't that use "==" rather than ">="?
+ Please close the i18n call right after the string: i18n("You answered correctly"). There is no need for the broader context.
+ Please remove the braces
Also solved the additional issues:
+ When running a test, if I click in another exercise type the test must be interrupted. Currently, it keeps counting the previous test.
+ When running a test and click in the breadcrumb (back) button, the test isn't interrupted.
Some additional issues:
Feb 6 2017
Jan 29 2017
Oct 17 2016
Sep 29 2016
Sep 27 2016
Sep 21 2016
My ears say some weird things are still happening :)
Sep 20 2016
The documentation advise on setting Registered Param LSB and Registered Param MSB to 0.
The Data Entry MSB has been set to 14.
Those changes are done in the constructor of FluidSynthSoundBackend right after the definition of m_synth.
Actually, there is a much simpler implementation, with no need for using pitch bend events.
Just add the pitch drift in FluidSynthSoundBackend::prepareFromExerciseOptions. Something like:
Sep 19 2016
Thanks again for your patch. It seems the pitch change implementation still misses something, though. Fluidsynth documentation says:
Sep 17 2016
I've followed your recommendations.
Sliders have been set to:
- 12/-12/0 for pitch
- 200/50/100 for volume
The corresponding tunning for the fluidsynth lib are done in the setters.
Sep 14 2016
Could you please make the required changes?
Sep 12 2016
Sep 8 2016
Aug 15 2016
Not a high priority for the 16.08 release. Will take care of it in the next release.