User Details
- User Since
- Mar 10 2016, 2:45 PM (424 w, 16 h)
- Availability
- Available
Apr 4 2016
Apr 2 2016
Yeah space from the menu can be taken. Ultimately it would depend upon your implementation. If it looks great and tidy then there wont be any need to edit title.
Apr 1 2016
The only problem is label's position and space. I have implemented progress bar for the the player which took some of the available space. It will get merged in some time.
How about editing the application title instead of adding a label?
Mar 31 2016
Mar 29 2016
Mar 26 2016
Yeah, did another git pull. no change.
What is you OS configurations?
Happened with me too. Try reinstalling.
This is happening because the file "major-scale-and-its-modes.json" has been changed to "scales-major-and-its-modes.json".
Maybe it should be renamed back to what it was.
Duplicate files are copied in exercises folder of Minuet and then they get loaded by exercise controller.
Thanks for testing. Looks like its specific to my installation. No matter what I do I always have this crash.
Setting midi file path manually does not get me a segfault upon closing Minuet.
Here is the update,
For the first case, its not the fault of playing midi file. Simply opening the file open window and then closing Minuet leads to a crash.
Mar 20 2016
Mar 19 2016
@ahassan Dont drop diff here, create a differential at https://phabricator.kde.org/differential/diff/create/
It will make testing and reviewing easy.
Should the states in State enum be in all caps?
like STOPPED_STATE instead of StoppedState?
Mar 18 2016
Drumstick's GUI player has a progress bar. So I went through its code and found that SMFNoteOn signal is sent when a file is being read by drumstick::QSmf *m_smfReader. The smf reads whole file and from this me can get maximum current time.
When song will be played we can get the percentage and set value of progressbar, as Drumstick does.
But the output thread is stopped by m_midiSequencer->stop(); as it calls m_midiSequencerOutputThread->stop();
And m_midiSequencerOutputThread->stop() is defined in Drumstick so we can assume that they are safely closing the thread.
Mar 16 2016
Mar 15 2016
Mar 14 2016
We already have a differential for this.
https://phabricator.kde.org/D1112
Mar 12 2016
Mar 11 2016
I am able to fix the second case by adding
m_midiSequencerOutputThread->stop();
to MidiSequencer's destructor.
Mar 10 2016
The button now changes back to 'Play' state after playback is finished.