Add a "Test" feature to allow the user to test himself.
By pressing on "Start test", the user is given a set of 10 exercises and after he answers all the exercises, there should appear on the screen the percentage of correct answers.
Task: https://phabricator.kde.org/T5288
Details
Details
- Reviewers
sandroandrade - Maniphest Tasks
- T5288: Test feature
- Commits
- R163:e6459a11671e: Test feature
- Start an exercise.
- Press on the "Start test" (next to "give up")
- Answer all 10 questions
- Start a new test or continue with normal questions
Diff Detail
Diff Detail
- Repository
- R163 Minuet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Some additional issues:
- When running a test, if I click in another exercise type the test must be interrupted. Currently, it keeps counting the previous test.
- When running a test and click in the breadcrumb (back) button, the test isn't interrupted.
It'd be good if you could add a text informing the current test exercise, e.g., "1 of 10".
Thanks for your patch,
| src/app/qml/ExerciseView.qml | ||
|---|---|---|
| 46 | Please rename to currentExercise | |
| 99 | Shouldn't that use "==" rather than ">="? | |
| 100 | Please close the i18n call right after the string: i18n("You answered correctly"). There is no need for the broader context. | |
| 134 | Please remove the braces | |
| 234 | Maybe you can explicitly call newPlayQuestionButton.clicked()? With that, you can drop the newPlayQuestionOnPress function (which has a somehow weird name, btw) and keep the code inside newPlayQuestionButton.onClicked, as before. | |
Comment Actions
solved previous bugs:
+ Please rename to currentExercise
+ Shouldn't that use "==" rather than ">="?
+ Please close the i18n call right after the string: i18n("You answered correctly"). There is no need for the broader context.
+ Please remove the braces
Also solved the additional issues:
+ When running a test, if I click in another exercise type the test must be interrupted. Currently, it keeps counting the previous test.
+ When running a test and click in the breadcrumb (back) button, the test isn't interrupted.
not chanaged:
- "Maybe you can explicitly call newPlayQuestionButton.clicked()": onClicked cannot be called (from what i know and what i found on qml documentation)