Moved to https://invent.kde.org/kde/minuet/-/merge_requests/7
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Oct 28 2020
Oct 28 2020
May 17 2020
May 17 2020
Apr 26 2020
Apr 26 2020
Apr 25 2020
Apr 25 2020
QList<QString> populateDirs() {
QList<QString> jsonDirs;
const QString xdgDataDirsEnv = QFile::decodeName(qgetenv("XDG_DATA_DIRS"));
if (xdgDataDirsEnv.isEmpty()) {
return;
}
const auto parts = xdgDataDirsEnv.splitRef(QLatin1Char(':'), QString::SkipEmptyParts);
// Normalize paths, skip relative paths
for (const QStringRef &dir : parts) {
if (dir.startsWith(QLatin1Char('/'))) {
const QDir testDir(QDir(dir.toString()).absoluteFilePath(QStringLiteral("minuet/") + directoryName));
if (testDir.exists()) {
jsonDirs << testDir.absolutePath();
}
}
}
return jsonDirs;
}Apr 23 2020
Apr 23 2020
Jan 20 2020
Jan 20 2020
Reverb and chorus would remain active and you would leak memory. For details, see the link I mentioned above.
Jan 19 2020
Jan 19 2020
What consequence is there for using minuet with fluidsynth-2 without this patch? So far it had built and linked to it without issues.
Jan 17 2020
Jan 17 2020
ok, this looks better thanks :)
You're right. Sorry. I had an orphaned fluidsynth install in /usr/local/ which caused the wrong .so to be used at runtime.
Jan 16 2020
Jan 16 2020
If i add this patch it crashes just starting the app for me
Jan 11 2020
Jan 11 2020
Exactly.
Jan 10 2020
Jan 10 2020
Just to be clear, you're saying that this will compile and work both with fluidsynth 2.0 and fluidsynth 1.1, right?
Jul 14 2018
Jul 14 2018
Jul 19 2017
Jul 19 2017
Jul 18 2017
Jul 18 2017
Please push it to gsoc2017 branch.
Jul 10 2017
Jul 10 2017
All points are covered:
- representation for the nut, on the left
- representation for the circle markers 3, 5, 7...
- the patch is now applied directly on top of the "gsoc2017" branch
Jul 6 2017
Jul 6 2017
Also, I'd expect this patch to be applicable into the gsoc2017 branch, containing only the new things you have made. It doesn't apply in such a branch.
Some suggestions before diving into code:
Jul 4 2017
Jul 4 2017
Jun 30 2017
Jun 30 2017
Jun 29 2017
Jun 29 2017
Jun 27 2017
Jun 27 2017
May 31 2017
May 31 2017
Feb 17 2017
Feb 17 2017
Feb 13 2017
Feb 13 2017
solved previous bugs:
+ Please rename to currentExercise
+ Shouldn't that use "==" rather than ">="?
+ Please close the i18n call right after the string: i18n("You answered correctly"). There is no need for the broader context.
+ Please remove the braces
Also solved the additional issues:
+ When running a test, if I click in another exercise type the test must be interrupted. Currently, it keeps counting the previous test.
+ When running a test and click in the breadcrumb (back) button, the test isn't interrupted.
Some additional issues:
Feb 6 2017
Feb 6 2017
Jan 29 2017
Jan 29 2017
Oct 17 2016
Oct 17 2016
sandroandrade closed D2713: Pitch, Tempo and Volume using FluidSynth by committing R163:e65e0a073c4d: Pitch, Tempo and Volume using FluidSynth (authored by cedricbonhomme).
Sep 29 2016
Sep 29 2016
Sep 27 2016
Sep 27 2016
Sep 21 2016
Sep 21 2016
My ears say some weird things are still happening :)
Sep 20 2016
Sep 20 2016
The documentation advise on setting Registered Param LSB and Registered Param MSB to 0.
The Data Entry MSB has been set to 14.
Those changes are done in the constructor of FluidSynthSoundBackend right after the definition of m_synth.
In D2713#52416, @sandroandrade wrote:Actually, there is a much simpler implementation, with no need for using pitch bend events.
Just add the pitch drift in FluidSynthSoundBackend::prepareFromExerciseOptions. Something like:...
appendEvent(1, chosenRootNote + m_pitch, 127, 1000*(60.0/m_tempo));
...
foreach ...
appendEvent(1, chosenRootNote + additionalNote.toInt() + m_pitch, 127, ((m_playMode == "scale") ? 1000:4000)*(60.0/m_tempo));
Actually, there is a much simpler implementation, with no need for using pitch bend events.
Just add the pitch drift in FluidSynthSoundBackend::prepareFromExerciseOptions. Something like:
Sep 19 2016
Sep 19 2016
NOTE: to get the ability to pitch bend from zero down by one full octave (13 half steps in a chromatic scale = 6 ½ steps), use a value of 14, which allows you an just over an octave.
Thanks again for your patch. It seems the pitch change implementation still misses something, though. Fluidsynth documentation says:
Sep 17 2016
Sep 17 2016
I've followed your recommendations.
Sliders have been set to:
- 12/-12/0 for pitch
- 200/50/100 for volume
The corresponding tunning for the fluidsynth lib are done in the setters.
Sep 14 2016
Sep 14 2016
Could you please make the required changes?
Sep 12 2016
Sep 12 2016
sandroandrade edited reviewers for D2713: Pitch, Tempo and Volume using FluidSynth, added: sandroandrade; removed: Minuet.
Sep 8 2016
Sep 8 2016
sandroandrade moved T1918: Refactor architecture from Backlog to Work in Progress on the Minuet board.
Aug 15 2016
Aug 15 2016
ayushshah lowered the priority of T3376: Show only two rows of available options in answers's gray box and use horizontal scroll rather then vertical scroll from High to Low.
Not a high priority for the 16.08 release. Will take care of it in the next release.
Aug 9 2016
Aug 9 2016
sandroandrade triaged T3420: Anchor backspace button's bottom to screen's bottom in rhythm exercises as High priority.
sandroandrade triaged T3421: Render rhythm patterns with same size in the 'your answers' box in rhythm exercises as High priority.
Aug 3 2016
Aug 3 2016
Mouse pressed events have been removed and colors too have been removed
sandroandrade triaged T3372: Breadcrumb: click on "<" or Category Name to go back (rather than only "<") as High priority.
Aug 2 2016
Aug 2 2016
Jul 17 2016
Jul 17 2016
Thank you!
Jul 16 2016
Jul 16 2016
thank's for supporting the minuet project.
look good to me
Jun 24 2016
Jun 24 2016
commit : cbaaaee in minuetandroid branch
May 26 2016
May 26 2016
Somehow implemented in cdc66fce54c8ccf15e57fc78bae88f41600b23f1
sandroandrade renamed T1667: Add tooltip in midiplayer sliders from Helping user understand what each slider does to Add tooltip in midiplayer sliders.
sandroandrade renamed T1690: Investigate the use of cross-platform libraries for MIDI and/or plugin-based backend system from Investigate the use of PortMedia as cross-platform MIDI backend to Investigate the use of cross-platform libraries for MIDI and/or plugin-based backend system.
sandroandrade renamed T1668: Allows for using the virtual keyboard (or any other music instrument view) as input device for answering exercises from Clicking on piano notes does nothing once you come back to the main menu to Allows for using the virtual keyboard (or any other music instrument view) as input device for answering exercises.
sandroandrade closed T1754: When we open and play a midi file and then play an exercise question, the application stops and shows segmentation fault as Resolved.
Fixed somewhere.
Implemented in cdc66fce54c8ccf15e57fc78bae88f41600b23f1