GuitarView - beta

Authored by stefant on Jul 4 2017, 1:56 PM.



Created a beta version of the guitar.
Implemented just the visuals. Waiting for review to continue

Diff Detail

R163 Minuet
Lint Skipped
Unit Tests Skipped
stefant created this revision.Jul 4 2017, 1:56 PM
sandroandrade requested changes to this revision.Jul 6 2017, 7:58 PM


Some suggestions before diving into code:

  • Please use "Fret" rather than "Octave" in guitar. I'm still unsure if we'd need to show "Fret" in every position.
  • Although is some obvious, it'd be nice to have a different representation for the nut, on the left.
  • I'd add also the small circles usually placed on frets 3, 5, 7, 9, 12 (double circles here), 15, 17. That helps a lot to identify positions. See

Let's finish this patch and consider it only for the visual representation and then move into notes and chords visualization functionalities.

This revision now requires changes to proceed.Jul 6 2017, 7:58 PM

Also, I'd expect this patch to be applicable into the gsoc2017 branch, containing only the new things you have made. It doesn't apply in such a branch.

stefant updated this revision to Diff 16459.Jul 10 2017, 5:20 PM
stefant edited edge metadata.

All points are covered:

  • representation for the nut, on the left
  • representation for the circle markers 3, 5, 7...
  • the patch is now applied directly on top of the "gsoc2017" branch

+ some typo revisions: removed unnecessary spaces

sandroandrade accepted this revision.Jul 18 2017, 3:16 PM

Please push it to gsoc2017 branch.

This revision is now accepted and ready to land.Jul 18 2017, 3:16 PM