Sure, thanks for the improvement!

@cullmann could you integrate this?

Good catch :) please commit

I am just evaluating editors for Markdown and would love to see more convenience with Markdown in Kile/Kate/KWrite.

Thanks!

Ok, let's land that.

Here comes an updated version for test.mss:

Hi, nice that you keep working on this and upstream your stuff ;=)
Could you provide some test file for this?

This is done ;)

I think this is ok.
One can fine-tune the API docs still afterwards.
I see no "this is all evil" comments, therefore I approve this now!
Thanks for the contribution and I hope this is of use for your application!

Add explanation, how setKeywordList can be used

I think this features fits what you need.
Not sure if it is super useful in a lot other cases, as e.g. reloading the repository will reset all changes and one does need to trigger rehighlight oneself if one changes keywords.
But I think the added API is small and won't hurt further development.
Perhaps Volker could say if he is OK with this, too.

Mm, any changes?

Use REQUIRED_QT_VERSION to specifiy required Qt version.

Think this is closed then.

Add test and change the function description

Imho the API is currently not clear enough, see comment below. Can we somehow resolve this?

This looks more correct ;=)
Could you now add some test to the auto-tests? Thanks!

Bugfix

In D23061#509851, @cullmann wrote:

Hmm, I think we want an unit test for this, too.
And I think it won't work like it is, before the call to initLookupForCaseSensitivity one needs to clear both m_keywordsSortedCaseSensitive and m_keywordsSortedCaseInsensitive vectors.

Hmm, I think we want an unit test for this, too.
And I think it won't work like it is, before the call to initLookupForCaseSensitivity one needs to clear both m_keywordsSortedCaseSensitive and m_keywordsSortedCaseInsensitive vectors.

Use setKeywordList instead previous API

In D23061#509540, @cullmann wrote:

Actually, wouldn't it make more sense to just provide a way to set the full keyword list?
You can get the QStringlist will all keywords already with keywordList, a setKeywordList(...) would make more sense to me than this modifiers.
That would allow to alter it like you want and then write it back in one go with just one re-init of the mapping.

Actually, wouldn't it make more sense to just provide a way to set the full keyword list?
You can get the QStringlist will all keywords already with keywordList, a setKeywordList(...) would make more sense to me than this modifiers.
That would allow to alter it like you want and then write it back in one go with just one re-init of the mapping.