Framework: Syntax HighlightingProject
ActivePublic

Recent Activity

May 15 2020

cullmann closed D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".
May 15 2020, 3:45 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".

Sure, thanks for the improvement!

May 15 2020, 3:45 PM · Frameworks, Framework: Syntax Highlighting, Kate

May 14 2020

dhaumann updated subscribers of D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".

@cullmann could you integrate this?

May 14 2020, 6:33 AM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann accepted D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".

Good catch :) please commit

May 14 2020, 6:31 AM · Frameworks, Framework: Syntax Highlighting, Kate
bewuethr requested review of D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".
May 14 2020, 4:07 AM · Frameworks, Framework: Syntax Highlighting, Kate

May 2 2020

rriemann added a comment to T12782: Markdown Region Folding.

I am just evaluating editors for Markdown and would love to see more convenience with Markdown in Kile/Kate/KWrite.

May 2 2020, 9:07 PM · Framework: Syntax Highlighting

Mar 4 2020

miloszjanas triaged T12782: Markdown Region Folding as Wishlist priority.
Mar 4 2020, 7:11 PM · Framework: Syntax Highlighting

Mar 3 2020

sommer added a comment to D27430: [PATCH] General update for CartoCSS syntax highlighting.

Thanks!

Mar 3 2020, 7:06 AM · Frameworks, Framework: Syntax Highlighting, Kate

Mar 2 2020

cullmann closed D27430: [PATCH] General update for CartoCSS syntax highlighting.
Mar 2 2020, 7:19 PM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 28 2020

cullmann accepted D27430: [PATCH] General update for CartoCSS syntax highlighting.

Ok, let's land that.

Feb 28 2020, 5:07 PM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 18 2020

sommer added a comment to D27430: [PATCH] General update for CartoCSS syntax highlighting.

Here comes an updated version for test.mss:

Feb 18 2020, 9:54 PM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 16 2020

cullmann added a comment to D27430: [PATCH] General update for CartoCSS syntax highlighting.

Hi, nice that you keep working on this and upstream your stuff ;=)
Could you provide some test file for this?

Feb 16 2020, 12:57 PM · Frameworks, Framework: Syntax Highlighting, Kate
sommer added a reviewer for D27430: [PATCH] General update for CartoCSS syntax highlighting: Framework: Syntax Highlighting.
Feb 16 2020, 8:42 AM · Frameworks, Framework: Syntax Highlighting, Kate
sommer requested review of D27430: [PATCH] General update for CartoCSS syntax highlighting.
Feb 16 2020, 8:39 AM · Frameworks, Framework: Syntax Highlighting, Kate

Jan 20 2020

meganomic abandoned D26780: Update nasm.xml with instructions from the latest nasm docs.
Jan 20 2020, 8:33 AM · Frameworks, Framework: Syntax Highlighting, Kate
meganomic requested review of D26780: Update nasm.xml with instructions from the latest nasm docs.
Jan 20 2020, 8:22 AM · Frameworks, Framework: Syntax Highlighting, Kate

Sep 11 2019

cullmann closed T4522: Remove syntax definition files from KTextEditor as Resolved.

This is done ;)

Sep 11 2019, 5:25 AM · Framework: Syntax Highlighting

Aug 26 2019

dhaumann added inline comments to D23061: Possiblity to change Definition data after loading.
Aug 26 2019, 9:16 AM · Frameworks, Kate, Framework: Syntax Highlighting

Aug 25 2019

cullmann closed D23061: Possiblity to change Definition data after loading.
Aug 25 2019, 6:34 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann accepted D23061: Possiblity to change Definition data after loading.

I think this is ok.
One can fine-tune the API docs still afterwards.
I see no "this is all evil" comments, therefore I approve this now!
Thanks for the contribution and I hope this is of use for your application!

Aug 25 2019, 6:30 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko added inline comments to D23061: Possiblity to change Definition data after loading.
Aug 25 2019, 6:11 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko updated the diff for D23061: Possiblity to change Definition data after loading.

Add explanation, how setKeywordList can be used

Aug 25 2019, 6:06 PM · Frameworks, Kate, Framework: Syntax Highlighting

Aug 24 2019

dhaumann added inline comments to D23061: Possiblity to change Definition data after loading.
Aug 24 2019, 7:08 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added a comment to D23061: Possiblity to change Definition data after loading.

I think this features fits what you need.
Not sure if it is super useful in a lot other cases, as e.g. reloading the repository will reset all changes and one does need to trigger rehighlight oneself if one changes keywords.
But I think the added API is small and won't hurt further development.
Perhaps Volker could say if he is OK with this, too.

Aug 24 2019, 2:44 PM · Frameworks, Kate, Framework: Syntax Highlighting

Aug 20 2019

sirgienko added a comment to D23061: Possiblity to change Definition data after loading.

Mm, any changes?

Aug 20 2019, 10:45 AM · Frameworks, Kate, Framework: Syntax Highlighting

Aug 17 2019

cullmann closed D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 17 2019, 2:51 PM · Frameworks, Framework: Syntax Highlighting, Kate
cgiboudeaux accepted D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 17 2019, 1:51 PM · Frameworks, Framework: Syntax Highlighting, Kate
daandemeyer updated the diff for D23208: Use CMake find_dependency in CMake config file instead of find_package.

Use REQUIRED_QT_VERSION to specifiy required Qt version.

Aug 17 2019, 11:22 AM · Frameworks, Framework: Syntax Highlighting, Kate
cgiboudeaux added inline comments to D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 17 2019, 6:41 AM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann accepted D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 17 2019, 6:30 AM · Frameworks, Framework: Syntax Highlighting, Kate

Aug 16 2019

daandemeyer requested review of D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 16 2019, 5:33 PM · Frameworks, Framework: Syntax Highlighting, Kate

Aug 15 2019

cullmann closed T9771: Main context can be #poped as Resolved.

Think this is closed then.

Aug 15 2019, 6:29 PM · Framework: Syntax Highlighting

Aug 12 2019

sirgienko added inline comments to D23061: Possiblity to change Definition data after loading.
Aug 12 2019, 11:56 AM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko updated the diff for D23061: Possiblity to change Definition data after loading.

Add test and change the function description

Aug 12 2019, 11:50 AM · Frameworks, Kate, Framework: Syntax Highlighting

Aug 11 2019

dhaumann added a comment to D23061: Possiblity to change Definition data after loading.

Imho the API is currently not clear enough, see comment below. Can we somehow resolve this?

Aug 11 2019, 7:05 AM · Frameworks, Kate, Framework: Syntax Highlighting

Aug 10 2019

cullmann requested changes to D23061: Possiblity to change Definition data after loading.

This looks more correct ;=)
Could you now add some test to the auto-tests? Thanks!

Aug 10 2019, 7:24 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko updated the diff for D23061: Possiblity to change Definition data after loading.

Bugfix

Aug 10 2019, 6:03 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko added a comment to D23061: Possiblity to change Definition data after loading.

Hmm, I think we want an unit test for this, too.
And I think it won't work like it is, before the call to initLookupForCaseSensitivity one needs to clear both m_keywordsSortedCaseSensitive and m_keywordsSortedCaseInsensitive vectors.

Aug 10 2019, 5:47 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added a reviewer for D23061: Possiblity to change Definition data after loading: vkrause.
Aug 10 2019, 5:02 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added a comment to D23061: Possiblity to change Definition data after loading.

Hmm, I think we want an unit test for this, too.
And I think it won't work like it is, before the call to initLookupForCaseSensitivity one needs to clear both m_keywordsSortedCaseSensitive and m_keywordsSortedCaseInsensitive vectors.

Aug 10 2019, 5:01 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko updated the diff for D23061: Possiblity to change Definition data after loading.

Use setKeywordList instead previous API

Aug 10 2019, 4:35 PM · Frameworks, Kate, Framework: Syntax Highlighting

Aug 9 2019

sirgienko added a comment to D23061: Possiblity to change Definition data after loading.

Actually, wouldn't it make more sense to just provide a way to set the full keyword list?
You can get the QStringlist will all keywords already with keywordList, a setKeywordList(...) would make more sense to me than this modifiers.
That would allow to alter it like you want and then write it back in one go with just one re-init of the mapping.

Aug 9 2019, 9:44 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added a comment to D23061: Possiblity to change Definition data after loading.

Actually, wouldn't it make more sense to just provide a way to set the full keyword list?
You can get the QStringlist will all keywords already with keywordList, a setKeywordList(...) would make more sense to me than this modifiers.
That would allow to alter it like you want and then write it back in one go with just one re-init of the mapping.

Aug 9 2019, 9:38 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko added inline comments to D23061: Possiblity to change Definition data after loading.
Aug 9 2019, 8:39 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko requested review of D23061: Possiblity to change Definition data after loading.
Aug 9 2019, 8:38 PM · Frameworks, Kate, Framework: Syntax Highlighting

Jul 8 2019

cullmann abandoned D7909: Add syntax support for Crystal Programming Language.
Jul 8 2019, 5:22 PM · Kate, Frameworks, Framework: Syntax Highlighting
cullmann commandeered D7909: Add syntax support for Crystal Programming Language.

Please re-submit if you have time again, thanks!

Jul 8 2019, 5:22 PM · Kate, Frameworks, Framework: Syntax Highlighting

Jul 6 2019

nibags moved T9775: Integrate Fortran Free/Fixed from Backlog to Done on the Framework: Syntax Highlighting board.

Done in: c579929d8667 and 9c5875af2713

Jul 6 2019, 7:36 AM · Framework: Syntax Highlighting

Jul 3 2019

cullmann closed D22095: Fix CMake COMMAND nested paren highlighting.
Jul 3 2019, 6:19 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann accepted D22095: Fix CMake COMMAND nested paren highlighting.

Then we merge this ;=)

Jul 3 2019, 6:17 PM · Frameworks, Framework: Syntax Highlighting, Kate