Framework: Syntax HighlightingProject
ActivePublic

Recent Activity

Tue, Apr 16

cullmann closed D18996: Fix building with namespaced Qt.

The build issue got fixed.

Tue, Apr 16, 6:34 PM · Frameworks, Framework: Syntax Highlighting, Kate

Fri, Apr 12

cullmann closed D20233: Add syntax highlighting for fish shell.
Fri, Apr 12, 7:39 PM · Frameworks, Framework: Syntax Highlighting, Kate

Wed, Apr 10

cullmann accepted D20233: Add syntax highlighting for fish shell.

Ok, then we keep that license and push this as is.

Wed, Apr 10, 9:00 AM · Frameworks, Framework: Syntax Highlighting, Kate
adiestelhorst added a comment to D20233: Add syntax highlighting for fish shell.

I found nothing helpfull for this question. There is still the list of Unix commands, where I did only small additions and which is nearly half the lines of code.
When in doubt, I think it is better to stick to the rules. So I would like to keep it LGPL.

Wed, Apr 10, 5:37 AM · Frameworks, Framework: Syntax Highlighting, Kate

Sun, Apr 7

cullmann added a comment to D20233: Add syntax highlighting for fish shell.

If you think you nearly changed everything, I guess MIT is ok.
If you think still too much is derived, I can live with LGPL ;=)
I let you decide.

Sun, Apr 7, 1:17 PM · Frameworks, Framework: Syntax Highlighting, Kate

Sat, Apr 6

adiestelhorst added a comment to D20233: Add syntax highlighting for fish shell.

Thanks for the contribution.
On a first glance, that looks ok, no hard coded colors, test case, ...
We would prefer if the license would be MIT, is that possible?

Sat, Apr 6, 6:37 AM · Frameworks, Framework: Syntax Highlighting, Kate

Fri, Apr 5

cullmann requested changes to D20233: Add syntax highlighting for fish shell.

Thanks for the contribution.
On a first glance, that looks ok, no hard coded colors, test case, ...
We would prefer if the license would be MIT, is that possible?

Fri, Apr 5, 8:29 PM · Frameworks, Framework: Syntax Highlighting, Kate
nibags added reviewers for D20233: Add syntax highlighting for fish shell: Framework: Syntax Highlighting, dhaumann, cullmann.
Fri, Apr 5, 8:24 PM · Frameworks, Framework: Syntax Highlighting, Kate

Wed, Apr 3

adiestelhorst requested review of D20233: Add syntax highlighting for fish shell.
Wed, Apr 3, 6:46 PM · Frameworks, Framework: Syntax Highlighting, Kate

Sun, Mar 24

cullmann closed D19974: Add extensions to groovy highlighting.
Sun, Mar 24, 12:57 PM · Frameworks, Framework: Syntax Highlighting, Kate

Sat, Mar 23

dhaumann accepted D19974: Add extensions to groovy highlighting.
Sat, Mar 23, 9:19 PM · Frameworks, Framework: Syntax Highlighting, Kate
apushnov updated the diff for D19974: Add extensions to groovy highlighting.

Updated groovy.xml version from 5 to 6

Sat, Mar 23, 12:14 PM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann added a comment to D19974: Add extensions to groovy highlighting.

You also have to increase the "version" from 5 to 6. Could you provide an updated patch?

Sat, Mar 23, 7:08 AM · Frameworks, Framework: Syntax Highlighting, Kate

Fri, Mar 22

apushnov requested review of D19974: Add extensions to groovy highlighting.
Fri, Mar 22, 1:54 PM · Frameworks, Framework: Syntax Highlighting, Kate

Mar 7 2019

wbauer closed D19581: Fix build with cmake < 3.7.
Mar 7 2019, 8:26 AM · Frameworks, Framework: Syntax Highlighting, Kate
vkrause accepted D19581: Fix build with cmake < 3.7.
Mar 7 2019, 8:23 AM · Frameworks, Framework: Syntax Highlighting, Kate
wbauer requested review of D19581: Fix build with cmake < 3.7.
Mar 7 2019, 8:16 AM · Frameworks, Framework: Syntax Highlighting, Kate

Mar 5 2019

gennad added a watcher for Framework: Syntax Highlighting: gennad.
Mar 5 2019, 3:31 PM

Mar 4 2019

cullmann added a comment to D7909: Add syntax support for Crystal Programming Language.

;=) Any updates?

Mar 4 2019, 6:58 PM · Kate, Frameworks, Framework: Syntax Highlighting

Feb 28 2019

cgiboudeaux added inline comments to D18996: Fix building with namespaced Qt.
Feb 28 2019, 2:16 PM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 24 2019

dhaumann closed D19215: Install DefinitionDownloader header.
Feb 24 2019, 6:57 PM · Frameworks, Kate, Framework: Syntax Highlighting
vkrause accepted D19215: Install DefinitionDownloader header.
Feb 24 2019, 6:43 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann added a comment to D19215: Install DefinitionDownloader header.

I also do not see an issue with this.

Feb 24 2019, 6:27 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann closed D18734: Update octave.xml to Octave 4.2.0.
Feb 24 2019, 5:02 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann accepted D18734: Update octave.xml to Octave 4.2.0.

But beside the stuff with the xcvxv.xcvc stuff, I think you can commit this already as a first step to have a nicer highlighting, nice to see all hard coded colors gone!

Feb 24 2019, 4:54 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D18734: Update octave.xml to Octave 4.2.0.

For the . stuff in keywords, have you tried to specify some

Feb 24 2019, 4:53 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19215: Install DefinitionDownloader header.

I would have no issues with this if Volker is ok, too.

Feb 24 2019, 4:42 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko updated the diff for D18734: Update octave.xml to Octave 4.2.0.

Remove outdate Octave tests

Feb 24 2019, 1:53 PM · Frameworks, Framework: Syntax Highlighting, Kate
sirgienko updated the diff for D18734: Update octave.xml to Octave 4.2.0.

Add tests for Octave highlighting

Feb 24 2019, 1:48 PM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 23 2019

dhaumann added a comment to D19200: Return sorted definitions for file names and mime types.

Cool, thanks! ...which now leads us to the point where the only missing part is a unit test for the two new public functions :-)

Feb 23 2019, 8:21 AM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 22 2019

cullmann closed D19200: Return sorted definitions for file names and mime types.
Feb 22 2019, 7:54 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann accepted D19200: Return sorted definitions for file names and mime types.

Ok, this seems to work now here, too ;) Will merge it, thanks again.

Feb 22 2019, 7:53 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul requested review of D19215: Install DefinitionDownloader header.
Feb 22 2019, 7:10 AM · Frameworks, Kate, Framework: Syntax Highlighting
davschul updated the diff for D19200: Return sorted definitions for file names and mime types.

Yeah, I just missed to recheck the sorting logic. Before the change we just needed the best match so the partial sort was completely sufficient. Now we need a complete sorted vector, so stable sort is the way to go ;)

Feb 22 2019, 6:37 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

Thanks for taking a look again ;=)

Feb 22 2019, 6:02 AM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 21 2019

dhaumann added inline comments to D19200: Return sorted definitions for file names and mime types.
Feb 21 2019, 10:32 PM · Frameworks, Framework: Syntax Highlighting, Kate
davschul added a comment to D19200: Return sorted definitions for file names and mime types.

Ah sorry completely missed that part. Unfortunately I'm out of office already, I'll take a look as soon as I'm back tomorrow.

Feb 21 2019, 4:05 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

Actually, do we need a partial sort? Should we not just stable_sort the complete vector by prio? That should keep stuff with same prio untouched, or?

Feb 21 2019, 2:40 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

I think the + 1 is the only real issue, the other issue stems from my local setting that I have no compiled in QRC.

Feb 21 2019, 2:34 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann requested changes to D19200: Return sorted definitions for file names and mime types.
Feb 21 2019, 2:28 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

I think one error is the sort of the empty vector with the begin() + 1
But even then, make test fails, after fixing this.
Please take a look and run the tests.
Thanks

Feb 21 2019, 2:28 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

The partial sort is bad ;=()

Feb 21 2019, 2:21 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann reopened D19200: Return sorted definitions for file names and mime types.

Beside that this fails ;=)

Feb 21 2019, 2:19 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann closed D19200: Return sorted definitions for file names and mime types.
Feb 21 2019, 2:16 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann accepted D19200: Return sorted definitions for file names and mime types.

Yes, this is nice, nice trick with value(0) to avoid adding an element to the vector but just letting the API default construct it.

Feb 21 2019, 2:14 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann closed D18997: Add functions returning all definitions for a mimetype or file name.

Ok ;=)

Feb 21 2019, 2:13 PM · Frameworks, Kate, Framework: Syntax Highlighting
davschul added a comment to D18997: Add functions returning all definitions for a mimetype or file name.

Created https://phabricator.kde.org/D19200
That should implement all the latest suggestions/comments

Feb 21 2019, 1:58 PM · Frameworks, Kate, Framework: Syntax Highlighting
davschul requested review of D19200: Return sorted definitions for file names and mime types.
Feb 21 2019, 1:56 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D18996: Fix building with namespaced Qt.

No problem, I just reopened it that I remember to take a look again at it myself.
I just run into this issue wanting to land some patches on a openSUSE Leap machine.

Feb 21 2019, 1:28 PM · Frameworks, Framework: Syntax Highlighting, Kate
davschul added a comment to D18996: Fix building with namespaced Qt.

Okay I've tested it with 3.12.2 and there were no issues.
I'm not familiar enough with cmake to tell whether there is a simpler version for what I try to achieve here. I just need the -D QT_NAMESPACE compiler options. Is there someone in the community who might know how to make it in a more elegant way.
If not I do not need that target_link_libraries part in Qt Creator, because we still only support building via qmake or qbs. It was just to be complete here. So it could be removed without breaking our use case, but it would break namespace builds for any one else.

Feb 21 2019, 1:20 PM · Frameworks, Framework: Syntax Highlighting, Kate