Framework: Syntax HighlightingProject
ActivePublic

Recent Activity

Sun, Feb 17

cullmann reopened D18997: Add functions returning all definitions for a mimetype or file name.

I would propose:

Sun, Feb 17, 10:51 AM · Frameworks, Framework: Syntax Highlighting, Kate

Sat, Feb 16

dhaumann added a comment to D18997: Add functions returning all definitions for a mimetype or file name.

Ping?

Sat, Feb 16, 8:18 PM · Frameworks, Framework: Syntax Highlighting, Kate

Fri, Feb 15

sirgienko added a comment to D18734: Update octave.xml to Octave 4.2.0.

Could I specify, what dot is also word delimiter? Because, for example, "p.poly" has a wrong highlighting: "poly" highlighted as function, but it is not a function, it is a part of object "p".

Fri, Feb 15, 6:09 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann added a comment to D18734: Update octave.xml to Octave 4.2.0.

Good question:

I added a minimal howto to the README.md:

https://commits.kde.org/syntax-highlighting/9343341f91274f899f74b1ffe3fa260dadbc0978

Does that help you?

Partially. I have written the test file (test.octave), but after make test, I have errors in testhighlighter_test, htmlhighlighter_test and folding_test like this

FAIL!  : TestHighlighterTest::testHighlight(test.octave) 'ref.open(QIODevice::ReadOnly | QIODevice::Text)' returned FALSE. ()

If I change the filename to test.octave.syntax, I have only one error in testhighlighter_test:

TestHighlighterTest::cleanupTestCase() 'coveredList.open(QFile::WriteOnly)' returned FALSE. ()
   Loc: [/home/mmmm1998/Документы/Репозитории/syntax-highlighting/autotests/testhighlighter.cpp(108)]

I can't reproduce this build fail on my KDE Neon virtual machine, should I ignore this?

Also, what difference between highlight.tex and test.tex, for example? Octave have highlight_octave.m.syntax, which, I guess, is test file, should I remove it?

Fri, Feb 15, 8:06 AM · Frameworks, Kate, Framework: Syntax Highlighting

Thu, Feb 14

dhaumann added inline comments to D18997: Add functions returning all definitions for a mimetype or file name.
Thu, Feb 14, 1:00 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D18997: Add functions returning all definitions for a mimetype or file name.

Nice that we get the patches, then all can benefit from the improvements.

Thu, Feb 14, 9:04 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul added a comment to D18997: Add functions returning all definitions for a mimetype or file name.

Nice respond times here, and thanks for the reviews :)

Thu, Feb 14, 9:01 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann closed D18997: Add functions returning all definitions for a mimetype or file name.
Thu, Feb 14, 8:46 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann accepted D18997: Add functions returning all definitions for a mimetype or file name.

Thanks => will push that.

Thu, Feb 14, 8:45 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann closed D18996: Fix building with namespaced Qt.
Thu, Feb 14, 8:21 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul updated the diff for D18997: Add functions returning all definitions for a mimetype or file name.
Thu, Feb 14, 8:17 AM · Frameworks, Framework: Syntax Highlighting, Kate
vkrause accepted D18996: Fix building with namespaced Qt.

Looks good to me, thanks!

Thu, Feb 14, 8:16 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann requested changes to D18997: Add functions returning all definitions for a mimetype or file name.

Makes sense.

Thu, Feb 14, 7:23 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul requested review of D18997: Add functions returning all definitions for a mimetype or file name.
Thu, Feb 14, 7:20 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D18996: Fix building with namespaced Qt.

I think target_link_libraries is the right way to fix it, that's OK.
I am not that into the QT_.... macro magic, perhaps Volker can comment if that is ok ;)

Thu, Feb 14, 7:15 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul added inline comments to D18996: Fix building with namespaced Qt.
Thu, Feb 14, 7:00 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul requested review of D18996: Fix building with namespaced Qt.
Thu, Feb 14, 6:56 AM · Frameworks, Framework: Syntax Highlighting, Kate

Wed, Feb 13

sirgienko added a comment to D18734: Update octave.xml to Octave 4.2.0.

Good question:

I added a minimal howto to the README.md:

https://commits.kde.org/syntax-highlighting/9343341f91274f899f74b1ffe3fa260dadbc0978

Does that help you?

Wed, Feb 13, 2:23 PM · Frameworks, Kate, Framework: Syntax Highlighting

Tue, Feb 12

cullmann added a comment to D18734: Update octave.xml to Octave 4.2.0.

Good question:

Tue, Feb 12, 7:57 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko added a comment to D18734: Update octave.xml to Octave 4.2.0.

I think this is fine now, but I would like to have some autotests input file to have something we can later check for regressions.
Could you provide some MIT or otherwise freely licensed test file?
It must not cover all things, but at least some basic syntax and perhaps include some of your new things.
Thanks!

Tue, Feb 12, 7:42 PM · Frameworks, Kate, Framework: Syntax Highlighting
cullmann requested changes to D18734: Update octave.xml to Octave 4.2.0.

I think this is fine now, but I would like to have some autotests input file to have something we can later check for regressions.
Could you provide some MIT or otherwise freely licensed test file?
It must not cover all things, but at least some basic syntax and perhaps include some of your new things.
Thanks!

Tue, Feb 12, 7:33 PM · Frameworks, Kate, Framework: Syntax Highlighting

Tue, Feb 5

sirgienko added inline comments to D18734: Update octave.xml to Octave 4.2.0.
Tue, Feb 5, 4:33 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko updated the diff for D18734: Update octave.xml to Octave 4.2.0.

Add requested changes

Tue, Feb 5, 4:26 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko added a comment to D18734: Update octave.xml to Octave 4.2.0.

@dhaumann, look on the eps (this word contained in command list) on this image. The word have wrong highlighting.


I am testing my octave.xml file on v5.49.0 (current master need ecm 5.55 and I haven't it). Is it bug and I should create bug report, or it is already fixed?

Tue, Feb 5, 4:23 PM · Frameworks, Kate, Framework: Syntax Highlighting

Mon, Feb 4

dhaumann added a comment to D18734: Update octave.xml to Octave 4.2.0.

...And there are also new Default Styles for kateversion="5.0", see: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/

Mon, Feb 4, 9:51 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann added a comment to D18734: Update octave.xml to Octave 4.2.0.

Could you also switch to WordDetect for the trivial cases, and set kateversion="5.0" ?

Mon, Feb 4, 9:47 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko requested review of D18734: Update octave.xml to Octave 4.2.0.
Mon, Feb 4, 7:39 PM · Frameworks, Kate, Framework: Syntax Highlighting
sirgienko closed D18714: Add some Maxima constans and function.
Mon, Feb 4, 5:52 PM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann added a comment to D18714: Add some Maxima constans and function.

In your branch, you should type: arc land
This will merge your branch to master and commit/push your changes, and close this revision. This only works, if you have commit access. If not, we'll take care of this for now.

Mon, Feb 4, 5:42 PM · Frameworks, Framework: Syntax Highlighting, Kate

Sun, Feb 3

sirgienko added a comment to D18714: Add some Maxima constans and function.

Should I land it via arc? Or mannualy commit it (for short commit message)?

Sun, Feb 3, 9:39 PM · Frameworks, Framework: Syntax Highlighting, Kate
sirgienko updated the diff for D18714: Add some Maxima constans and function.

Increase version

Sun, Feb 3, 9:38 PM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann accepted D18714: Add some Maxima constans and function.

Looks good to me, the only missing part is to increase thw "version" number each time a highlighting file is changed.

Sun, Feb 3, 9:34 PM · Frameworks, Framework: Syntax Highlighting, Kate
sirgienko retitled D18714: Add some Maxima constans and function from Add some Maxima constans to MaximaVariable list to Add some Maxima constans and function.
Sun, Feb 3, 8:37 PM · Frameworks, Framework: Syntax Highlighting, Kate
sirgienko updated the diff for D18714: Add some Maxima constans and function.

Add Maxima function

Sun, Feb 3, 8:37 PM · Frameworks, Framework: Syntax Highlighting, Kate
sirgienko requested review of D18714: Add some Maxima constans and function.
Sun, Feb 3, 8:33 PM · Frameworks, Framework: Syntax Highlighting, Kate

Thu, Jan 31

andreasgr added a comment to D18617: AsciiDoc: Fix highlighting of include directive.

Looks good to me. Please increase the "version" number whenever you change an highlighting file.

Thu, Jan 31, 5:43 AM · Frameworks, Kate, Framework: Syntax Highlighting

Wed, Jan 30

dhaumann closed D18617: AsciiDoc: Fix highlighting of include directive.
Wed, Jan 30, 9:41 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann accepted D18617: AsciiDoc: Fix highlighting of include directive.

Looks good to me. Please increase the "version" number whenever you change an highlighting file.

Wed, Jan 30, 9:38 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr requested review of D18617: AsciiDoc: Fix highlighting of include directive.
Wed, Jan 30, 2:34 PM · Frameworks, Kate, Framework: Syntax Highlighting

Tue, Jan 29

andreasgr added a comment to D18475: Add AsciiDoc support.
  1. I apply your patch: arc patch D18475
Tue, Jan 29, 8:34 AM · Frameworks, Kate, Framework: Syntax Highlighting

Mon, Jan 28

dhaumann closed D18475: Add AsciiDoc support.
Mon, Jan 28, 9:47 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann accepted D18475: Add AsciiDoc support.
  1. I apply your patch: arc patch D18475
  2. Since there is a new syntax highlighting file, I do: touch data/syntax-data.qrc.in
  3. I switch to the build directory, type make -j4 install
  4. I run the tests, some fail, since the reference of your test file is missing
  5. In the build folder, I run: ./autotests/update-reference-data.sh
  6. Now git status tells me there are several untracked files:
    • autotests/folding/asciidoc.adoc.fold
    • autotests/html/asciidoc.adoc.html
    • autotests/reference/asciidoc.adoc.ref
  7. In the source folder, I git add all these files, then commit
  8. Finally, I call: arc diff to land your patch
Mon, Jan 28, 9:41 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr added a comment to D18475: Add AsciiDoc support.

Hi!!
Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use make test and autotests/update-reference-data.sh.

Mon, Jan 28, 1:20 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr added a comment to D18475: Add AsciiDoc support.

If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal).

Mon, Jan 28, 12:12 PM · Frameworks, Kate, Framework: Syntax Highlighting

Sun, Jan 27

nibags added a comment to D18475: Add AsciiDoc support.

If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal). I have done this in some highlight files

Sun, Jan 27, 7:29 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr updated the diff for D18475: Add AsciiDoc support.

Fix diff.

Sun, Jan 27, 7:28 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr updated the diff for D18475: Add AsciiDoc support.
  • Added test AsciiDoc.
Sun, Jan 27, 7:21 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr updated the diff for D18475: Add AsciiDoc support.
  • Drop unused 'admonition' keyword list.
  • Rename itemData elements to start with capital letters.
  • Enable escaping in block and section titles.
Sun, Jan 27, 7:11 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr added a comment to D18475: Add AsciiDoc support.

Running the katesyntaxhighlighting indexer tells me:

katehighlightingindexer::KeywordChecker::check: "syntax-highlighting/data/syntax/asciidoc.xml" Unused keyword lists: "admonition"

Could you fix this? Usually, keyword completion should be context dependent anyways (currently a bug), so soon your unused list will indeed not have any effect.

Sun, Jan 27, 5:28 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann added a comment to D18475: Add AsciiDoc support.

Running the katesyntaxhighlighting indexer tells me:

Sun, Jan 27, 4:04 PM · Frameworks, Kate, Framework: Syntax Highlighting