I'm user of Manjaro KDE and I love coding using Kate. Currently I'm focused in Crystal learning using Ruby syntax, however Ruby syntax doesn't support all Crystal features.

In D7909#199469, @dhaumann wrote:

Sorry for the late reply.

Please do the following changes:

• remove hard-coded colors from itemDatas. This way, your highlighting will look good in all color themes.
  
  Also, is this language similar to other languages ? It seems it was copied from some other language, since it contains many authors.

Hi @dhaumann, I'm not an expert on kate editor, so this crystal syntax highlighting is based on ruby highlighting :-)

I'll remove hard-coded colors from itemDatas, What other change would you recommend?

In D7909#242391, @cullmann wrote:

The hard-coded colors got removed, test is there, all fine.
Thanks for the contribution!
If you can't push youself, tell me, I will push for you.

Great!, This is my first contribution to The KDE project, I'm very happy you accepted it! :)

Great!, This is my first contribution to The KDE project, I'm very happy you accepted it! :)

I assume that means I shall push?
:=)

And the auto-test does have diffs like:

-<span style="font-weight:bold;">class</span> <span style="color:#0057ae;">Markdown</span><span style="color:#ff9fec;">::</span><span style="color:#0057ae;">Parser</span>

• <span style="color:#000080;">record</span> <span style="color:#0057ae;">PrefixHeader</span>, count : <span style="color:#0057ae;">Int32</span>
• <span style="color:#000080;">record</span> <span style="color:#0057ae;">UnorderedList</span>, char : <span style="color:#0057ae;">Char</span>

+<span style="font-weight:bold;">class</span> <span style="color:#0057ae;">Markdown</span>::<span style="color:#0057ae;">Parser</span>
+ record <span style="color:#0057ae;">PrefixHeader</span>, count : <span style="color:#0057ae;">Int32</span>
+ record <span style="color:#0057ae;">UnorderedList</span>, char : <span style="color:#0057ae;">Char</span>

In D7909#242422, @cullmann wrote:

Ah, I let just the build run once more locally, the current static check says:

"/local/cullmann/kf5/src/frameworks/syntax-highlighting/data/syntax/crystal.xml" Unused itemData: QSet("Region Marker", "Error", "Expression")
"/local/cullmann/kf5/src/frameworks/syntax-highlighting/data/syntax/crystal.xml" Unused contexts: QSet("Comment Line")

Could you take a short look why that is? Perhaps just some left-over parts?

Ok, let me fix that :)

Hi, did you get some time to look at the remaining issues?
If they are fixed, I am happy to merge that.

In D7909#307484, @cullmann wrote:

Hi, did you get some time to look at the remaining issues?
If they are fixed, I am happy to merge that.

Hi, I haven't fixed the issues yet. I'm working on that, I will reply you again when the changes are ready :)

Hi, any update on this?

In D7909#318737, @cullmann wrote:

Hi, any update on this?

Not yet! :)

Ping? ;=)

In D7909#346328, @cullmann wrote:

Ping? ;=)

Hi, I'm still here, I need some more time to get it working well. :)

;=) Any updates?