Sure, thanks for the improvement!

@cullmann could you integrate this?

Good catch :) please commit

I am just evaluating editors for Markdown and would love to see more convenience with Markdown in Kile/Kate/KWrite.

Thanks!

Ok, let's land that.

Here comes an updated version for test.mss:

Hi, nice that you keep working on this and upstream your stuff ;=)
Could you provide some test file for this?

This is done ;)

I think this is ok.
One can fine-tune the API docs still afterwards.
I see no "this is all evil" comments, therefore I approve this now!
Thanks for the contribution and I hope this is of use for your application!

Add explanation, how setKeywordList can be used

I think this features fits what you need.
Not sure if it is super useful in a lot other cases, as e.g. reloading the repository will reset all changes and one does need to trigger rehighlight oneself if one changes keywords.
But I think the added API is small and won't hurt further development.
Perhaps Volker could say if he is OK with this, too.

Mm, any changes?

Use REQUIRED_QT_VERSION to specifiy required Qt version.

Think this is closed then.

Add test and change the function description

Imho the API is currently not clear enough, see comment below. Can we somehow resolve this?

This looks more correct ;=)
Could you now add some test to the auto-tests? Thanks!

Bugfix

In D23061#509851, @cullmann wrote:

Hmm, I think we want an unit test for this, too.
And I think it won't work like it is, before the call to initLookupForCaseSensitivity one needs to clear both m_keywordsSortedCaseSensitive and m_keywordsSortedCaseInsensitive vectors.

Hmm, I think we want an unit test for this, too.
And I think it won't work like it is, before the call to initLookupForCaseSensitivity one needs to clear both m_keywordsSortedCaseSensitive and m_keywordsSortedCaseInsensitive vectors.

Use setKeywordList instead previous API

In D23061#509540, @cullmann wrote:

Actually, wouldn't it make more sense to just provide a way to set the full keyword list?
You can get the QStringlist will all keywords already with keywordList, a setKeywordList(...) would make more sense to me than this modifiers.
That would allow to alter it like you want and then write it back in one go with just one re-init of the mapping.

Actually, wouldn't it make more sense to just provide a way to set the full keyword list?
You can get the QStringlist will all keywords already with keywordList, a setKeywordList(...) would make more sense to me than this modifiers.
That would allow to alter it like you want and then write it back in one go with just one re-init of the mapping.

Please re-submit if you have time again, thanks!

Done in: c579929d8667 and 9c5875af2713

Then we merge this ;=)

After reflection (:D), I think the constraint is weak, the creation of new syntax is rare compared to the rest.

Ah, yes. Here's a revised patch that also applies that change (and adds tests) for add_custom_target, execute_process, and add_test.

I would say all commands w/ COMMAND named parameter need that. Also, add_custrom_target and execute_process...

Updated cmake.xml + cmake.xml.tpl version number.

Ah, I missed: the version should be updated.

Looks reasonable to me. Thanks!

Perhaps we must go away from the implicit listing of the syntax files and really just add them all to the CMakeLists.txt,

I am confused, the generation of index.katesyntax fails because the list "variables" does not exist (there is no variable predefined in this context). We may be in a situation where a change of branch does not recompile the index file :/.

Nice, I use ninja here, cool to have!

Lgtm

Thanks for the update!

oops, missing version increase

OK I understand. Initially I had not changed the version number of txsh.xml and it is based on the reference in /usr/share/org.kde.syntax-highlighting/syntax/index.katesyntax rather than in the repository.
And the fact that the versions in the index file were newer than my xml files... I had errors with highlight.fish.

Actually the resource should be recreated on syntax file changes and be used.

I forgot to ask about running the tests. Is it normal that system syntax files take precedence if we have an index.katesyntax? Currently I have to run the tests by setting the environment variable XDG_DATA_DIRS.

Change looks reasonable + test case => thanks, please push

The build issue got fixed.

Ok, then we keep that license and push this as is.

I found nothing helpfull for this question. There is still the list of Unix commands, where I did only small additions and which is nearly half the lines of code.
When in doubt, I think it is better to stick to the rules. So I would like to keep it LGPL.

If you think you nearly changed everything, I guess MIT is ok.
If you think still too much is derived, I can live with LGPL ;=)
I let you decide.

In D20233#444099, @cullmann wrote:

Thanks for the contribution.
On a first glance, that looks ok, no hard coded colors, test case, ...
We would prefer if the license would be MIT, is that possible?

Thanks for the contribution.
On a first glance, that looks ok, no hard coded colors, test case, ...
We would prefer if the license would be MIT, is that possible?

Updated groovy.xml version from 5 to 6

You also have to increase the "version" from 5 to 6. Could you provide an updated patch?

;=) Any updates?