Krita: Next FeaturesProject
ActivePublic

Recent Activity

Aug 9 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

https://invent.kde.org/tusooaw/krita/commit/24355db3272a02230a14217da6023a953ec8f119

The crash does not come from KisCanvas2 but KisNode actually, as I said that it happens only when the undo command is not created (so KisNode is deleted by KisNodeReplaceBasedStrokeStrategy::Private's destructor, which is executed in the image thread (by the destructor of KisStroke)).

Ref: https://invent.kde.org/tusooaw/krita/blob/24355db3272a02230a14217da6023a953ec8f119/libs/global/kis_thread_safe_signal_compressor.h

Aug 9 2019, 7:52 AM · Krita: Next Features

Jul 26 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

The crash does not come from KisCanvas2 but KisNode actually, as I said that it happens only when the undo command is not created (so KisNode is deleted by KisNodeReplaceBasedStrokeStrategy::Private's destructor, which is executed in the image thread (by the destructor of KisStroke)).

Jul 26 2019, 3:14 AM · Krita: Next Features

Jul 25 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

On the crash upon deletion of stroke strategy without creating an undo command:

It happens only when (1) we are not using debugger (so it is probably some timing issue); (2) the mouse is released immediately after pressing; and (3) no undo command is created.

https://invent.kde.org/snippets/335 indicates that the problem probably lies in KisCanvas2, whose m_d->canvasUpdateCompressor is of type KisSignalCompressor instead of the thread-safe one.

But I did also get another error message complaining from QObject::~QObject().

Jul 25 2019, 8:22 AM · Krita: Next Features
tusooaw added a comment to T10901: Better undo/redo for Krita.

On the crash upon deletion of stroke strategy without creating an undo command:

Jul 25 2019, 8:06 AM · Krita: Next Features

Jul 8 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

A note on KisNode::copyFromNode():

Jul 8 2019, 1:15 PM · Krita: Next Features
tusooaw added a comment to T10901: Better undo/redo for Krita.

Currently the methods return a KUndo2Command that will do the changes. However, it should be possible to make them only do the changes, by taking a clone of the active layer before making undoable changes to it.

Jul 8 2019, 1:07 PM · Krita: Next Features

Jun 28 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

Refactor out q-pointers and derived d-pointers in Flake

Jun 28 2019, 9:05 AM · Krita: Next Features

Jun 21 2019

tusooaw closed T10991: Snapshot Docker as Resolved.
Jun 21 2019, 7:16 AM · Krita: Next Features
tusooaw closed T10991: Snapshot Docker, a subtask of T10901: Better undo/redo for Krita, as Resolved.
Jun 21 2019, 7:16 AM · Krita: Next Features

Jun 20 2019

dkazakov added a comment to T10901: Better undo/redo for Krita.

Discussion on derived d-pointers.

Jun 20 2019, 10:58 AM · Krita: Next Features
dkazakov added a comment to T10901: Better undo/redo for Krita.

About q-pointers.

Jun 20 2019, 10:45 AM · Krita: Next Features
tusooaw added a comment to T10901: Better undo/redo for Krita.

Discussion on derived d-pointers.

Jun 20 2019, 9:32 AM · Krita: Next Features
tusooaw added a comment to T10901: Better undo/redo for Krita.

Discussion on q-pointers.

Jun 20 2019, 4:15 AM · Krita: Next Features

Jun 18 2019

tusooaw updated subscribers of T10991: Snapshot Docker.
Jun 18 2019, 8:43 AM · Krita: Next Features
tusooaw added a comment to T10991: Snapshot Docker.

There is said to be delay when switching between snapshots if one uses OpenGL canvas.

Jun 18 2019, 8:42 AM · Krita: Next Features

May 29 2019

tusooaw added a comment to T10991: Snapshot Docker.

The branch for this task is at https://invent.kde.org/tusooaw/krita/commits/tusooaw/T10991-snapshot-docker (deleted after merging)

May 29 2019, 9:29 AM · Krita: Next Features

May 27 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

Related branch:

May 27 2019, 12:39 AM · Krita: Next Features
tusooaw created T10991: Snapshot Docker.
May 27 2019, 12:38 AM · Krita: Next Features

May 17 2019

tusooaw closed T10819: Better UI for dealing with Clone Layers as Resolved.
May 17 2019, 4:40 PM · Krita: Next Features

May 8 2019

tusooaw updated the task description for T10901: Better undo/redo for Krita.
May 8 2019, 4:45 PM · Krita: Next Features
tusooaw created T10901: Better undo/redo for Krita.
May 8 2019, 4:42 PM · Krita: Next Features

Apr 29 2019

tusooaw edited projects for T10819: Better UI for dealing with Clone Layers, added: Krita: Next Features; removed Krita: Abyss.
Apr 29 2019, 11:23 PM · Krita: Next Features

Apr 19 2019

alvinhochun closed T10765: Make canvas render correctly under fractional scaling, a subtask of T2299: Make the canvas behave in HiDPI mode, as Resolved.
Apr 19 2019, 2:35 AM · Krita: Next Features
alvinhochun closed T10765: Make canvas render correctly under fractional scaling as Resolved.
Apr 19 2019, 2:35 AM · Krita: Next Features

Apr 6 2019

alvinhochun updated the task description for T10765: Make canvas render correctly under fractional scaling.
Apr 6 2019, 8:35 AM · Krita: Next Features
alvinhochun added a revision to T10765: Make canvas render correctly under fractional scaling: D20097: Fix OpenGL canvas under fractional DPI scaling.
Apr 6 2019, 7:09 AM · Krita: Next Features
alvinhochun triaged T10765: Make canvas render correctly under fractional scaling as Normal priority.
Apr 6 2019, 7:09 AM · Krita: Next Features

Apr 1 2019

alvinhochun added a revision to T2299: Make the canvas behave in HiDPI mode: D20171: Fix wrong DPI when moving window across screens.
Apr 1 2019, 3:44 PM · Krita: Next Features

Mar 28 2019

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.
Mar 28 2019, 6:11 PM · Krita: Next Features
alvinhochun added a revision to T2299: Make the canvas behave in HiDPI mode: D20097: Fix OpenGL canvas under fractional DPI scaling.
Mar 28 2019, 5:41 PM · Krita: Next Features

Mar 19 2019

rempt added a member for Krita: Next Features: jgupta.
Mar 19 2019, 1:22 PM

Feb 20 2019

woltherav added a commit to T10368: Add more icons to status bar memory thing.: R37:2baeb7890ff2: Add a visual indicator to memory reporting..
Feb 20 2019, 12:12 PM · Krita: Next Features

Feb 19 2019

woltherav added a comment to T10368: Add more icons to status bar memory thing..

ok, for the frames stuff, based on this reddit post:
https://www.reddit.com/r/krita/comments/arr8rw/memory_limit_reached_i_cant_save_my_frames/

Feb 19 2019, 12:11 PM · Krita: Next Features

Feb 18 2019

rempt added a comment to T10368: Add more icons to status bar memory thing..

I like the colored bar, but I do think that having an icon with danger sign would also helpful.

Feb 18 2019, 2:58 PM · Krita: Next Features

Feb 17 2019

woltherav added a comment to T10368: Add more icons to status bar memory thing..

Regarding the bar, I was thinking something like this(though perhaps should go into red faster). The smaller lighter box at the start is the imagesize compared to the full colored box, which would be the total ram consumption(stats.totalMemorySize) vs total memory limit. Problem: Sometimes the imagesize(stats.imageSize) is larger than the total ram consumption(stats.totalMemorySize), and I don't know why, @dkazakov?

Feb 17 2019, 4:29 PM · Krita: Next Features

Feb 10 2019

woltherav updated subscribers of T10368: Add more icons to status bar memory thing..

I'm thinking we should have an icon that shows up at 50%, as the current one shows up at 87.5%. Furthermore, I remember an old presentation of this shooter game where they set the healthbar to start warning the player at 50%, because humans aren't very good at judging their resources, and they found players would manage their resource(health) much better when they were warned at 50%.

Feb 10 2019, 3:32 PM · Krita: Next Features

Jan 17 2019

Deevad added a comment to T10368: Add more icons to status bar memory thing..

Very good. Thank you for opening this topic. From a user perspective; I'll answer something basic and minimal: a yellow icon (maybe with a orange outline) appears on the bottom (near the memory usage) around 80% of max resources used. The icon might look like a button one can press: a pop-up display a small text explaining basic things about ram and proposing solution: reduce layer stack by merging, split large animation into scenes, etc...

Jan 17 2019, 4:39 PM · Krita: Next Features
woltherav triaged T10368: Add more icons to status bar memory thing. as Wishlist priority.
Jan 17 2019, 4:18 PM · Krita: Next Features
woltherav created T10368: Add more icons to status bar memory thing..
Jan 17 2019, 4:18 PM · Krita: Next Features

Dec 2 2018

pilee claimed T1000: Quick-play button.
Dec 2 2018, 8:59 PM · Krita: Next Features (Needs GUI Design), Krita: Animation

Oct 17 2018

alvinhochun reopened T2299: Make the canvas behave in HiDPI mode as "Open".

@dkazakov I see that you've changed the code to use devicePixelRatioF. I can see that the canvas now attempts to render at 100% device pixel size.

Oct 17 2018, 8:41 AM · Krita: Next Features
alvinhochun added a commit to T2299: Make the canvas behave in HiDPI mode: R37:046ce7128a7e: Fix fractional display scale factor.
Oct 17 2018, 7:47 AM · Krita: Next Features

Oct 10 2018

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

One more issue: The fix seems to have used the integer version of devicePixelRatio somewhere instead of the floating point devicePixelRatioF. This is from my observation forcing a 1.5x scaling on Windows. I haven't checked the code. Even though Qt now rounds the scale factor to nearest integer on Windows, we should assume that real fractional scaling support will be added in the future. In fact the then-in-progress task https://bugreports.qt.io/browse/QTBUG-53022 is exactly for this. (It might even be already supported on KDE, but I can't confirm.) So please fix it to use the floating point devicePixelRatio.

Oct 10 2018, 4:38 PM · Krita: Next Features
alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

@dkazakov Thanks for the partial fix. I've done some testing on Windows with krita-nightly-x64-v4.1.3.1-239-ge64348e693, so here's my observations/findings:

Oct 10 2018, 4:38 PM · Krita: Next Features
rempt added a commit to T2299: Make the canvas behave in HiDPI mode: R37:3d77d9f5bae5: Fix canvas scale in HiDPI mode.
Oct 10 2018, 9:43 AM · Krita: Next Features

Oct 7 2018

dkazakov closed T2299: Make the canvas behave in HiDPI mode as Resolved by committing R37:9d95d8d5386e: Fix canvas scale in HiDPI mode.
Oct 7 2018, 9:55 PM · Krita: Next Features

Oct 5 2018

davidedmundson added a comment to T2299: Make the canvas behave in HiDPI mode.

If all you want is to fix the blurriness without fixing the actual issue, I had a series of patches to do that (D7973, D7982, D7984).

Oct 5 2018, 11:45 AM · Krita: Next Features
alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

I'm not sure that it really happens this way.

Feel free to check.

This fixes one of the two issues that will make it less blurry https://phabricator.kde.org/P263

Oct 5 2018, 2:39 AM · Krita: Next Features

Oct 4 2018

dkazakov added a comment to T2299: Make the canvas behave in HiDPI mode.

Okay, it looks like Qt actually creates the double-sized frame buffer, but we still see it as a single-sized (and reset the viewport). We should just set the viewport to this doubled size.

Oct 4 2018, 7:56 PM · Krita: Next Features
dkazakov added a comment to T2299: Make the canvas behave in HiDPI mode.

Feel free to check.

Oct 4 2018, 6:30 PM · Krita: Next Features