Option to acquire the guiding status from PHD2 to stay in sync
ClosedPublic

Authored by wreissenberger on Apr 13 2020, 8:04 AM.

Details

Summary

Due to concurrency in PHD2 it might happen, that a last guiding step is executed after a pause command has been successfully executed. This can create problems with the Guide module, since the Guide module assumes automatically being in state GUIDE_GUIDING if it sees a guiding step.
To resolve this, the PHD2 module no longer guesses the state but it re-aquires it from PHD2.

This method could be used in future in other situations as well. Due to try to avoid any regressions, I only resolved this single code place. If it turns out to be stable, we could refactor other places as well.

Test Plan

This specific situation is difficult to test. Since a central method handling a received state information has been refactored, please test all situations where PHD2 changes its state.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.Apr 13 2020, 8:04 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 13 2020, 8:04 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Apr 13 2020, 8:04 AM
mutlaqja accepted this revision.Apr 13 2020, 3:00 PM
This revision is now accepted and ready to land.Apr 13 2020, 3:00 PM
This revision was automatically updated to reflect the committed changes.