Handle guiding problems during dithering
ClosedPublic

Authored by wreissenberger on Sun, Nov 3, 8:49 PM.

Details

Summary

This is an extension of the diff D25105.

When a guiding problem occurs during dithering, the schedule does not restart guiding and capturing. This happens only in the case that the capture sequence has a delay > 0 defined. The reason is that both the Scheduler and the Capture module try to restart capturing, which ends up the Capture module in the wait state.

With this diff, the Capture module resumes capturing after dithering only if no problems occured. If a problem occurs, capturing aborts which leaves it to the Scheduler to restart capturing.

Test Plan

Enable dithering in the guiding module. Start a schedule with a capture sequence that has multiple captures and uses guiding. Start the schedule and interrupt guiding during dithering.

Execute this for all combinations of "Abort Autoguiding on failure" set or unset as well as having a delay > 0 set in the capture sequence or not.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.Sun, Nov 3, 8:49 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSun, Nov 3, 8:49 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Sun, Nov 3, 8:49 PM

It looks like this would give the user duplicate messages on success or failure of dithering. I can't test it now due to time constraints, but it looks like it would tell the user:

Dithering succeeded ...
Dither complete....

or

Dithering failed...'
Warning: Dithering failed...

Seems a little repetitive.

It looks like this would give the user duplicate messages on success or failure of dithering.

That's not the case. I added a logging message to improve debugging, but it is not shown in the message frame of the INDI Client.

oh ok, gotcha. I see now they are different types of messages.

mutlaqja accepted this revision.Mon, Nov 4, 5:55 AM
This revision is now accepted and ready to land.Mon, Nov 4, 5:55 AM
This revision was automatically updated to reflect the committed changes.