Weather sensor data graph display
ClosedPublic

Authored by wreissenberger on Wed, Oct 9, 9:39 PM.

Details

Summary

Weather sensor data is collected over time and displayed as graph. The user can switch between all available sensors from INDI Weather.

Test Plan

Add a weather device to your EKOS profile - use Weather Simulator if no own Weather device is present - and check, whether the available sensor data is displayed correctly over time.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.Wed, Oct 9, 9:39 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptWed, Oct 9, 9:39 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Wed, Oct 9, 9:39 PM

Here a screenshot of the new graphs:

wow this is beautiful! Thanks for working on it! Will test it soon.

It seems there is problem when switching between weather parameters, check video below.

I also noticed another issue.. because there is warning, I see count-down.. however, there are no actions to take so why is there a count-down? it counts down to what?

also, I think instead of displaying the tooltip in the graph, it should be like the guide graph in the sense that it displays the reading value @ time. Then it's very useful to know the exact value at a particular time stamp.

It seems there is problem when switching between weather parameters, check video below.

Repainting the entire graph happens with a certain delay - I have to investigate this whether it is possible to accelerate it. And I think it makes sense having the 0-line always visible.

I also noticed another issue.. because there is warning, I see count-down.. however, there are no actions to take so why is there a count-down? it counts down to what?

Well, when the countdown is over, exactly nothing will happen :-P OK, OK, it's a bug...

also, I think instead of displaying the tooltip in the graph, it should be like the guide graph in the sense that it displays the reading value @ time. Then it's very useful to know the exact value at a particular time stamp.

Good point, I will do it.

  • Immediate replot sensor graph after rescaling axes
  • Show graph value as tool tip, display optimization

I also noticed another issue.. because there is warning, I see count-down.. however, there are no actions to take so why is there a count-down? it counts down to what?

That's not so easy to fix. Will be handled in a separate diff.

Great! now it works just fine. I think the only thing missing is a small clear button to reset all the data.

Btw, if a weather driver does not provide a particular parameter (e.g. humidity), is it disabled? hidden?

wreissenberger planned changes to this revision.Sat, Oct 12, 9:17 AM

Great! now it works just fine. I think the only thing missing is a small clear button to reset all the data.

OK, update will come.

Btw, if a weather driver does not provide a particular parameter (e.g. humidity), is it disabled? hidden?

Currently I grab all INDI number properties from the INDI weather module and filter to all properties with names starting with "WEATHER_". The unit of the parameter is currently simply coded into the INDI label of the number property and is not evaluated.

My intention is to make this more flexible so that for example a temperature sensor from a guiding camera can also be tracked. As soon as we have that we can for example think about a temperature compensation feature in the focuser - which I would really appreciate.

But step by step...

  • Add the option to clear the sensor data history
  • Bug fixing of the display when no weather or no dome is present
mutlaqja accepted this revision.Wed, Oct 16, 5:18 AM

Great, I'll merge this. I think one additional improvement for the future is to include the time in the tooltip as well instead of trying to gauge when exactly was this moment in time by looking at the horizontal axis.

This revision is now accepted and ready to land.Wed, Oct 16, 5:18 AM
This revision was automatically updated to reflect the committed changes.

I think one additional improvement for the future is to include the time in the tooltip as well instead of trying to gauge when exactly was this moment in time by looking at the horizontal axis.

I know, but I was not so sure if I get it right in one iteration with local time etc and all this stuff.