Ensure that guiding is running when capture is started
ClosedPublic

Authored by wreissenberger on Fri, Nov 1, 9:25 PM.

Details

Summary

When guiding terminates after a capture sequence has terminated, the scheduler does not restart the guiding before it executes the next iteration of the capture sequence. With this fix, the scheduler checks, whether a requested guiding is running before the capture sequence is started.

Test Plan

Create a schedule that repeats a capture sequence several times and requires guiding. Start the schedule and interrupt guiding exactly when a single capture sequence is completed. Since this is only a short time frame, use the debugger, set a breakpoint in SequenceJob::setStatus() and wait, until the status is set to JOB_DONE. As soon as this is the case, stop guiding. Without this fix, the scheduler starts the next capture sequence iteration without restarting the guiding. With this fix, guiding should be restarted.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.Fri, Nov 1, 9:25 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFri, Nov 1, 9:25 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Fri, Nov 1, 9:25 PM
mutlaqja accepted this revision.Sat, Nov 2, 7:08 AM
This revision is now accepted and ready to land.Sat, Nov 2, 7:08 AM
This revision was automatically updated to reflect the committed changes.
TallFurryMan added inline comments.Sat, Nov 2, 10:22 AM
kstars/ekos/scheduler/scheduler.cpp
2154

Thus advice block is actually sound, but there was not enough tests done to include it.

2711

OK this is code that was moved.

3507

OK this is code that was moved.

4537

This is actually the diff. OK.

4863

OK dead code.

4892

OK.