- User Since
- Jan 16 2017, 8:41 PM (147 w, 5 d)
Thu, Nov 14
Deleting arcsec symbol where it should not be
fixing possible crash
Wed, Nov 13
Thu, Nov 7
Mon, Nov 4
commas not args
Resorting getExposeLeft, and updating the summary screen timer
That makes sense, because they may want just the exposure time, not the exposure time plus download
oh ok, gotcha. I see now they are different types of messages.
Sun, Nov 3
It looks like this would give the user duplicate messages on success or failure of dithering. I can't test it now due to time constraints, but it looks like it would tell the user:
I like it, this is a great idea!
Sat, Nov 2
Ok I think these changes make a lot of sense. Making a method for checking if guiding is active instead of just checking the state is a very good idea because then we can do what you did and check a number of guide states at the same time, but also if we need to check something else besides the state we could do that too. So I like that.
Thu, Oct 31
I'm glad, this is a better solution than just turning on auto star.
Please see if clearing the starCenter helps.
Clearing starCenter variable
It did work for PHD2. There must be something else for the internal guider.
Please see if this is any better. Also make sure it works!
Clearing the tracking box after the meridian flip rather than setting autostar.
Also doing it for both Internal Guider AND PHD2, instead of just PHD2.
I was not aware that the tracking star still being selected when guiding resumes after a meridian flip was affecting the internal guider as well? From the forum you posted, I'm not sure I'm clear if this is part of the problem or the whole problem they were having. Clearly though the one person at the start of the thread didn't have the clear mount calibration option set and that was causing issues with the internal guider. Is it also still trying to track the old guide star after it moves/flips?
Hmm. Maybe I will try this out when I get a chance.
Wed, Oct 30
I'm not sure if we should change the KStars/Ekos default for checking the autostar box. Currently the default is false, I just checked.
I took the one line back out.
Taking the one line back out
Ok yes, so then I should remove that one line, I misinterpreted what you said in the first place to mean that you thought that every time it should default to having autostar checked when PHD2 is used as the guider unless the user disables it specifically. I don't think it should cause any issues except with the meridian flip and this patch will fix that anyway.
So Ekos uses the green tracking box as the coordinates that will be used to set PHD2's lock position. If the green tracking box has not been set, then PHD2 will automatically choose a star even if autostar isn't selected.
2- I'm not sure the autoStarCheck->setChecked(true); inside of Guide::resizeEvent() is quite right. I would think we'd want to default this way if the user hasn't previously set a preference, but one he/she does express a preference, then the preference should be remembered across sessions. The way I read this is that it doesn't allow the user to keep his preference across sessions. So, I'd keep this as is, if the cross-session thing is complex, but would like the end-game to be restoring the user's preference.
1- In the new method, Guide::guideAfterMeridianFlip(): Why would the issue be only related to PHD2? Wouldn't the internal guider also have the same issue? That is, after a meridian flip, the guide star's image position would change either when using PHD2 or with the native guider, so I would think you'd want to remove the "if(guiderType == GUIDE_PHD2)" test, and simply set autoStarCheck->setChecked(true); in either case.
Tue, Oct 29
Oct 1 2019
Disconnecting currentCCD if the user switches to another camera.
Sep 30 2019
Two more checks that PHD2 is configured just to make sure.
Ok I think I resolved all those issues. It seems to be working better now. Please test again.
Removing option for external guide frames, fixing missing method, saving subFrame setting for PHD2, improving logic.
I found a way to enforce the user's star lock position when guiding is started.
Please test again to see if I fixed all the issues. I also reduced the message spam from the configure PHD2 camera method.
I also successfully managed to get my idea of SubFrame implemented. It seems to work perfectly now, and lets you click to subframe to the Guide Star Image when you like, and go back too.
"Personally, I do not like it when the FITS viewer pops up with the image from the guiding camera - no matter in what state Ekos and PHD2 are. I am not fully aware of all the consequences what happens if it is turned off."
Fixing Linguider issues, Making SubFrame Button work, cleaning up methods, and fixing disabling external guider when not connected.
Sep 29 2019
So I figured out why the restart was required (at least for my code) when switching between full external guide frames and the guide star image from PHD2. It was a matter of two methods with very similar names but different parameters. So I had given it the wrong parameter. I think it works now. I'm pretty sure we can now make a button to click back and forth between full external guide frames and the guide star image. It would be just like going to a subframe, except it isn't really. Thoughts?
Fixed the external guide frame enable/disable issue that was requiring restart.
Sep 28 2019
Changing to contains method
Sep 27 2019
But whoever made the change that made Ekos not change the state to guiding, should check to make sure that my change to make that work again doesn't break whatever that person was trying to fix. . .unfortunately I don't know who changed it, when it changed, or why it was changed. . .
One of the major fixes in this diff, the case when PHD2 starts guiding remotely and it wasn't changing the state to guiding in Ekos, used to work perfectly about a year ago after my first big round of PHD2 changes. I'm not sure exactly when it broke, but somebody must have made a change (me or somebody else) in the meantime that broke it.
Sep 23 2019
Sep 22 2019
Sep 8 2019
Improving interface for config file editor and index file downloader.
Providing details about folder permissions.
Adding dialog to ask if user really wants to download copies of index files
Sep 7 2019
The three items should now be fixed
Removing unnecessary option, fixing local conf file setup, making conf editor load automatically, and consolidating conf file creation methods to one file.
Should now be default true on all systems
Sep 2 2019
I changed the name as suggested
Fixing name problem
Aug 29 2019
Aug 24 2019
Aug 23 2019
Jun 20 2019
Jun 17 2019
Jun 15 2019
Mar 12 2019
Mar 3 2019
Feb 2 2019
Dec 2 2018
Too many graphs were on the histogram due to blue and green getting created without being deleted