Differential D22864

use zero-based coordinate system on the plot
ClosedPublic
Actions

Authored by miklosm on Jul 31 2019, 9:17 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R296:6292aa057a38: use zero-based coordinate system on the plot
Summary

This patch also supports negative values, but the plot drawing code can't properly handle them.

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
miklosm created this revision.Jul 31 2019, 9:17 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 31 2019, 9:17 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
miklosm requested review of this revision.Jul 31 2019, 9:17 PM
ngraham added a subscriber: ngraham.Aug 1 2019, 11:45 PM

Can you describe what problem this is fixing, or what improvement it produces? It's not clear from your Summary section.

miklosm added a comment.Aug 2 2019, 2:12 PM
In D22864#505559, @ngraham wrote:

Can you describe what problem this is fixing, or what improvement it produces? It's not clear from your Summary section.

The problem this is fixing:

When the upload speed is constant, the green plot line disappears completely.

davidedmundson accepted this revision.Aug 3 2019, 7:59 AM
This revision is now accepted and ready to land.Aug 3 2019, 7:59 AM
ngraham added a comment.Aug 4 2019, 8:42 PM

Thanks for the patch!

Closed by commit R296:6292aa057a38: use zero-based coordinate system on the plot (authored by miklosm, committed by ngraham). · Explain WhyAug 4 2019, 9:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63088

View Options

src/qmlcontrols/kquickcontrolsaddons/plotter.cpp

Loading...