Differential D22865

remove drawing a black line segment at the end of the plot
AcceptedPublic
Actions

Authored by miklosm on Jul 31 2019, 9:19 PM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Summary

I have no idea what the purpose of this code was. It was added in 6117a42bee54a456, and it looks unrelated to the rest of that changeset.

Diff Detail

Repository
R296 KDeclarative
Lint
Lint Skipped
Unit
Unit Tests Skipped
miklosm created this revision.Jul 31 2019, 9:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 31 2019, 9:19 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
miklosm requested review of this revision.Jul 31 2019, 9:19 PM
davidedmundson accepted this revision as: davidedmundson.Aug 2 2019, 8:54 AM
davidedmundson added a subscriber: davidedmundson.

and it looks unrelated to the rest of that changeset.

It does.

Do you have a commit account?
If so, I would suggest you merge after Saturday's tagging.

This revision is now accepted and ready to land.Aug 2 2019, 8:54 AM
miklosm added a comment.Aug 2 2019, 2:11 PM
In D22865#505628, @davidedmundson wrote:

and it looks unrelated to the rest of that changeset.

It does.

Do you have a commit account?
If so, I would suggest you merge after Saturday's tagging.

No, I'm just an occasional contributor.

miklosm added a comment.Jun 12 2020, 2:01 PM

Was this forgotten?

Revision Contents
Changeset List

Diff 62877

View Options

src/qmlcontrols/kquickcontrolsaddons/plotter.cpp

Loading...