Differential D13314

Use file contents when selecting extractor plugin
ClosedPublic
Actions

Authored by miklosm on Jun 3 2018, 7:44 PM.

Details

Reviewers
elvisangelaccio
Commits
R824:8ff94325b690: Use file contents when selecting extractor plugin
Summary

Selecting extractor plugin based on file name can result in failed metadata extraction if the file name suffix is wrong, e.g. a jpeg image named album.pdf.

This is part of the fix for https://bugs.kde.org/show_bug.cgi?id=220496

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
miklosm created this revision.Jun 3 2018, 7:44 PM
Restricted Application added a project: Baloo. · View Herald TranscriptJun 3 2018, 7:44 PM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
miklosm requested review of this revision.Jun 3 2018, 7:44 PM
elvisangelaccio accepted this revision.Jun 3 2018, 8:54 PM
This revision is now accepted and ready to land.Jun 3 2018, 8:54 PM
ngraham added a subscriber: ngraham.Jun 4 2018, 5:13 AM
astippich added a comment.Nov 17 2018, 3:39 PM

@miklosm shall I land this for you?

miklosm added a comment.Nov 23 2018, 8:28 PM
In D13314#361034, @astippich wrote:

@miklosm shall I land this for you?

If it is accepted, then yes, please.

astippich added a comment.Nov 28 2018, 7:29 AM

@miklosm can you provide your email address for the git commit or can you re-upload using arcanist, please?

astippich added a comment.Dec 1 2018, 10:35 AM

nevermind, found the information in another commit

Closed by commit R824:8ff94325b690: Use file contents when selecting extractor plugin (authored by miklosm, committed by astippich). · Explain WhyDec 1 2018, 10:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractor.cpp (2 lines)

Diff 46599

View Options

src/extractor.cpp

Loading...