User Details
User Details
- User Since
- Sep 30 2017, 4:49 AM (394 w, 4 d)
- Availability
- Available
May 10 2018
May 10 2018
markey committed R181:d98ec3f7a913: Use new kpackage_install_bundled_package macro (authored by malteveerman).
Use new kpackage_install_bundled_package macro
Ubuntu 18.04 is now released, and your patch builds fine with it.
May 6 2018
May 6 2018
markey committed R181:bce427f2fb54: If BUILD_TESTING was explicitly set to OFF then don't build tests. (authored by markey).
If BUILD_TESTING was explicitly set to OFF then don't build tests.
May 5 2018
May 5 2018
markey added a comment to R181:9d0e6bdc5695: Make building unit tests optional and default-disabled (option WITH_TESTS)..
Good idea. Done! :)
markey committed R181:f4a0e027b358: Make gmock an optional dependency. Tests are built if gmock is found. (authored by markey).
Make gmock an optional dependency. Tests are built if gmock is found.
May 4 2018
May 4 2018
markey added a comment to R181:9d0e6bdc5695: Make building unit tests optional and default-disabled (option WITH_TESTS)..
Nope it's not redundant because there is no way to make BUILD_TESTING default to OFF, or is there? You see, that's the whole point, default-disabling the tests.
markey committed R181:d5793a5dabf4: Remove .reviewboardrc - KDE now uses Phabricator. (authored by markey).
Remove .reviewboardrc - KDE now uses Phabricator.
May 2 2018
May 2 2018
markey committed R181:9d0e6bdc5695: Make building unit tests optional and default-disabled (option WITH_TESTS). (authored by markey).
Make building unit tests optional and default-disabled (option WITH_TESTS).
Apr 28 2018
Apr 28 2018
Fixed fadebars
markey accepted D12492: Fixed fadebars.
Apr 21 2018
Apr 21 2018
Some analyzer applet tweaks
Fixed crash at shutdown
Apr 15 2018
Apr 15 2018
Improvements to CurrentTrack applet
Apr 12 2018
Apr 12 2018
More interface stuttering work
Apr 4 2018
Apr 4 2018
markey added a comment to D11862: Get rid of scripting.
See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild.
Fix missing include for std::thread.
Reduce interface stuttering
Logger overhaul
markey accepted D11867: Logger overhaul.
Apr 1 2018
Apr 1 2018
markey committed R181:5176c93e41e4: Fixed wrong slot signatures in BrowserMessageArea (authored by malteveerman).
Fixed wrong slot signatures in BrowserMessageArea
markey committed R181:ef7ec2c70f60: Small MySQL libraries fix for tests. (authored by malteveerman).
Small MySQL libraries fix for tests.
Mar 25 2018
Mar 25 2018
Some small changes and fixes
Mar 20 2018
Mar 20 2018
Reactivate wikipedia applet
markey requested changes to D11349: Reactivate wikipedia applet.
Generally this works for me now, but there are two more issues that I found:
Mar 19 2018
Mar 19 2018
Ask mysql for libs to link to
Mar 18 2018
Mar 18 2018
markey requested changes to D11349: Reactivate wikipedia applet.
Fails to build here:
Mar 14 2018
Mar 14 2018
Fixed a crash in magnatune service
markey committed R181:12d7ecbfe6e8: Port NetworkAccessManager to new signal/slot syntax (authored by malteveerman).
Port NetworkAccessManager to new signal/slot syntax
Mar 13 2018
Mar 13 2018
markey committed R181:16d4997c3792: Ported playdar collection away from qjson (authored by malteveerman).
Ported playdar collection away from qjson
markey requested changes to D11171: Port NetworkAccessManager to new signal/slot syntax.
This does not build for me (GCC 7.2.0).
Mar 9 2018
Mar 9 2018
markey committed R181:459ed3a342f0: Use Kirigami's spacing and icon sizes and remove own implementation (authored by malteveerman).
Use Kirigami's spacing and icon sizes and remove own implementation
Kirigami2 seems really nifty. Nice choice.
Mar 7 2018
Mar 7 2018
markey added a comment to T8078: Port away from libmysqld (embedded server).
Just a note: Back in the day Amarok was actually using SQLite, but there were major performance issues for people with giant collections. E.g. I was just talking to a user on IRC with a 44k tracks collection.
Fix some deprecation warnings
Mar 5 2018
Mar 5 2018
Make Webkit optional
markey committed R181:cf491101e892: Disable Discogs and Google cover search temporarily (authored by heikobecker).
Disable Discogs and Google cover search temporarily
Mar 4 2018
Mar 4 2018
Port tests to Qt5/KF5
Mar 2 2018
Mar 2 2018
markey committed R181:ea60d1523218: Fixed a crash in analyzer applet when sample rate reported by engine controller… (authored by malteveerman).
Fixed a crash in analyzer applet when sample rate reported by engine controller…
Ported importers to Qt5/KF5
Feb 28 2018
Feb 28 2018
markey added a comment to D10923: Make Webkit optional.
Is this patch meant for master? Because the branch is "webkit-optional".
Feb 26 2018
Feb 26 2018
Ported some services to Qt5/KF5
Feb 25 2018
Feb 25 2018
markey committed R181:4b9a4e88c9f6: Fix for Amarok::saveLocation() not setting separator before subdirectory. (authored by malteveerman).
Fix for Amarok::saveLocation() not setting separator before subdirectory.
markey added a comment to D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory..
Hey Malte, please fix your real name for the next patch. KDE commit hook rejects this:
Feb 23 2018
Feb 23 2018
New context area
markey accepted D10708: New context area.
Feb 20 2018
Feb 20 2018
markey committed R181:d78f666e58de: Port core application away from kdelibs4 (authored by malteveerman).
Port core application away from kdelibs4
Looks good to me. Builds and works fine too.
Feb 15 2018
Feb 15 2018
markey added a comment to D10526: Port core application away from kdelibs4.
Oct 22 2017
Oct 22 2017
markey committed R181:cd7b5aa2e9bc: Disable GPodder service for now as it can crash Amarok on startup. (authored by markey).
Disable GPodder service for now as it can crash Amarok on startup.
streamlined plugin system
markey accepted D8229: streamlined plugin system.
Seems to work ok here.
Oct 9 2017
Oct 9 2017
some crash and hang fixes