| markey | May 2 2018, 6:21 PM |
This is a bit redundant; BUILD_TESTING is defined in KDECMakeSettings.cmake and already used by amarok anyway; you may as well document this variable in building_amarok2_in_home, as it is done in many other KDE projects.
In addition, Qt5Test could be made optional under the same BUILD_TESTING conditional.
Nope it's not redundant because there is no way to make BUILD_TESTING default to OFF, or is there? You see, that's the whole point, default-disabling the tests.
When you put it like that, yes you're right, The other option I can think of is moving find_package(GoogleMock) to the root CMakeLists.txt and making it non-required, adding tests subdir only if it is found (in addition to BUILD_TESTING=ON. That makes missing gmock non-fatal to users and continues to run the tests on CI with default settings.