Differential D8213

some crash and hang fixes
ClosedPublic
Actions

Authored by malteveerman on Oct 8 2017, 9:40 PM.

Details

Reviewers
markey
Group Reviewers
Amarok
Commits
R181:dcb859b8df66: some crash and hang fixes
Summary

This just fixes some crashes and hangs.

Diff Detail

Repository
R181 Amarok
Branch
qt5/kf5
Lint
Lint Skipped
Unit
Unit Tests Skipped
malteveerman created this revision.Oct 8 2017, 9:40 PM
malteveerman edited the summary of this revision. (Show Details)Oct 8 2017, 9:42 PM
malteveerman added a reviewer: Amarok.
markey added a subscriber: markey.Oct 9 2017, 5:40 PM
markey accepted this revision.Oct 9 2017, 5:59 PM

Nice fixes. Builds fine too.

This revision is now accepted and ready to land.Oct 9 2017, 5:59 PM
markey closed this revision.Oct 9 2017, 6:03 PM
anthonyfieroni added a subscriber: anthonyfieroni.Oct 9 2017, 6:14 PM

Last time i saw this code QThreadStorage allocates MySQL connection by thread but it's not destroy them thus ~ThreadInitializer() was never called.

Revision Contents
Changeset List

PathPackages
Msrc/MainWindow.cpp (40 lines)
Msrc/SvgHandler.cpp (3 lines)
Msrc/browsers/CollectionTreeView.cpp (5 lines)
Msrc/configdialog/ConfigDialog.h (17 lines)
Msrc/configdialog/ConfigDialog.cpp (5 lines)
Msrc/configdialog/ConfigDialogBase.h (3 lines)
Msrc/configdialog/ConfigDialogBase.cpp (4 lines)
Msrc/configdialog/dialogs/CollectionConfig.h (8 lines)
Msrc/configdialog/dialogs/CollectionConfig.cpp (12 lines)
Msrc/configdialog/dialogs/DatabaseConfig.h (8 lines)
Msrc/configdialog/dialogs/DatabaseConfig.cpp (2 lines)
Msrc/configdialog/dialogs/GeneralConfig.h (8 lines)
Msrc/configdialog/dialogs/GeneralConfig.cpp (7 lines)
Msrc/configdialog/dialogs/MetadataConfig.h (8 lines)
Msrc/configdialog/dialogs/MetadataConfig.cpp (9 lines)
Msrc/configdialog/dialogs/NotificationsConfig.h (8 lines)
Msrc/configdialog/dialogs/NotificationsConfig.cpp (6 lines)
Msrc/configdialog/dialogs/PlaybackConfig.h (8 lines)
Msrc/configdialog/dialogs/PlaybackConfig.cpp (2 lines)
Msrc/configdialog/dialogs/PluginsConfig.h (8 lines)
Msrc/configdialog/dialogs/PluginsConfig.cpp (6 lines)
Msrc/configdialog/dialogs/ScriptsConfig.h (8 lines)
Msrc/configdialog/dialogs/ScriptsConfig.cpp (6 lines)
Msrc/core-impl/collections/support/MemoryQueryMaker.cpp (1 line)
Msrc/core-impl/meta/proxy/MetaProxyWorker.h (1 line)
Msrc/core-impl/meta/proxy/MetaProxyWorker.cpp (10 lines)
Msrc/core-impl/storage/sql/mysql-shared/MySqlStorage.cpp (10 lines)
Msrc/core-impl/storage/sql/mysqlestorage/MySqlEmbeddedStorage.cpp (6 lines)
Msrc/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorage.cpp (5 lines)
Msrc/playlistgenerator/Preset.cpp (2 lines)
Msrc/statusbar/ProgressBar.h (1 line)
Msrc/statusbar/ProgressBar.cpp (3 lines)

Diff 20501

View Options

src/MainWindow.cpp

Loading...
View Options

src/SvgHandler.cpp

Loading...
View Options

src/browsers/CollectionTreeView.cpp

Loading...
View Options

src/configdialog/ConfigDialog.h

Loading...
View Options

src/configdialog/ConfigDialog.cpp

Loading...
View Options

src/configdialog/ConfigDialogBase.h

Loading...
View Options

src/configdialog/ConfigDialogBase.cpp

Loading...
View Options

src/configdialog/dialogs/CollectionConfig.h

Loading...
View Options

src/configdialog/dialogs/CollectionConfig.cpp

Loading...
View Options

src/configdialog/dialogs/DatabaseConfig.h

Loading...
View Options

src/configdialog/dialogs/DatabaseConfig.cpp

Loading...
View Options

src/configdialog/dialogs/GeneralConfig.h

Loading...
View Options

src/configdialog/dialogs/GeneralConfig.cpp

Loading...
View Options

src/configdialog/dialogs/MetadataConfig.h

Loading...
View Options

src/configdialog/dialogs/MetadataConfig.cpp

Loading...
View Options

src/configdialog/dialogs/NotificationsConfig.h

Loading...
View Options

src/configdialog/dialogs/NotificationsConfig.cpp

Loading...
View Options

src/configdialog/dialogs/PlaybackConfig.h

Loading...
View Options

src/configdialog/dialogs/PlaybackConfig.cpp

Loading...
View Options

src/configdialog/dialogs/PluginsConfig.h

Loading...
View Options

src/configdialog/dialogs/PluginsConfig.cpp

Loading...
View Options

src/configdialog/dialogs/ScriptsConfig.h

Loading...
View Options

src/configdialog/dialogs/ScriptsConfig.cpp

Loading...
View Options

src/core-impl/collections/support/MemoryQueryMaker.cpp

Loading...
View Options

src/core-impl/meta/proxy/MetaProxyWorker.h

Loading...
View Options

src/core-impl/meta/proxy/MetaProxyWorker.cpp

Loading...
View Options

src/core-impl/storage/sql/mysql-shared/MySqlStorage.cpp

Loading...
View Options

src/core-impl/storage/sql/mysqlestorage/MySqlEmbeddedStorage.cpp

Loading...
View Options

src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorage.cpp

Loading...
View Options

src/playlistgenerator/Preset.cpp

Loading...
View Options

src/statusbar/ProgressBar.h

Loading...
View Options

src/statusbar/ProgressBar.cpp

Loading...