Ported some services to Qt5/KF5
0d7ae231eea9
Actions

Authored by malteveerman on Feb 26 2018, 7:04 PM.

Description

Ported some services to Qt5/KF5

Summary: This patch ports the ampache, magnatune, gpodder and opmldirectory services. I've laid some groundwork for the other services too, but they still have problems. For example: Jamendo has changed its API, which makes the service useless in its current form. Mp3tunes and lastfm don't work either, but I haven't yet investigated why.

Reviewers: Amarok, markey

Reviewed By: Amarok, markey

Subscribers: asturmlechner, Amarok

Tags: Amarok

Differential Revision: https://phabricator.kde.org/D10831

Details

Committed

markey

Feb 26 2018, 7:26 PM

Reviewer

Amarok

Differential Revision

D10831: Ported some services to Qt5/KF5

Parents

R181:4b9a4e88c9f6: Fix for Amarok::saveLocation() not setting separator before subdirectory.

Branches

Unknown

Tags

Unknown

markey committed R181:0d7ae231eea9: Ported some services to Qt5/KF5 (authored by malteveerman).Feb 26 2018, 7:26 PM

Changes (133)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path	Packages
	M			CMakeLists.txt
	D			cmake/modules/FindLibmygpo-qt.cmake
	M			src/CMakeLists.txt
	M			src/core/podcasts/PodcastImageFetcher.cpp
	M			src/services/CMakeLists.txt
	M			src/services/ampache/AddServerDialog.cpp
	M			src/services/ampache/AddServerDialog.h
	M			src/services/ampache/AmpacheAccountLogin.cpp
	M			src/services/ampache/AmpacheAccountLogin.h
	M			src/services/ampache/AmpacheConfig.cpp
	M			src/services/ampache/AmpacheConfig.h
	M			src/services/ampache/AmpacheMeta.h
	M			src/services/ampache/AmpacheService.cpp
	M			src/services/ampache/AmpacheService.h
	M			src/services/ampache/AmpacheServiceCollection.cpp
	M			src/services/ampache/AmpacheServiceCollection.h
	M			src/services/ampache/AmpacheServiceQueryMaker.cpp
	M			src/services/ampache/AmpacheServiceQueryMaker.h
	M			src/services/ampache/AmpacheSettings.cpp
	M			src/services/ampache/AmpacheSettings.h
	M			src/services/ampache/CMakeLists.txt
	M			src/services/ampache/LastfmInfoParser.cpp
	M			src/services/ampache/NewServerWidget.ui
	M			src/services/ampache/amarok_service_ampache.desktop
	M			src/services/gpodder/CMakeLists.txt
	M			src/services/gpodder/GpodderConfigWidget.ui
	M			src/services/gpodder/GpodderPodcastMeta.cpp
	M			src/services/gpodder/GpodderPodcastMeta.h
	M			src/services/gpodder/GpodderPodcastRequestHandler.cpp
	M			src/services/gpodder/GpodderPodcastRequestHandler.h
	M			src/services/gpodder/GpodderPodcastTreeItem.h
	M			src/services/gpodder/GpodderProvider.cpp
	M			src/services/gpodder/GpodderProvider.h
	M			src/services/gpodder/GpodderService.cpp
	M			src/services/gpodder/GpodderService.h
	M			src/services/gpodder/GpodderServiceConfig.cpp
	M			src/services/gpodder/GpodderServiceConfig.h
	M			src/services/gpodder/GpodderServiceModel.cpp
	M			src/services/gpodder/GpodderServiceModel.h
	M			src/services/gpodder/GpodderServiceSettings.cpp
	M			src/services/gpodder/GpodderServiceSettings.h
	M			src/services/gpodder/GpodderTagTreeItem.h
	M			src/services/gpodder/GpodderTreeItem.cpp
	M			src/services/gpodder/GpodderTreeItem.h
	M			src/services/gpodder/amarok_service_gpodder.desktop
	M			src/services/jamendo/CMakeLists.txt
	M			src/services/jamendo/JamendoDatabaseHandler.cpp
	M			src/services/jamendo/JamendoInfoParser.cpp
	M			src/services/jamendo/JamendoMeta.cpp
	M			src/services/jamendo/JamendoService.cpp
	M			src/services/jamendo/JamendoXmlParser.cpp
	M			src/services/jamendo/JamendoXmlParser.h
	M			src/services/jamendo/amarok_service_jamendo.desktop
	M			src/services/lastfm/AvatarDownloader.h
	M			src/services/lastfm/CMakeLists.txt
	M			src/services/lastfm/LastFmConfigWidget.ui
	M			src/services/lastfm/LastFmService.cpp
	M			src/services/lastfm/LastFmService.h
	M			src/services/lastfm/LastFmServiceCollection.cpp
	M			src/services/lastfm/LastFmServiceConfig.cpp
	M			src/services/lastfm/LastFmServiceConfig.h
	M			src/services/lastfm/LastFmServiceSettings.cpp
	M			src/services/lastfm/LastFmTreeModel.cpp
	M			src/services/lastfm/LastFmTreeView.cpp
	M			src/services/lastfm/LastFmTreeView.h
	M			src/services/lastfm/LoveTrackAction.cpp
	M			src/services/lastfm/ScrobblerAdapter.cpp
	M			src/services/lastfm/SimilarArtistsAction.cpp
	M			src/services/lastfm/SynchronizationAdapter.cpp
	M			src/services/lastfm/SynchronizationTrack.cpp
	M			src/services/lastfm/amarok_lastfm_shared_export.h
	M			src/services/lastfm/amarok_service_lastfm.desktop
	M			src/services/lastfm/biases/LastFmBias.cpp
	M			src/services/lastfm/biases/WeeklyTopBias.cpp
	M			src/services/lastfm/meta/LastFmMeta.cpp
	M			src/services/lastfm/meta/LastFmMeta.h
	M			src/services/lastfm/meta/LastFmMeta_p.h
	M			src/services/lastfm/meta/LastFmMultiPlayableCapability.cpp
	M			src/services/lastfm/meta/LastFmMultiPlayableCapability.h
	M			src/services/magnatune/CMakeLists.txt
	M			src/services/magnatune/MagnatuneActions.cpp
	M			src/services/magnatune/MagnatuneAlbumDownloader.cpp
	M			src/services/magnatune/MagnatuneAlbumDownloader.h
	M			src/services/magnatune/MagnatuneCollectionLocation.cpp
	M			src/services/magnatune/MagnatuneConfig.cpp
	M			src/services/magnatune/MagnatuneConfigWidget.ui
	M			src/services/magnatune/MagnatuneDatabaseHandler.cpp
	M			src/services/magnatune/MagnatuneDatabaseWorker.cpp
	M			src/services/magnatune/MagnatuneDownloadDialog.cpp
	M			src/services/magnatune/MagnatuneDownloadDialog.h
	M			src/services/magnatune/MagnatuneDownloadHandler.cpp
	M			src/services/magnatune/MagnatuneDownloadInfo.cpp
	M			src/services/magnatune/MagnatuneInfoParser.cpp
	M			src/services/magnatune/MagnatuneMeta.cpp
	M			src/services/magnatune/MagnatuneMeta.h
	M			src/services/magnatune/MagnatuneNeedUpdateWidget.cpp
	M			src/services/magnatune/MagnatuneRedownloadDialog.cpp
	M			src/services/magnatune/MagnatuneRedownloadDialog.h
	M			src/services/magnatune/MagnatuneRedownloadHandler.cpp
	M			src/services/magnatune/MagnatuneRedownloadHandler.h
	M			src/services/magnatune/MagnatuneSettingsModule.cpp
	M			src/services/magnatune/MagnatuneStore.cpp
	M			src/services/magnatune/MagnatuneStore.h
	M			src/services/magnatune/MagnatuneUrlRunner.cpp
	M			src/services/magnatune/MagnatuneXmlParser.cpp
	M			src/services/magnatune/amarok_service_magnatunestore.desktop
	M			src/services/mp3tunes/CMakeLists.txt
	M			src/services/mp3tunes/Mp3tunesConfig.cpp
	M			src/services/mp3tunes/Mp3tunesHarmonyHandler.cpp
	M			src/services/mp3tunes/Mp3tunesMeta.cpp
	M			src/services/mp3tunes/Mp3tunesMeta.h
	M			src/services/mp3tunes/Mp3tunesService.cpp
	M			src/services/mp3tunes/Mp3tunesServiceCollection.cpp
	M			src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp
	M			src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp
	M			src/services/mp3tunes/Mp3tunesSettingsModule.cpp
	M			src/services/mp3tunes/Mp3tunesWorkers.cpp
	M			src/services/mp3tunes/Mp3tunesWorkers.h
	M			src/services/mp3tunes/amarok_service_mp3tunes.desktop
	M			src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.cpp
	M			src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.h
	M			src/services/mp3tunes/harmonydaemon/main.cpp
	M			src/services/opmldirectory/AddOpmlWidget.ui
	M			src/services/opmldirectory/CMakeLists.txt
	M			src/services/opmldirectory/OpmlDirectoryInfoParser.cpp
	M			src/services/opmldirectory/OpmlDirectoryInfoParser.h
	M			src/services/opmldirectory/OpmlDirectoryMeta.h
	M			src/services/opmldirectory/OpmlDirectoryModel.cpp
	M			src/services/opmldirectory/OpmlDirectoryModel.h
	M			src/services/opmldirectory/OpmlDirectoryService.cpp
	M			src/services/opmldirectory/OpmlDirectoryService.h
	M			src/services/opmldirectory/OpmlDirectoryView.cpp
	M			src/services/opmldirectory/amarok_service_opmldirectory.desktop

Ported some services to Qt5/KF50d7ae231eea9Actions

Description

Details

Changes (133)Show All Changes

Very Large Commit

R181:0d7ae231eea9

CMakeLists.txt

cmake/modules/FindLibmygpo-qt.cmake

src/CMakeLists.txt

src/core/podcasts/PodcastImageFetcher.cpp

src/services/CMakeLists.txt

src/services/ampache/AddServerDialog.cpp

src/services/ampache/AddServerDialog.h

src/services/ampache/AmpacheAccountLogin.cpp

src/services/ampache/AmpacheAccountLogin.h

src/services/ampache/AmpacheConfig.cpp

src/services/ampache/AmpacheConfig.h

src/services/ampache/AmpacheMeta.h

src/services/ampache/AmpacheService.cpp

src/services/ampache/AmpacheService.h

src/services/ampache/AmpacheServiceCollection.cpp

src/services/ampache/AmpacheServiceCollection.h

src/services/ampache/AmpacheServiceQueryMaker.cpp

src/services/ampache/AmpacheServiceQueryMaker.h

src/services/ampache/AmpacheSettings.cpp

src/services/ampache/AmpacheSettings.h

src/services/ampache/CMakeLists.txt

src/services/ampache/LastfmInfoParser.cpp

src/services/ampache/NewServerWidget.ui

src/services/ampache/amarok_service_ampache.desktop

src/services/gpodder/CMakeLists.txt

src/services/gpodder/GpodderConfigWidget.ui

src/services/gpodder/GpodderPodcastMeta.cpp

src/services/gpodder/GpodderPodcastMeta.h

src/services/gpodder/GpodderPodcastRequestHandler.cpp

src/services/gpodder/GpodderPodcastRequestHandler.h

src/services/gpodder/GpodderPodcastTreeItem.h

src/services/gpodder/GpodderProvider.cpp

src/services/gpodder/GpodderProvider.h

src/services/gpodder/GpodderService.cpp

src/services/gpodder/GpodderService.h

src/services/gpodder/GpodderServiceConfig.cpp

src/services/gpodder/GpodderServiceConfig.h

src/services/gpodder/GpodderServiceModel.cpp

src/services/gpodder/GpodderServiceModel.h

src/services/gpodder/GpodderServiceSettings.cpp

src/services/gpodder/GpodderServiceSettings.h

src/services/gpodder/GpodderTagTreeItem.h

src/services/gpodder/GpodderTreeItem.cpp

src/services/gpodder/GpodderTreeItem.h

src/services/gpodder/amarok_service_gpodder.desktop

src/services/jamendo/CMakeLists.txt

src/services/jamendo/JamendoDatabaseHandler.cpp

src/services/jamendo/JamendoInfoParser.cpp

src/services/jamendo/JamendoMeta.cpp

src/services/jamendo/JamendoService.cpp

src/services/jamendo/JamendoXmlParser.cpp

src/services/jamendo/JamendoXmlParser.h

src/services/jamendo/amarok_service_jamendo.desktop

src/services/lastfm/AvatarDownloader.h

src/services/lastfm/CMakeLists.txt

src/services/lastfm/LastFmConfigWidget.ui

src/services/lastfm/LastFmService.cpp

src/services/lastfm/LastFmService.h

src/services/lastfm/LastFmServiceCollection.cpp

src/services/lastfm/LastFmServiceConfig.cpp

src/services/lastfm/LastFmServiceConfig.h

src/services/lastfm/LastFmServiceSettings.cpp

src/services/lastfm/LastFmTreeModel.cpp

src/services/lastfm/LastFmTreeView.cpp

src/services/lastfm/LastFmTreeView.h

src/services/lastfm/LoveTrackAction.cpp

src/services/lastfm/ScrobblerAdapter.cpp

src/services/lastfm/SimilarArtistsAction.cpp

src/services/lastfm/SynchronizationAdapter.cpp

src/services/lastfm/SynchronizationTrack.cpp

src/services/lastfm/amarok_lastfm_shared_export.h

src/services/lastfm/amarok_service_lastfm.desktop

src/services/lastfm/biases/LastFmBias.cpp

src/services/lastfm/biases/WeeklyTopBias.cpp

Ported some services to Qt5/KF5
0d7ae231eea9
Actions

Changes (133)
Show All Changes