Feed Advanced Search

Yesterday

kossebau added inline comments to D25798: Deprecated allowAsDefault.
Sat, Dec 7, 12:27 AM · Frameworks

Fri, Dec 6

kossebau committed R119:9ebe4c6c3d61: Use typo-fixed name of KF5QQC2DesktopStyle CMake config (authored by kossebau).
Use typo-fixed name of KF5QQC2DesktopStyle CMake config
Fri, Dec 6, 12:51 PM

Wed, Dec 4

kossebau committed R858:8b0372d2932e: Fix typo in name of installed CMake Config: Deskop->Desktop (authored by kossebau).
Fix typo in name of installed CMake Config: Deskop->Desktop
Wed, Dec 4, 12:37 PM
kossebau closed D23005: Fix typo in name of installed CMake Config: Deskop->Desktop.
Wed, Dec 4, 12:37 PM · Plasma
kossebau added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

Ran into this again this week, wondering why F1 shortcut was still working after assigning another shortcut (and then found there are mutiple instances).
Once I had a patch, it triggered memories, and indeed there is this one. 9c4b8e752937dd4523b04b57f237ac20c3bc3e45 should be the correct fix, by simply doing a createGUI(nullptr); call right after setupGUI(), so with a nullptr, an approach taking also in other KParts::MainWindow usages during startup, before going to actually load any document, e.g. on user request, and thus creating a kpart.

Wed, Dec 4, 12:35 PM
kossebau committed R32:ea0f0e5340fc: Merge branch '5.4' (authored by kossebau).
Merge branch '5.4'
Wed, Dec 4, 12:25 PM
kossebau committed R32:9c4b8e752937: Fix wrongly internally duplicated KHelpMenu instance (authored by kossebau).
Fix wrongly internally duplicated KHelpMenu instance
Wed, Dec 4, 12:25 PM
kossebau added a comment to D23005: Fix typo in name of installed CMake Config: Deskop->Desktop.

Np other opinion? Would then go with this in the next days...

Wed, Dec 4, 10:53 AM · Plasma

Tue, Dec 3

kossebau added inline comments to D25705: Deprecate KIO::pixmapForUrl.
Tue, Dec 3, 3:02 PM · Frameworks
kossebau committed R239:7b12a97500b5: Fix build: remove include of no longer used & provided kgesturemap_p.h (authored by kossebau).
Fix build: remove include of no longer used & provided kgesturemap_p.h
Tue, Dec 3, 12:47 AM

Mon, Dec 2

kossebau committed R64:3435f365e877: Update to latest kdevplatform API (authored by kossebau).
Update to latest kdevplatform API
Mon, Dec 2, 11:42 PM
kossebau added inline comments to D25511: Drop unused broken KGesture support.
Mon, Dec 2, 11:35 PM · Frameworks
kossebau committed R263:89670ad5e9d5: Unbreak last commit: still install normal headers as before (authored by kossebau).
Unbreak last commit: still install normal headers as before
Mon, Dec 2, 11:35 PM
kossebau committed R69:bdd2b4ba12e3: Update to latest kdevplatform API (authored by kossebau).
Update to latest kdevplatform API
Mon, Dec 2, 10:33 PM
kossebau committed R32:340a1236adac: Merge branch '5.4' (authored by kossebau).
Merge branch '5.4'
Mon, Dec 2, 9:29 PM
kossebau committed R32:2acd748268c1: Set QT_NO_FOREACH (authored by kossebau).
Set QT_NO_FOREACH
Mon, Dec 2, 9:29 PM
kossebau committed R32:ff367da634cc: More const methods (authored by kossebau).
More const methods
Mon, Dec 2, 9:29 PM
kossebau committed R877:f1b4967f0394: KDevelop 5.4.5 (authored by kossebau).
KDevelop 5.4.5
Mon, Dec 2, 3:52 PM
kossebau committed R32:f06c5fa39d3c: Merge branch '5.4' (authored by kossebau).
Merge branch '5.4'
Mon, Dec 2, 3:29 PM
kossebau committed R53:4ab11c20477f: Merge branch '5.4' (authored by kossebau).
Merge branch '5.4'
Mon, Dec 2, 3:27 PM
kossebau committed R52:b43dc8d0a670: Merge branch '5.4' (authored by kossebau).
Merge branch '5.4'
Mon, Dec 2, 3:25 PM
kossebau committed R32:d7a7965f60eb: appimage: bump qt/llvm to 5.12.6/9.0.0 (authored by kossebau).
appimage: bump qt/llvm to 5.12.6/9.0.0
Mon, Dec 2, 10:52 AM

Sun, Dec 1

kossebau committed R240:23d868a07712: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag (authored by kossebau).
ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag
Sun, Dec 1, 11:04 PM
kossebau closed D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag.
Sun, Dec 1, 11:04 PM · Build System, Frameworks
kossebau added a comment to D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag.

My head hurts a bit but I think I understand this now ;)

Sun, Dec 1, 11:04 PM · Build System, Frameworks
kossebau abandoned D12685: Fix calendar view: hide unused start/end time labels in day events list.

Sadly lost track of this, and no plans to pick this up again in the foreseeable future given other stuff to do, so discarding now to clean up the todo stack.

Sun, Dec 1, 5:29 PM · Plasma
kossebau abandoned D4672: Initial support for hookup of projects with general (web) services.

Not looked at it for some time, and no plans to look at it in the near future, so discarding for now, to clean up the todo stack.

Sun, Dec 1, 5:26 PM
kossebau committed R53:03f2909204ef: Set version number to 5.4.5 (authored by kossebau).
Set version number to 5.4.5
Sun, Dec 1, 5:24 PM
kossebau committed R52:c00de02f575e: Set version number to 5.4.5 (authored by kossebau).
Set version number to 5.4.5
Sun, Dec 1, 4:55 PM
kossebau committed R32:c243ad559bc0: appimage: bump kf/ka/plasma versions to 5.64.0/19.08.3/5.17.3 (authored by kossebau).
appimage: bump kf/ka/plasma versions to 5.64.0/19.08.3/5.17.3
Sun, Dec 1, 1:38 PM
kossebau committed R237:9044b4a3ade2: API dox: fixes (prevent linebreak after . in auto-brief begin, more @c) (authored by kossebau).
API dox: fixes (prevent linebreak after . in auto-brief begin, more @c)
Sun, Dec 1, 1:02 PM
kossebau added inline comments to D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation.
Sun, Dec 1, 12:47 PM · Frameworks
kossebau committed R271:887b1cd888d5: API dox: small fixes (misuse of @class, more @c, proper multi-line start) (authored by kossebau).
API dox: small fixes (misuse of @class, more @c, proper multi-line start)
Sun, Dec 1, 12:11 PM
kossebau committed R32:180312738f08: Set version number to 5.4.5 (authored by kossebau).
Set version number to 5.4.5
Sun, Dec 1, 11:43 AM

Sat, Nov 30

kossebau updated the summary of D23005: Fix typo in name of installed CMake Config: Deskop->Desktop.
Sat, Nov 30, 6:38 PM · Plasma
kossebau updated the diff for D23005: Fix typo in name of installed CMake Config: Deskop->Desktop.
  • keep old CMake Config files installed
  • no longer create unused version.h file
Sat, Nov 30, 6:37 PM · Plasma
kossebau added a comment to D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path.

Hmmpf, indeed. I forgot about the objection I had here :)

Are you interested in testing my suggested fix, since you seemed to have a testcase for this code?

Sat, Nov 30, 12:44 PM · Frameworks
kossebau accepted D25626: Fix EcmGenerateExportHeader tests on Windows.

Yay, thanks for fixing this. Not sure if if(MSVC) is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the dark side now and then. :)
Otherwise +1 for this.

Sat, Nov 30, 12:22 PM · Build System, Frameworks

Fri, Nov 29

kossebau added a comment to D23550: CMake config files: use as min dep version the Qt version we built against.

Just, the built binary no longer has that theoretical minimum dependency, it needs at least the Qt version the very instance of kcoreaddons was built against.

Fri, Nov 29, 9:24 PM · Frameworks
kossebau added a comment to D23550: CMake config files: use as min dep version the Qt version we built against.

ping :) No-one any opinion?

Sure :)
-1. The Config file is supposed to look for the lowest supported version.

Fri, Nov 29, 8:58 PM · Frameworks
kossebau abandoned D21603: QXmlSimpleReader uses qt-project.org as namespace these days.

Changes committed meanwhile by 418bb8512006 & a4907aac93f3

Fri, Nov 29, 6:47 PM
kossebau abandoned D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale.

Sadly lost track of things, and no plans to look soon again at it, so cleaning up from stack for now.

Fri, Nov 29, 6:43 PM · Frameworks
kossebau added a comment to D23550: CMake config files: use as min dep version the Qt version we built against.

ping :) No-one any opinion?

Fri, Nov 29, 6:40 PM · Frameworks
kossebau abandoned D21769: Use directory listing qmldir format for private modules used by dir import.

Seems there is no interest.

Fri, Nov 29, 6:40 PM · Frameworks
kossebau added a comment to D23005: Fix typo in name of installed CMake Config: Deskop->Desktop.

Something to consider in time for Plasma 5.18, post 5.17.5 and before 5.17.90)

Fri, Nov 29, 6:38 PM · Plasma
kossebau updated the diff for D22778: Restore option to create a Qt Designer plugin.

Update to latest master

Fri, Nov 29, 6:33 PM · Plasma
kossebau added reviewers for D22778: Restore option to create a Qt Designer plugin: Plasma, davidedmundson, mart.
Fri, Nov 29, 6:32 PM · Plasma
kossebau abandoned D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path.

Solved by D24349 meanwhile in the same way.

Fri, Nov 29, 6:29 PM · Frameworks
kossebau abandoned D19939: Avoid failing installation via temporary dir due to file name clashes.

Not having looked more at this for some months, and will not do in foreseeable future, so abandoning to clean up stack.

Fri, Nov 29, 6:20 PM · Frameworks

Thu, Nov 28

kossebau added a comment to D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

Hm, only noticed now that this actually has an unwanted sideeffects: it triggers deprecation warnings for all deprecated warning also inside each library itself. Which is not what one wants.

Thu, Nov 28, 1:02 PM · Build System, Frameworks
kossebau requested review of D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag.
Thu, Nov 28, 12:49 PM · Build System, Frameworks

Wed, Nov 27

kossebau committed R499:bf41d3dc33f7: kpackage has kdoctools as (optional) dep (authored by kossebau).
kpackage has kdoctools as (optional) dep
Wed, Nov 27, 12:56 PM
kossebau committed R290:d6a6c210b0d1: Remove -std=c++0x flag and duplicated -Wall flag (authored by kossebau).
Remove -std=c++0x flag and duplicated -Wall flag
Wed, Nov 27, 12:12 PM
kossebau closed D25563: Remove -std=c++0x flag and duplicated -Wall flag.
Wed, Nov 27, 12:12 PM · Frameworks
kossebau requested review of D25563: Remove -std=c++0x flag and duplicated -Wall flag.
Wed, Nov 27, 11:34 AM · Frameworks
kossebau added a comment to D25311: Add KColumnHeadersProxyModel.

Two more nitpicks while this has my attention (sadly no time/idea to comment on the general usefulness) :)

Wed, Nov 27, 11:19 AM · Frameworks
kossebau added inline comments to D25545: Rename signal for avoiding overload signal.
Wed, Nov 27, 10:44 AM · Frameworks
kossebau added a comment to D25561: Remove unused signal we can use directly "signal(const QUrl&).

Looks correct from deprecation-markup POV. Did you do a test build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.65.0, to check if any tests or examples still use the deprecated signals and need some additions of #if KWIDGETSADDONS_ENABLE_DEPRECATED_SINCE(5, 65) in places?

Wed, Nov 27, 10:20 AM · Frameworks
kossebau added a comment to D25078: Replace deprecated KConfigDialogManager::changedMap with property in the class definition.

You rather want to add a NOTIFY textEdited to the property definition of text for class EquationEdit, at https://phabricator.kde.org/source/kmplot/browse/master/kmplot/equationedit.h$52 :)

Wed, Nov 27, 12:08 AM · KDE Edu

Tue, Nov 26

kossebau added a comment to D25545: Rename signal for avoiding overload signal.

Looks good to me. Friedrich, what did we conclude about deprecating signals?

Tue, Nov 26, 11:36 PM · Frameworks
kossebau committed R32:8c9f26dcbc83: Port away from KRecursiveFilterProxyModel (authored by kossebau).
Port away from KRecursiveFilterProxyModel
Tue, Nov 26, 10:46 PM
kossebau added inline comments to D25311: Add KColumnHeadersProxyModel.
Tue, Nov 26, 5:23 PM · Frameworks
kossebau added a comment to D25546: Deprecate KRecursiveFilterProxyModel.

Looks good, besides nitpicks :)

Tue, Nov 26, 4:29 PM · KF6, Frameworks

Sun, Nov 24

kossebau committed R32:faded356b6af: shell: use KAboutPluginDialog in LoadedPluginsDialog (authored by kossebau).
shell: use KAboutPluginDialog in LoadedPluginsDialog
Sun, Nov 24, 4:16 PM
kossebau added a comment to D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum.

IMHO such idea notes should also be put into the source file or, better, a separate TODO file in the toplevel source, not the header (which is going to be deployed as part of devel-packages), as this note is uninteresting to users of current KXMLGUIClient.

Sun, Nov 24, 1:36 PM · Frameworks
kossebau edited reviewers for D24349: More fixes to compile without implicit conversion from ASCII/ByteArray, added: Frameworks; removed: kossebau.
Sun, Nov 24, 1:25 PM · Frameworks
kossebau committed R295:918978c7e26e: KPluginSelector: use new KAboutPluginDialog (authored by kossebau).
KPluginSelector: use new KAboutPluginDialog
Sun, Nov 24, 12:59 PM
kossebau closed D25059: KPluginSelector: use new KAboutPluginDialog.
Sun, Nov 24, 12:59 PM · Frameworks
kossebau committed R244:e8f558f8b2c7: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog (authored by kossebau).
Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog
Sun, Nov 24, 12:53 PM
kossebau closed D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog.
Sun, Nov 24, 12:53 PM · Frameworks
kossebau committed R263:415402081d92: Add KAboutPluginDialog, to be used with KPluginMetaData (authored by kossebau).
Add KAboutPluginDialog, to be used with KPluginMetaData
Sun, Nov 24, 12:40 PM
kossebau closed D25058: Add KAboutPluginDialog, to be used with KPluginMetaData.
Sun, Nov 24, 12:40 PM · Frameworks

Sat, Nov 23

kossebau accepted D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu.

Seems fine by pure patch reading.

Sat, Nov 23, 11:08 PM · Frameworks
kossebau accepted D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem.

For a backport, one could perhaps do this after the includes:

#fndef KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE
#ifndef KWINDOWSYSTEM_NO_DEPRECATED
#define KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE(x, y) 1
#else
#define KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE(x, y) 0
#endif
#endif

Otherwise seems fine with me from pure patch reading.

Sat, Nov 23, 10:57 PM · Plasma
kossebau committed R958:17a22ac1605f: build.kde.org syncs dep dot files to $HOME/depdiagram-output now (authored by kossebau).
build.kde.org syncs dep dot files to $HOME/depdiagram-output now
Sat, Nov 23, 8:19 PM
kossebau added a comment to D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu.

That should be upcoming 5.65 here though, not 5.64.
Moving things into visibility-protection guards of recent versions will break things for people who used DISABLE_DEPRECATED_BEFORE_AND_AT after having properly checked their source is properly building against released versions with the value used for that flag. See also https://mail.kde.org/pipermail/kde-frameworks-devel/2019-November/096701.html

Sat, Nov 23, 12:28 PM · Frameworks

Thu, Nov 21

kossebau added inline comments to D25444: Unify KPageDialog margin handling into KPageDialog itself.
Thu, Nov 21, 5:08 PM · Frameworks

Wed, Nov 20

kossebau added a comment to D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.

Ah, EXCLUDE_DEPRECATED_BEFORE_AND_AT is not yet available with KIO (compare the TODO next to the ecm_generate_export_header call).
So as result also the BUILD macros are not available. Using instead the ENABLE macros in the sources of the library instead does not make that much sense, they will be never triggerd to evaluate to FALSE.

Wed, Nov 20, 10:01 PM · Frameworks
kossebau added inline comments to D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.
Wed, Nov 20, 9:55 PM · Frameworks
kossebau added inline comments to R271:856ddb707268: KDBusService: improve documentation to handle empty argument list correctly..
Wed, Nov 20, 9:51 PM
kossebau added inline comments to R271:856ddb707268: KDBusService: improve documentation to handle empty argument list correctly..
Wed, Nov 20, 2:32 PM
kossebau committed R263:3d93d4611042: API dox: small fixes for KKeySequenceWidget (authored by kossebau).
API dox: small fixes for KKeySequenceWidget
Wed, Nov 20, 2:26 PM
kossebau updated the diff for D25058: Add KAboutPluginDialog, to be used with KPluginMetaData.

Update to first review by @dfaure

Wed, Nov 20, 1:16 PM · Frameworks
kossebau added inline comments to D25058: Add KAboutPluginDialog, to be used with KPluginMetaData.
Wed, Nov 20, 1:16 PM · Frameworks

Tue, Nov 19

kossebau added a comment to D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while building FOO itself, right? Either magically here, or manually in every module...

Tue, Nov 19, 1:47 PM · Build System, Frameworks
kossebau added a comment to D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

Hm, only noticed now that this actually has an unwanted sideeffects: it triggers deprecation warnings for all deprecated warning also inside each library itself. Which is not what one wants.

Tue, Nov 19, 1:39 PM · Build System, Frameworks
kossebau added a comment to D25401: Fix deprecation syntax in ktcpsocket.h.

One thing I saw with the Qt deprecation tags is that deprecation attributes were only added to constructor calls, not the class itself.
Which to me made some sense, as one should be warned when creating instances of that class. But once you are passed an instance due to other reasons, being warned about furher calls on the instance makes no real sense, as one has to use the instance now that it exists.
In the initial set of patches to KF with the new deprecation macros I also did it like that for deprecated classes, added the warning macros only to constructor or other generation functions, not next to the class keyword.

Tue, Nov 19, 1:29 PM · Frameworks
kossebau committed R1045:b30506ff2b48: Add org.kde namespace to desktop file (authored by kossebau).
Add org.kde namespace to desktop file
Tue, Nov 19, 8:33 AM
kossebau committed R1045:25bffed5906b: Set X-DBUS-StartupType to Unique, to not confuse KToolInvocation (authored by kossebau).
Set X-DBUS-StartupType to Unique, to not confuse KToolInvocation
Tue, Nov 19, 8:33 AM
kossebau committed R1045:e6b5c04499b5: Set window icon (authored by kossebau).
Set window icon
Tue, Nov 19, 8:23 AM
kossebau committed R1045:8f7fb38f60bc: Set KI18n app translation domain (authored by kossebau).
Set KI18n app translation domain
Tue, Nov 19, 8:23 AM
kossebau committed R1045:5338c30db31d: Do not duplicate work of KAboutData::setupCommandLine (authored by kossebau).
Do not duplicate work of KAboutData::setupCommandLine
Tue, Nov 19, 8:23 AM
kossebau committed R1045:645445e9afdf: Setup D-Bus instance only after cmld arg handling (authored by kossebau).
Setup D-Bus instance only after cmld arg handling
Tue, Nov 19, 8:23 AM
kossebau committed R1045:ac7d1da690b7: Use non-deprecated KDEInstallDirs variables (authored by kossebau).
Use non-deprecated KDEInstallDirs variables
Tue, Nov 19, 8:23 AM
kossebau committed R1045:36723c0cc52a: Remove unneeded include dirs ( (authored by kossebau).
Remove unneeded include dirs (
Tue, Nov 19, 8:23 AM
kossebau committed R1045:b1bec2f07f94: Include KDE CMake settings macros as first (authored by kossebau).
Include KDE CMake settings macros as first
Tue, Nov 19, 8:23 AM

Mon, Nov 18

kossebau committed R275:13a039441fdb: KNumberModel: gracefully handle a stepSize of 0 (authored by kossebau).
KNumberModel: gracefully handle a stepSize of 0
Mon, Nov 18, 10:38 AM
kossebau closed D25364: KNumberModel: gracefully handle a stepSize of 0.
Mon, Nov 18, 10:38 AM · Frameworks
kossebau requested review of D25364: KNumberModel: gracefully handle a stepSize of 0.
Mon, Nov 18, 9:35 AM · Frameworks
kossebau committed R275:45483fe515e1: Mark unused arguments with Q_UNUSED (authored by kossebau).
Mark unused arguments with Q_UNUSED
Mon, Nov 18, 9:03 AM