Differential D28826

fixup(messagecomposer): use const argument for setSigningKeys.
ClosedPublic
Actions

Authored by knauss on Apr 14 2020, 2:15 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R94:bd848634e256: fixup(messagecomposer): use const argument for setSigningKeys.
Summary

signingKeys are just an input and won't modified by the job itself.

Test Plan

run autotests.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss created this revision.Apr 14 2020, 2:15 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 14 2020, 2:15 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss requested review of this revision.Apr 14 2020, 2:15 PM
mlaurent accepted this revision.Apr 15 2020, 5:18 AM
This revision is now accepted and ready to land.Apr 15 2020, 5:18 AM
Closed by commit R94:bd848634e256: fixup(messagecomposer): use const argument for setSigningKeys. (authored by knauss). · Explain WhyApr 15 2020, 3:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80212

View Options

messagecomposer/autotests/signandencrypttest.cpp

Loading...
View Options

messagecomposer/autotests/signencrypttest.cpp

Loading...
View Options

messagecomposer/autotests/signjobtest.cpp

Loading...
View Options

messagecomposer/src/job/signencryptjob.h

Loading...
View Options

messagecomposer/src/job/signencryptjob.cpp

Loading...
View Options

messagecomposer/src/job/signjob.h

Loading...
View Options

messagecomposer/src/job/signjob.cpp

Loading...