Differential D28449

[messagecomposer]: Implement protected headers for SignJob. T742
ClosedPublic
Actions

Authored by knauss on Mar 31 2020, 12:57 AM.

Tags

Subscribers

mlaurent, kde-pim

Details

Reviewers

Group Reviewers

Maniphest Tasks

T742: Add Protected Header support

Commits

R94:c20f5956b300: [messagecomposer]: Implement protected headers for SignJob. T742

Test Plan

run autotests successfully

Diff Detail

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

knauss created this revision.Mar 31 2020, 12:57 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 31 2020, 12:57 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

Harbormaster completed remote builds in B24497: Diff 78942.Mar 31 2020, 12:57 AM

knauss requested review of this revision.Mar 31 2020, 12:57 AM

knauss added a task: T742: Add Protected Header support.Mar 31 2020, 1:00 AM

knauss added a reviewer: KDE PIM.

mlaurent added a subscriber: mlaurent.Mar 31 2020, 5:10 AM

mlaurent added inline comments.

messagecomposer/src/job/signjob.cpp
125	coding style remove <space> before "("

cleanup.

Harbormaster completed remote builds in B24732: Diff 79298.Apr 4 2020, 2:24 PM

cleanup.

Harbormaster completed remote builds in B24995: Diff 79735.Apr 9 2020, 8:48 PM

mlaurent requested changes to this revision.Apr 11 2020, 12:44 PM

mlaurent added inline comments.

messagecomposer/src/job/signjob.cpp
178	auto cjob = dynamic_cast<ContentJobBase *>(job); Q_ASSERT(cjob); pjob->setcontent(cjob->content()); > we use directly cjob.

This revision now requires changes to proceed.Apr 11 2020, 12:44 PM

cleanup - do cast only one time.

Harbormaster completed remote builds in B25111: Diff 79937.Apr 12 2020, 3:41 PM

mlaurent accepted this revision.Apr 13 2020, 7:53 AM

This revision is now accepted and ready to land.Apr 13 2020, 7:53 AM

Closed by commit R94:c20f5956b300: [messagecomposer]: Implement protected headers for SignJob. T742 (authored by knauss). · Explain WhyApr 14 2020, 2:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			messagecomposer/autotests/signjobtest.h (2 lines)
M			messagecomposer/autotests/signjobtest.cpp (62 lines)
M			messagecomposer/src/composer/composer.cpp (3 lines)
M			messagecomposer/src/job/signjob.h (5 lines)
M			messagecomposer/src/job/signjob.cpp (59 lines)

Diff 80102

messagecomposer/autotests/signjobtest.h

Loading...

messagecomposer/autotests/signjobtest.cpp

Loading...

messagecomposer/src/composer/composer.cpp

Loading...

messagecomposer/src/job/signjob.h

Loading...

messagecomposer/src/job/signjob.cpp

Loading...