knauss retitled this revision from WIP: [messagecomposer]: Implement protected headers for SignEncryptJob. to [messagecomposer]: Implement protected headers for SignEncryptJob..Apr 8 2020, 6:54 PM

knauss added a reviewer: KDE PIM.

cleanup.

Harbormaster completed remote builds in B25110: Diff 79936.Apr 12 2020, 3:40 PM

mlaurent requested changes to this revision.Apr 14 2020, 12:03 PM

mlaurent added a subscriber: mlaurent.

mlaurent added inline comments.

messagecomposer/autotests/signencrypttest.cpp
2	same
100	QVERIFY(! ... )
111	const QStringList recipient = {...};
187	endsWith('\n') ?
messagecomposer/autotests/signencrypttest.h
2	why removed old copyright ?

This revision now requires changes to proceed.Apr 14 2020, 12:03 PM

knauss marked 5 inline comments as done.Apr 14 2020, 2:17 PM

knauss added inline comments.

messagecomposer/autotests/signencrypttest.cpp
2	Well git see this file as a copy of signandencrypt.* but nearly nothing it taken for that file.
messagecomposer/autotests/signencrypttest.h
2	Well git see this file as a copy of signandencrypt.* but nearly nothing it taken for that file.

cleanup tests.

Sorry arc does not want to work, so I have do a manual upload of the diff.

knauss added a task: T11621: Send encrypted Mail headers.Apr 14 2020, 2:34 PM

mlaurent accepted this revision.Apr 15 2020, 5:17 AM

mlaurent added inline comments.

messagecomposer/autotests/signencrypttest.h
2	Ah ok in phabricator it shows as modified file.

This revision is now accepted and ready to land.Apr 15 2020, 5:17 AM

Closed by commit R94:84ff7e94fd30: [messagecomposer]: Implement protected headers for SignEncryptJob. (authored by knauss). · Explain WhyApr 15 2020, 3:27 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			messagecomposer/autotests/signencrypttest.h (5 lines)
M			messagecomposer/autotests/signencrypttest.cpp (171 lines)
M			messagecomposer/src/composer/composer.cpp (1 line)
M			messagecomposer/src/job/signencryptjob.h (7 lines)
M			messagecomposer/src/job/signencryptjob.cpp (69 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78943	e32e628		Mar 31 2020, 12:58 AM	★	★
Diff 2	79299	ab5d5a7	cleanup.	Apr 4 2020, 2:24 PM	★	★
Diff 3	79664	602217f	it is now ready for review.	Apr 8 2020, 6:53 PM	★	★
Diff 4	79936	2d1b128	cleanup.	Apr 12 2020, 3:40 PM	★	★
Diff 5	80117			Apr 14 2020, 2:28 PM	★	★
Diff 6	80208	93a16b4	R94:84ff7e94fd305f032b13d1b1c91cfa6bf0fcb5c0	Apr 15 2020, 3:21 PM	★	★

[messagecomposer]: Implement protected headers for SignEncryptJob.
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 80208

messagecomposer/autotests/signencrypttest.h

messagecomposer/autotests/signencrypttest.cpp

messagecomposer/src/composer/composer.cpp

messagecomposer/src/job/signencryptjob.h

messagecomposer/src/job/signencryptjob.cpp

[messagecomposer]: Implement protected headers for SignEncryptJob.ClosedPublicActions