Differential D20439

Fix alignment boundary
Needs ReviewPublic
Actions

Authored by tcanabrava on Apr 10 2019, 3:07 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Summary

clang warning about 7 bytes alignment boundary for this struct

Diff Detail

Repository
R319 Konsole
Branch
simplify_character_width
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10701
Build 10719: arc lint + arc unit
tcanabrava created this revision.Apr 10 2019, 3:07 PM
Restricted Application added a project: Konsole. · View Herald TranscriptApr 10 2019, 3:07 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Apr 10 2019, 3:07 PM
hindenburg added a comment.Apr 18 2019, 1:03 AM

This doesn't build - all the initializing code has to be re-arranged.

mglb added a subscriber: mglb.Apr 18 2019, 11:04 PM

width type can be changed to int in order to fix this without reordering members.
The file is generated, so this should be changed also in the template.

hindenburg added a comment.Jul 11 2020, 7:15 PM

Any interesting in updating this or moving to invent mR?

Revision Contents
Changeset List

PathPackages
Msrc/CharacterWidth.cpp (2 lines)

Diff 55909

View Options

src/CharacterWidth.cpp

Loading...