moved to invent.kde.org

Had the first scenario in mind. I would use that to move yakuake around when I want it temporarily on a different screen , but when I reopen yakuake it should just honor the original setting value (Should note here that I use yakuake with the "Keep open when losing focus" option). So if Screen 1 is set open on Screen 1 again and if At Mouse Location is set open at mouse location again.

Having a shortcut to move yakuake around seems quite useful, but I'm not a fan that this overwrites the "Open on screen" setting.
Maybe making this behavior optional?

Ping?

• Update for final version of InterfaceV2
• Remove unecessary include

• fix indentation

Show last entry of history if current display value is not the last history value

• Reraise the session also if a other tab has been renamed

• Update for final version of InterfaceV2

If you effectively compile with the InterfaceV2 enabled and an updated kde_terminal_interface.h it should pass. Only issue I had is that the tests don't load the konsolepart.so from the build dir directly which means the actually loaded konsolepart.so is still the old version. This results in the test failure.

• resolve moc compile error
• convert tabs to spaces

Add some tests for TerminalInterfaceV2

Update to the new terminalinterfacev2 version
Use TerminalInterfacV2 depending on kf5 version (>= 5.60.0)

Oh sry, I wasn't aware of that.

ping

ping?

In D20170#469080, @hindenburg wrote:

I believe that once the KParts code is committed to frameworks, Konsole needs to add checks the frameworks version. I'd rather not require the new framework version for all of Konsole, just this new code.

• Remove install of profileinterface

Move the interface to TerminalInterfaceV2

Ping

change KDEPARTS to KPARTS

Remove getProfilePath and remove get prefixes

wrt getProfilePath: what if an application does not store a profile as single filename, for example as directory, or even stored e.g. in a DB? maybe it would be better to have this as property of a profile

Yeah Konsole Profiles seem to already have a path property in the profile implementation. So gonna remove this.

Move the profile support to different class

Just tried this patch and it seems to work just fine for me.

No worries nobody dies without this patch ;-)
And of course you can use my real name.
Thanks for the reviewing :)

Remove QMainWindow include

bump ;)

Fixed indentation

Sure. This patch was just something I've been using for a while now and found it very useful. So I just put it out there after seeing that rather old bug report from 2003.
Update: Made the bool field private and use getter/setter.

Sry messed up with arc ;)

Replace Q_DECL_OVERRIDE with override.
Make the Quit button respect the proper quitting method.
Quit the application if the close event has been accepted by the main window
instead of closing when the last window is closed.

Thanks. I don't have a dev account (yet ;) ).

manimax3@hotmail.de

actually change the titlecase issue

Anyone knows an additional reviewer I could add to get this patch going?

Changed the text label of the checkbox.

I've seen similiar things to the "K" indicator marker, might be useful to know whether you already pressed equal or not, so you don't mess up your result.