mschiller (Maximilian Schiller)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 10 2018, 6:52 PM (66 w, 3 d)
Availability
Available

Recent Activity

Thu, Jul 4

mschiller updated the diff for D21631: Raise the active session after renaming a tab.
  • Reraise the session also if a other tab has been renamed
Thu, Jul 4, 2:05 PM

Jun 19 2019

mschiller added reviewers for D21631: Raise the active session after renaming a tab: Yakuake, KDE Applications.
Jun 19 2019, 7:09 PM

Jun 11 2019

mschiller updated the diff for D20185: Open New Tabs in the same directory option.
  • Update for final version of InterfaceV2
Jun 11 2019, 5:55 PM

Jun 6 2019

mschiller requested review of D21631: Raise the active session after renaming a tab.
Jun 6 2019, 5:51 PM

Jun 4 2019

mschiller added a comment to D20170: Implement the new interface of TerminalInterface for profile handling.

If you effectively compile with the InterfaceV2 enabled and an updated kde_terminal_interface.h it should pass. Only issue I had is that the tests don't load the konsolepart.so from the build dir directly which means the actually loaded konsolepart.so is still the old version. This results in the test failure.

Jun 4 2019, 4:33 PM · Konsole
mschiller updated the diff for D20170: Implement the new interface of TerminalInterface for profile handling.
  • resolve moc compile error
  • convert tabs to spaces
Jun 4 2019, 4:33 PM · Konsole

Jun 3 2019

mschiller updated the diff for D20170: Implement the new interface of TerminalInterface for profile handling.

Add some tests for TerminalInterfaceV2

Jun 3 2019, 7:08 PM · Konsole

Jun 2 2019

mschiller updated the diff for D20170: Implement the new interface of TerminalInterface for profile handling.

Update to the new terminalinterfacev2 version
Use TerminalInterfacV2 depending on kf5 version (>= 5.60.0)

Jun 2 2019, 4:51 PM · Konsole
mschiller added a comment to D20169: Add profile support interface for TerminalInterface.

Oh sry, I wasn't aware of that.

Jun 2 2019, 2:58 PM · Frameworks
mschiller added a comment to D20169: Add profile support interface for TerminalInterface.

ping

Jun 2 2019, 10:36 AM · Frameworks
mschiller added a comment to D16280: Update display after incrementing history index.

ping?

Jun 2 2019, 10:36 AM

May 27 2019

mschiller added a comment to D20170: Implement the new interface of TerminalInterface for profile handling.

I believe that once the KParts code is committed to frameworks, Konsole needs to add checks the frameworks version. I'd rather not require the new framework version for all of Konsole, just this new code.

May 27 2019, 11:25 AM · Konsole

May 14 2019

mschiller updated the diff for D20169: Add profile support interface for TerminalInterface.
  • Remove install of profileinterface
May 14 2019, 5:41 PM · Frameworks
mschiller updated the diff for D20169: Add profile support interface for TerminalInterface.

Move the interface to TerminalInterfaceV2

May 14 2019, 5:39 PM · Frameworks

May 10 2019

mschiller added a comment to D20169: Add profile support interface for TerminalInterface.

Ping

May 10 2019, 7:21 AM · Frameworks

Apr 26 2019

mschiller committed R369:8f9844b8dbb4: Remove forcing the initial dir to QDir::homePath() (authored by mschiller).
Remove forcing the initial dir to QDir::homePath()
Apr 26 2019, 3:46 PM
mschiller closed D20117: Remove forcing the initial dir to QDir::homePath().
Apr 26 2019, 3:46 PM
mschiller added a reviewer for D20117: Remove forcing the initial dir to QDir::homePath(): KDE Applications.
Apr 26 2019, 9:36 AM

Apr 22 2019

mschiller updated the diff for D20169: Add profile support interface for TerminalInterface.

change KDEPARTS to KPARTS

Apr 22 2019, 7:39 AM · Frameworks
mschiller updated the diff for D20169: Add profile support interface for TerminalInterface.

Remove getProfilePath and remove get prefixes

Apr 22 2019, 7:36 AM · Frameworks

Apr 21 2019

mschiller added a comment to D20169: Add profile support interface for TerminalInterface.

wrt getProfilePath: what if an application does not store a profile as single filename, for example as directory, or even stored e.g. in a DB? maybe it would be better to have this as property of a profile

Yeah Konsole Profiles seem to already have a path property in the profile implementation. So gonna remove this.

Apr 21 2019, 9:06 PM · Frameworks
mschiller updated the test plan for D20117: Remove forcing the initial dir to QDir::homePath().
Apr 21 2019, 7:01 PM
mschiller updated the diff for D20169: Add profile support interface for TerminalInterface.

Move the profile support to different class

Apr 21 2019, 6:47 PM · Frameworks
mschiller updated the summary of D20169: Add profile support interface for TerminalInterface.
Apr 21 2019, 6:35 PM · Frameworks

Apr 2 2019

mschiller updated the summary of D20185: Open New Tabs in the same directory option.
Apr 2 2019, 1:28 PM

Apr 1 2019

mschiller added reviewers for D20185: Open New Tabs in the same directory option: Yakuake, hein, KDE Applications.
Apr 1 2019, 8:13 PM
mschiller requested review of D20185: Open New Tabs in the same directory option.
Apr 1 2019, 8:13 PM
mschiller added a dependent revision for D20170: Implement the new interface of TerminalInterface for profile handling: D20185: Open New Tabs in the same directory option.
Apr 1 2019, 8:13 PM · Konsole
mschiller added a dependent revision for D20117: Remove forcing the initial dir to QDir::homePath(): D20185: Open New Tabs in the same directory option.
Apr 1 2019, 8:13 PM
mschiller added a reviewer for D20170: Implement the new interface of TerminalInterface for profile handling: Konsole.
Apr 1 2019, 3:29 PM · Konsole
mschiller added a dependent revision for D20169: Add profile support interface for TerminalInterface: D20170: Implement the new interface of TerminalInterface for profile handling.
Apr 1 2019, 3:28 PM · Frameworks
mschiller requested review of D20170: Implement the new interface of TerminalInterface for profile handling.
Apr 1 2019, 3:28 PM · Konsole
mschiller added a reviewer for D20169: Add profile support interface for TerminalInterface: hindenburg.
Apr 1 2019, 3:24 PM · Frameworks
mschiller requested review of D20169: Add profile support interface for TerminalInterface.
Apr 1 2019, 3:23 PM · Frameworks

Mar 30 2019

mschiller added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

Just tried this patch and it seems to work just fine for me.

Mar 30 2019, 3:02 AM · Konsole

Mar 29 2019

mschiller requested review of D20117: Remove forcing the initial dir to QDir::homePath().
Mar 29 2019, 8:20 PM

Jan 24 2019

mschiller committed R369:fb5a395befb4: Add shortcuts as default shortcuts (authored by mschiller).
Add shortcuts as default shortcuts
Jan 24 2019, 3:00 PM
mschiller closed D18500: Add shortcuts as default shortcuts.
Jan 24 2019, 3:00 PM
mschiller requested review of D18500: Add shortcuts as default shortcuts.
Jan 24 2019, 2:04 PM

Oct 17 2018

mschiller requested review of D16280: Update display after incrementing history index.
Oct 17 2018, 6:25 PM
mschiller added a comment to D15535: Use KMainWindow instead of QMainWindow.

No worries nobody dies without this patch ;-)
And of course you can use my real name.
Thanks for the reviewing :)

Oct 17 2018, 11:08 AM

Oct 9 2018

mschiller updated the diff for D15535: Use KMainWindow instead of QMainWindow.

Remove QMainWindow include

Oct 9 2018, 2:24 PM
mschiller added a comment to D15535: Use KMainWindow instead of QMainWindow.

bump ;)

Oct 9 2018, 10:53 AM

Oct 2 2018

mschiller updated the diff for D15463: Corrected behaviour on repeated pressing of operator buttons.

Fixed indentation

Oct 2 2018, 8:11 AM

Sep 23 2018

mschiller requested review of D15535: Use KMainWindow instead of QMainWindow.
Sep 23 2018, 2:05 PM
mschiller updated the diff for D15463: Corrected behaviour on repeated pressing of operator buttons.

Sure. This patch was just something I've been using for a while now and found it very useful. So I just put it out there after seeing that rather old bug report from 2003.
Update: Made the bool field private and use getter/setter.

Sep 23 2018, 2:00 PM
mschiller abandoned D15710: pressing operator buttons twice fix.

Sry messed up with arc ;)

Sep 23 2018, 1:56 PM
mschiller requested review of D15710: pressing operator buttons twice fix.
Sep 23 2018, 1:55 PM

Sep 17 2018

mschiller updated the diff for D15535: Use KMainWindow instead of QMainWindow.

Replace Q_DECL_OVERRIDE with override.
Make the Quit button respect the proper quitting method.
Quit the application if the close event has been accepted by the main window
instead of closing when the last window is closed.

Sep 17 2018, 9:37 AM

Sep 16 2018

mschiller added a comment to D15535: Use KMainWindow instead of QMainWindow.

Thanks. I don't have a dev account (yet ;) ).

Sep 16 2018, 8:32 AM

Sep 15 2018

mschiller updated the test plan for D15535: Use KMainWindow instead of QMainWindow.
Sep 15 2018, 2:38 PM
mschiller requested review of D15535: Use KMainWindow instead of QMainWindow.
Sep 15 2018, 2:38 PM

Sep 12 2018

mschiller requested review of D15463: Corrected behaviour on repeated pressing of operator buttons.
Sep 12 2018, 8:25 PM
mschiller added a member for Bugsquad: mschiller.
Sep 12 2018, 5:18 PM

Aug 16 2018

mschiller added a comment to D12099: Repeat last action when pressing "=" or Enter.

manimax3@hotmail.de

Aug 16 2018, 9:00 PM

Jun 30 2018

mschiller updated the diff for D12099: Repeat last action when pressing "=" or Enter.

actually change the titlecase issue

Jun 30 2018, 4:28 PM

Jun 29 2018

mschiller added a comment to D12099: Repeat last action when pressing "=" or Enter.

Anyone knows an additional reviewer I could add to get this patch going?

Jun 29 2018, 3:41 PM

Apr 11 2018

mschiller updated the diff for D12099: Repeat last action when pressing "=" or Enter.
Apr 11 2018, 10:58 AM
mschiller updated the diff for D12099: Repeat last action when pressing "=" or Enter.

Changed the text label of the checkbox.

Apr 11 2018, 8:21 AM
mschiller added a comment to D12099: Repeat last action when pressing "=" or Enter.

I've seen similiar things to the "K" indicator marker, might be useful to know whether you already pressed equal or not, so you don't mess up your result.

Apr 11 2018, 8:11 AM

Apr 10 2018

mschiller requested review of D12099: Repeat last action when pressing "=" or Enter.
Apr 10 2018, 8:31 PM