Use new connection style
Needs ReviewPublic

Authored by tcanabrava on Sep 17 2018, 10:27 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Summary

This is safer, faster and compile time checked

Diff Detail

Repository
R319 Konsole
Branch
useNewConnectionStyle
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2951
Build 2969: arc lint + arc unit
tcanabrava created this revision.Sep 17 2018, 10:27 AM
Restricted Application added a project: Konsole. · View Herald TranscriptSep 17 2018, 10:27 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Sep 17 2018, 10:27 AM
anthonyfieroni added inline comments.
src/MainWindow.cpp
348

It should be setVisible on QMenuBar not on MainWindow

toggleMenuBarAction = KStandardAction::showMenubar(menuBar(), &QMenuBar::setVisible, collection);
tcanabrava added inline comments.Sep 19 2018, 7:47 AM
src/MainWindow.cpp
348

ups.

Are you working on this? I can help along if you want.

I forgot this for quite a while, I'll update today.