Load the keyboard on-demand
ClosedPublic

Authored by apol on Jul 13 2019, 12:53 AM.

Details

Summary

No need to load the keyboard view as soon as wayland starts. It's not a simple UI and it often will be unused.

Test Plan

played with the keyboard, still worked

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 13 2019, 12:53 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 13 2019, 12:53 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
apol requested review of this revision.Jul 13 2019, 12:53 AM

The idea of loading on startup was to verify that the view works and only offer the sni and other interactions if the virtual keyboard is functional - see the early return in line 86. This is IMHO a must have feature as we cannot properly set a dependency on the virtual keyboard qml component. If we can check in another way, I'm all for this change.

apol updated this revision to Diff 61834.Jul 16 2019, 1:21 AM

Use a different approach that will delay the creation of the keyboard

Given this patch still instantiates the engine and still creates the window object I think we'll get a simpler better patch putting a Loader inside main.qml which is bound to the window visibility.

apol updated this revision to Diff 62733.Jul 29 2019, 1:33 PM

Move the delayed loading of the keyboard to QML

davidedmundson accepted this revision.Aug 1 2019, 3:19 PM
This revision is now accepted and ready to land.Aug 1 2019, 3:19 PM
This revision was automatically updated to reflect the committed changes.