Move keep-above clients to the Normal layer when showing desktop
ClosedPublic

Authored by zzag on Apr 1 2019, 7:20 AM.

Details

Summary

Implementation of the Show Desktop feature moves desktop windows to
the Above layer, but it doesn't take into account existing clients
that belong to the Above layer. If there are any, we have to move
them to a layer below (e.g. normal), otherwise those clients will be
visible when showing the desktop.

BUG: 406101

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Apr 1 2019, 7:20 AM
Restricted Application added a project: KWin. · View Herald TranscriptApr 1 2019, 7:20 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Apr 1 2019, 7:20 AM

When I read the bug report I was wondering whether that's actually intended? Does keep above implies it's kept above other windows in all cases?

zzag added a comment.Apr 1 2019, 7:50 PM

When I read the bug report I was wondering whether that's actually intended? Does keep above implies it's kept above other windows in all cases?

I think the problem is the way this feature is implemented. To me show desktop and keep above are orthogonal. Thus, keep above windows ahve to be hidden.

graesslin accepted this revision.Apr 2 2019, 12:06 PM
This revision is now accepted and ready to land.Apr 2 2019, 12:06 PM
This revision was automatically updated to reflect the committed changes.

-1 Yakuake is now invisible when showing desktop (and toggling it in has no visible effect) and worse: Plasma popups, like the application launcher also don't show up. I would classify this bugreport as wontfix/intentional.

zzag added a comment.Apr 16 2019, 7:29 AM

-1

I think it's already too late for +1 or -1. ;-)

Yakuake is now invisible when showing desktop (and toggling it in has no visible effect)

I wonder whether it should be visible at all.

and worse: Plasma popups, like the application launcher also don't show up.

Hmm, I can see panel popups.

zzag added a comment.Apr 16 2019, 7:34 AM

Though krunner isn't visible...

zzag added a comment.Apr 16 2019, 7:36 AM

Argh, yeah, I'll probably revert this change.