Allow to set quarter tiling separately
Needs ReviewPublic

Authored by akozlovskiy on Feb 25 2019, 5:54 AM.


Group Reviewers

Makes it possible to set half and quarter (corner) tiling separately.
Now quarter tiling can actually be disabled (currently, 1% zone minimum).

Test Plan

In System Settings -> Desktop Behaviour -> Screen Edges -> Window Management test all possible combinations of checkboxes.

Diff Detail

R108 KWin
quarter-tiling-separated (branched from master)
Lint OK
No Unit Test Coverage
Build Status
Buildable 8838
Build 8856: arc lint + arc unit
akozlovskiy created this revision.Feb 25 2019, 5:54 AM
Restricted Application added a subscriber: kwin. · View Herald TranscriptFeb 25 2019, 5:54 AM
akozlovskiy requested review of this revision.Feb 25 2019, 5:54 AM
This comment was removed by akozlovskiy.
zzag added a subscriber: zzag.Feb 25 2019, 10:35 AM

Could you please add a test as well? See autotests/integration/quick_tiling_test.cpp

What's the use case? Why would someone want to enable only half tiling, but not quarter tiling?

akozlovskiy added a comment.EditedFeb 25 2019, 11:27 AM

Some points:

  • Dragging windows to the half tiling zone without aiming with mouse.
  • Content of the window can be invisible on smaller screens with quarter tiling (so what's the point for me to use it, let me just disable it).
  • Seamless experience for users that comes from another OS (Does OS X have quarter tiling? Windows have half only). Sorry, I was wrong. Windows has the same behaviour as KWin currently.

Also I think that they are logically different features, why they should be connected?

See also BUG:307214 BUG:306871 and BUG:404582 (mine).
Looks like the main point is that unexpected quarter tiling when dragging windows to the border annoys people.

I already expressed my concerns in the bug report: I consider this as featureitis and catering for a specific use case. I fear that the negative aspects of yet another checkbox (c.f. kde is too complicated). Also it creates yet another code path which nobody tests and those special use cases are the ones which tend to break.

graesslin requested changes to this revision.Feb 25 2019, 3:51 PM
graesslin added inline comments.

Please use new connect syntax.

This revision now requires changes to proceed.Feb 25 2019, 3:51 PM
abetts added a subscriber: abetts.Feb 25 2019, 3:52 PM

How would the interaction be with this patch? Video?

  • Use new connect syntax
akozlovskiy marked an inline comment as done.Mar 6 2019, 11:46 AM
zzag added a comment.Apr 26 2019, 2:13 PM

What's the use case? Why would someone want to enable only half tiling, but not quarter tiling?

It might be more convenient to folks who use/used Unity or GNOME Shell.

I share Martin's concern though. Introduction of yet another option doesn't sound good.