Teach kwaylandscanner about PrimarySelection
AcceptedPublic

Authored by gladhorn on Sep 16 2019, 6:58 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Summary

This allows generating the skeleton classes for the primary selection protocol.

Diff Detail

Repository
R127 KWayland
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 16650
Build 16668: arc lint + arc unit
gladhorn created this revision.Sep 16 2019, 6:58 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 16 2019, 6:58 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
gladhorn requested review of this revision.Sep 16 2019, 6:58 PM

@romangg and @davidedmundson any comments? I think @zzag prefers the class names without the V1. I'd like to progress on this step by step and the generator at least gives a good starting point.

meven added a subscriber: meven.Feb 18 2020, 4:54 PM

ping reviewers :)

davidedmundson accepted this revision.Feb 18 2020, 4:57 PM

I'm skeptical that kwaylandscanner adds anything, especially when we want to pretty much clone a class, but sure.

In terms of the names.

As for V1. We're not entirely consistent.

For anything unstable with the z prefix, it's probably worth it.
Otherwise we're trying to write a stable interface round something that inherently isn't stable...which is asking for trouble.

This revision is now accepted and ready to land.Feb 18 2020, 4:57 PM