Improve code that detects useful elements in an Svg file
Needs ReviewPublic

Authored by apol on Aug 30 2019, 3:47 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Frameworks
Summary

Detect any that contains a "-[a-z]" (i.e. a dash and a lowercase letter.
So far it was taking "digit*-digit*-anything*", which is clearly not
enough.

Also since we're already parsing the svg file in some cases, use that
parsing to detect the interesting ids.

Test Plan

Tests pass, plasma works

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
arcpatch-D23586
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20994
Build 21012: arc lint + arc unit
apol created this revision.Aug 30 2019, 3:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 30 2019, 3:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Aug 30 2019, 3:47 PM
gladhorn added inline comments.
src/plasma/svg.cpp
103–111

Maybe use "element" instead of "t" as variable name?

apol marked an inline comment as done.Jan 12 2020, 1:42 AM
apol updated this revision to Diff 73324.Jan 12 2020, 1:42 AM

address fregl's commetn