Differential D23947

[platforms/x11] Get rid of some code duplication in windowed backend
ClosedPublic
Actions

Authored by zzag on Sep 14 2019, 6:56 PM.

Details

Reviewers
gladhorn
Group Reviewers
KWin
Commits
R108:02209aa8a446: [platforms/x11] Get rid of some code duplication in windowed backend
Summary

We repeat quite a lot of code that finds an output by xcb_window_t and
translates global X11 screen coordinates to output coordinates.

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sep 14 2019, 6:56 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 14 2019, 6:56 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 14 2019, 6:56 PM
zzag edited the summary of this revision. (Show Details)Sep 14 2019, 7:09 PM
gladhorn accepted this revision.Sep 14 2019, 8:18 PM
gladhorn added a subscriber: gladhorn.

Nice, makes it easier to read :)

This revision is now accepted and ready to land.Sep 14 2019, 8:18 PM
Closed by commit R108:02209aa8a446: [platforms/x11] Get rid of some code duplication in windowed backend (authored by zzag). · Explain WhySep 14 2019, 9:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66096

View Options

plugins/platforms/x11/windowed/x11windowed_backend.h

Loading...
View Options

plugins/platforms/x11/windowed/x11windowed_backend.cpp

Loading...
View Options

plugins/platforms/x11/windowed/x11windowed_output.h

Loading...
View Options

plugins/platforms/x11/windowed/x11windowed_output.cpp

Loading...