Differential D23917

Use const_iterator
ClosedPublic
Actions

Authored by gladhorn on Sep 12 2019, 8:07 PM.

Details

Reviewers

zzag

Group Reviewers

KWin

Commits

R127:28841048d555: Use const_iterator

Summary

When trivial, replace iterators with the const version.

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

gladhorn created this revision.Sep 12 2019, 8:07 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 12 2019, 8:07 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

gladhorn requested review of this revision.Sep 12 2019, 8:07 PM

Harbormaster completed remote builds in B16449: Diff 65945.Sep 12 2019, 8:07 PM

fixup

Harbormaster completed remote builds in B16450: Diff 65946.Sep 12 2019, 8:08 PM

zzag added a subscriber: zzag.Sep 12 2019, 8:10 PM

zzag added inline comments.

src/server/output_interface.cpp
118–119	constEnd

zzag added inline comments.Sep 12 2019, 8:12 PM

src/client/registry.cpp
879	constEnd

If the container is const already there's no real reason to explicitly use constBegin which is effectively the same

In D23917#530297, @broulik wrote:

If the container is const already there's no real reason to explicitly use constBegin which is effectively the same

Yes, however it's still a good idea to be explicit about it.

Yes, for me always using constBegin/constEnd makes reading the code slightly easier.

src/client/registry.cpp
879	Thanks!
src/server/output_interface.cpp
118–119	Thanks!

Fixed two missing spots

Harbormaster completed remote builds in B16501: Diff 66021.Sep 14 2019, 8:29 AM

zzag accepted this revision.Sep 14 2019, 8:44 AM

This revision is now accepted and ready to land.Sep 14 2019, 8:44 AM

Closed by commit R127:28841048d555: Use const_iterator (authored by gladhorn). · Explain WhySep 14 2019, 9:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/client/plasmawindowmanagement.cpp (4 lines)
M			src/client/registry.cpp (10 lines)
M			src/server/keyboard_interface.cpp (2 lines)
M			src/server/output_interface.cpp (12 lines)
M			src/server/outputdevice_interface.cpp (4 lines)
M			src/server/seat_interface.cpp (10 lines)
M			tests/pasteclient.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65945	858d925		Sep 12 2019, 8:07 PM	★	★
Diff 2	65946	858d925	fixup	Sep 12 2019, 8:07 PM	★	★
Diff 3	66021	858d925	Fixed two missing spots	Sep 14 2019, 8:29 AM	★	★
Diff 4	66027	858d925	R127:28841048d555f4d37b08588322377c01d6bc5745	Sep 14 2019, 9:09 AM	★	★