[WIP] Fix loading button icons from qrc
Needs ReviewPublic

Authored by nicolasfella on Sun, Mar 22, 1:04 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary

Allow to use icon.source: "qrc:/testicon.png" in buttons.

WIP as there are a few things that seem weird to me. QIcon only seems to accept :/foo.png, not qrc:/foo.png, whereas I can't pass :/foo.png from QML and need to use qrc:/foo.png and hack away the prefix.

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Branch
qrcicons
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24048
Build 24066: arc lint + arc unit
nicolasfella created this revision.Sun, Mar 22, 1:04 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Mar 22, 1:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sun, Mar 22, 1:04 AM
apol added a subscriber: apol.Mon, Mar 23, 12:57 AM

Fixing QIcon would make sense but I'd say getting this in is not the worst thing either.

mart added inline comments.Mon, Mar 23, 11:45 AM
plugin/kquickstyleitem.cpp
218

should it also catch the ":/foo" case?